On Wednesday 27 July 2011, Eric Wing wrote:
> On 7/26/11, Alexander Neundorf <neund...@kde.org> wrote:
> > Hi,
> >
> > I just had a look at FindGIF.cmake and FindFreetype.cmake.
> > Both have similar code:
...
> > What about the two PATH_SUFFIXES lib64 and lib ? They shouldn't be
> > necessary.
> > Or, how is lib64 handled if I just give "/some/dir/lib" as argument to
> > PATHS ?
> > Is a lib64 version then checked too ? (I think no, but I'm not sure).
>
> Most of those probably can be removed safely. Those modules were
> written in another era when CMake had very little in the common core
> and no Mac OS X Framework support.
>
> That HKEY OSG_ROOT shouldn't be there. I don't know how that got snuck
> in. I was advocating for generic things like $ENV{GIF_DIR}. But now
> that it is there...I'm not sure about removing it.
>
> /usr/freeware was added because I think I got complaints from IRIX and
> Gentoo users?
> I forgot which platforms used /usr/local/X11. (Does/did FreeBSD use this
> one?)
Can you please give the FindGIFAndFreetypeCleanupAndEnhancements branch a try
?
http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/FindGIFAndFreetypeCleanupAndEnhancements
I removed the dirs which are IMO unnecessary.
What about ~/Library/Frameworks ?
Is this searched by default on OSX or not ?
If it works for you, I'll merge it into next then.
Alex
_______________________________________________
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
