Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-22 Thread Brad King
On 06/21/2016 09:25 PM, Gilles Khouzam wrote: > I've changed it to the Debug Universal C-Runtime > > This also leverages the version of the SDK to match the other > extensions reducing the risk of failures. Thanks, I've squashed that fixup in: VS: Add VS_SDK_REFERENCES target property to

Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-21 Thread Gilles Khouzam via cmake-developers
I've changed it to the Debug Universal C-Runtime which should be included with the SDK. This also leverages the version of the SDK to match the other extensions reducing the risk of failures. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Tuesday, June 21,

Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-21 Thread Gilles Khouzam via cmake-developers
I'll take a look to find an sdk that is included. Sent from my Windows 10 phone From: Brad King Sent: Tuesday, June 21, 2016 7:31 To: Gilles Khouzam Cc: cmake-developers@cmake.org Subject:

Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-21 Thread Brad King
On 06/20/2016 10:48 AM, Brad King wrote: > VS: Add VS_SDK_REFERENCES target property to reference external SDKs > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccc6270d This caused the VSWinStorePhone tests to fail, e.g.: https://open.cdash.org/testDetails.php?test=457508384=4422066

Re: [cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-20 Thread Brad King
On 06/17/2016 05:34 PM, Gilles Khouzam wrote: > This patch is to add the ability with Visual Studio generators > to add references to SDKs. Thanks, applied: VS: Add VS_SDK_REFERENCES target property to reference external SDKs https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccc6270d -Brad

[cmake-developers] Patch: Add the ability to specify SDK_REFERENCES for Visual Studio

2016-06-17 Thread Gilles Khouzam via cmake-developers
This patch is to add the ability with Visual Studio generators to add references to SDKs. This is similar to the DESKTOP, IOT and MOBILE extensions for Windows 10, but makes the process more generic, using the Property VS_SDK_REFERENCES as a semi-colon separated list. For example, adding a