Hi Brad,
Thanks! Looks good.
Cheers,
Attila
> On 23 Mar 2016, at 19:05, Brad King wrote:
>
> On 03/22/2016 08:23 AM, Attila Krasznahorkay wrote:
>> Here is my next attempt. ;-) Hopefully I'm at least getting closer...
>
> Thanks. Applied with minor tweaks:
>
> Makefile: Optionall
On 03/22/2016 08:23 AM, Attila Krasznahorkay wrote:
> Here is my next attempt. ;-) Hopefully I'm at least getting closer...
Thanks. Applied with minor tweaks:
Makefile: Optionally scan only source and build trees for dependencies
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b1e1aa1e
I
Dear Both,
Here is my next attempt. ;-) Hopefully I'm at least getting closer...
Cheers,
Attila
0001-Introducing-the-CMAKE_DEPENDS_IN_PROJECT_ONLY-variab.patch
Description: Binary data
> On 18 Mar 2016, at 16:57, David Cole wrote:
>
> Brad's point with "/" or null terminator
Brad's point with "/" or null terminator was that the directory name
**must** be the directory itself, or a sub-directory of the one in
question.
i.e.
if it's "my/src"
then it should either be exactly "my/src" or "my/src/someSubDir" , not
"my/srcSiblingDir"
On Fri, Mar 18, 2016 at 11:52 AM,
On 03/17/2016 09:54 AM, Attila Krasznahorkay wrote:
> Attached is a new attempt. It seems to work correctly in my tests
> with the Makefile generator.
Thanks.
> + // If it's an absolute path, check if it starts with the source
> + // direcotory:
> + return ( ( path.find( SourceDir
Hi Brad,
Attached is a new attempt. It seems to work correctly in my tests with the
Makefile generator. (Which, to be fair, is the only generator that we use in
production mode at the moment...)
Cheers,
Attila
0001-CMAKE_DEPENDS_IN_PROJECT_ONLY-feature-addition.patch
Description:
Hi Brad,
>> + // If it's an absolute path, check if it starts with the source
>> + // direcotory:
>> + return ( ( path.find( SourceDir ) != 0 ) &&
>> + ( path.find( BinaryDir ) != 0 ) );
>
> Please look at using strncmp and a check that the following character
> is a
Hi Brad,
All valid points. Will try to make a new patch today.
Cheers,
Attila
> On 15 Mar 2016, at 19:13, Brad King wrote:
>
> On 03/15/2016 10:48 AM, Attila Krasznahorkay wrote:
>> https://cmake.org/pipermail/cmake-developers/2015-December/027197.html
>>
>> With the following patc
On 03/15/2016 10:48 AM, Attila Krasznahorkay wrote:
> https://cmake.org/pipermail/cmake-developers/2015-December/027197.html
>
> With the following patch, when setting the CMAKE_ONLY_IN_SOURCE_DEPENDENCIES
> variable to 1/ON/TRUE, this file size goes down to just a few kilobytes.
> Speeding up our
Dear All,
I've already talked about this a bit back in December.
https://cmake.org/pipermail/cmake-developers/2015-December/027197.html
I looked at this issue today again, as in our builds we can be seriously
hampered by "cmake -E cmake_depends" calls. And then, by the huge dependency
trees th
10 matches
Mail list logo