[cmake-developers] Review request: fix-Qt5-windows-build

2014-03-12 Thread Stephen Kelly
Hi, I didn't follow the encoding work done by Clinton, and in my Qt 5 build with default settings, the new codepage related definition is not set. However, if it is set somehow, then the build would be calling methods which are not present in Qt 5. I've just pushed a topic fixing that, but

Re: [cmake-developers] Review request: fix-Qt5-windows-build

2014-03-12 Thread Clinton Stimpson
On Wednesday, March 12, 2014 05:21:30 PM Stephen Kelly wrote: Hi, I didn't follow the encoding work done by Clinton, and in my Qt 5 build with default settings, the new codepage related definition is not set. However, if it is set somehow, then the build would be calling methods which are

Re: [cmake-developers] Review request: fix-Qt5-windows-build

2014-03-12 Thread Stephen Kelly
Clinton Stimpson wrote: I personally would prefer a Qt version check This compiles: diff --git a/Source/QtDialog/CMakeSetup.cxx b/Source/QtDialog/CMakeSetup.cxx index 995929e..d1fbe9f 100644 --- a/Source/QtDialog/CMakeSetup.cxx +++ b/Source/QtDialog/CMakeSetup.cxx @@ -79,12 +79,14 @@

Re: [cmake-developers] Review request: fix-Qt5-windows-build

2014-03-12 Thread Clinton Stimpson
On Wednesday, March 12, 2014 05:50:09 PM Stephen Kelly wrote: Clinton Stimpson wrote: I personally would prefer a Qt version check This compiles: diff --git a/Source/QtDialog/CMakeSetup.cxx b/Source/QtDialog/CMakeSetup.cxx index 995929e..d1fbe9f 100644 ---

Re: [cmake-developers] Review request: fix-Qt5-windows-build

2014-03-12 Thread Stephen Kelly
Clinton Stimpson wrote: Thanks. I can also do a runtime check on this code with Qt5. By the way, can you confirm that you are not currently seeing compile errors? I don't think anyone would see these compile errors unless they manually add a cmake variable to the cache to enable the utf-8