On 02/19/2013 02:45 PM, Alexander Neundorf wrote:
On Monday 18 February 2013, Brad King wrote:
Why not also pass in the name of the _FOUND variable e.g.
FPHSA(Foo DEFAULT_MSG FOO_INCLUDE_DIR FOO_LIBRARY
FOUND_VAR Foo_FOUND)
I agree with this, OTOH the maintainer could now write
On Thursday 21 February 2013, Brad King wrote:
On 02/19/2013 02:45 PM, Alexander Neundorf wrote:
...
Well, FPHSA could error out if FOUND_VAR does not equal PackageName_FOUND
or PACKAGENAME_FOUND, but this would be somewhat strange.
IMO that would be better. It's not much different from a
On 02/21/2013 12:36 PM, Alexander Neundorf wrote:
On Thursday 21 February 2013, Brad King wrote:
On 02/19/2013 02:45 PM, Alexander Neundorf wrote:
...
Well, FPHSA could error out if FOUND_VAR does not equal PackageName_FOUND
or PACKAGENAME_FOUND, but this would be somewhat strange.
IMO that
On Thursday 21 February 2013, Brad King wrote:
On 02/21/2013 12:36 PM, Alexander Neundorf wrote:
On Thursday 21 February 2013, Brad King wrote:
On 02/19/2013 02:45 PM, Alexander Neundorf wrote:
...
Well, FPHSA could error out if FOUND_VAR does not equal
PackageName_FOUND or
On 02/21/2013 03:52 PM, Alexander Neundorf wrote:
Done, I merged FPHSA_FOUND_VAR_OPTION into next.
Great, thanks!
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the
On Friday 15 February 2013, Alexander Neundorf wrote:
On Friday 15 February 2013, Stephen Kelly wrote:
Hi,
FindPackageHandleStandardArgs sets an uppercase found variable, but not
an ExactCase_FOUND variable. This is inconsistent with how config files
work. It also imposes on users the
On Monday 18 February 2013, Brad King wrote:
On 02/18/2013 04:52 PM, Stephen Kelly wrote:
Anyway, I don't agree with your conclusion, but I guess Brad gets the
casting vote of doing nothing or not. I understand your position and you
understand mine I'm sure. All that's needed is to decide
On Monday 18 February 2013, Stephen Kelly wrote:
Alexander Neundorf wrote:
I mean, even if FPHSA would set ExactCase_FOUND always by default, there
still would be no guarantee at all that after a
find_package(Foo)
Foo_FOUND will be set, because as a user of that module I don't know
On 2013-02-19 15:09, Alexander Neundorf wrote:
I don't see where automatically setting ExactCase_FOUND improves over the
current situation.
Right now, as a user of a Find-module you can only rely on the variables as
documented for each Find-module.
This sounds like a bug. Why not just fix
On 02/19/2013 03:54 PM, Matthew Woehlke wrote:
This sounds like a bug. Why not just fix those find modules not using FPHSA?
Then you could document in find_package() that ExactCase_FOUND is set if
the package is found. (And consider deprecating UpperCase_FOUND.)
Many find modules are
On Tuesday 19 February 2013, Matthew Woehlke wrote:
On 2013-02-19 15:09, Alexander Neundorf wrote:
I don't see where automatically setting ExactCase_FOUND improves over the
current situation.
Right now, as a user of a Find-module you can only rely on the variables
as documented for
On 2013-02-19 16:21, Alexander Neundorf wrote:
On Tuesday 19 February 2013, Matthew Woehlke wrote:
On 2013-02-19 15:09, Alexander Neundorf wrote:
I don't see where automatically setting ExactCase_FOUND improves over the
current situation.
Right now, as a user of a Find-module you can only
On Tuesday 19 February 2013, Matthew Woehlke wrote:
On 2013-02-19 16:21, Alexander Neundorf wrote:
On Tuesday 19 February 2013, Matthew Woehlke wrote:
On 2013-02-19 15:09, Alexander Neundorf wrote:
I don't see where automatically setting ExactCase_FOUND improves over
the current
Alexander Neundorf wrote:
On Friday 15 February 2013, Stephen Kelly wrote:
Hi,
FindPackageHandleStandardArgs sets an uppercase found variable, but not
an ExactCase_FOUND variable. This is inconsistent with how config files
work. It also imposes on users the necessity that their FOUND
On Monday 18 February 2013, Stephen Kelly wrote:
Alexander Neundorf wrote:
On Friday 15 February 2013, Stephen Kelly wrote:
Hi,
FindPackageHandleStandardArgs sets an uppercase found variable, but not
an ExactCase_FOUND variable. This is inconsistent with how config files
work. It
Alexander Neundorf wrote:
I mean, even if FPHSA would set ExactCase_FOUND always by default, there
still would be no guarantee at all that after a
find_package(Foo)
Foo_FOUND will be set, because as a user of that module I don't know
whether it uses FPHSA or not. I have to read the
On 02/18/2013 04:52 PM, Stephen Kelly wrote:
Anyway, I don't agree with your conclusion, but I guess Brad gets the
casting vote of doing nothing or not. I understand your position and you
understand mine I'm sure. All that's needed is to decide :).
One thing that has always bothered me about
Am Montag, 18. Februar 2013, 17:17:40 schrieb Brad King:
On 02/18/2013 04:52 PM, Stephen Kelly wrote:
Anyway, I don't agree with your conclusion, but I guess Brad gets the
casting vote of doing nothing or not. I understand your position and you
understand mine I'm sure. All that's needed is
18 matches
Mail list logo
