Sorry, I'm also very late on this thread, but there was a suggestion
that codesigning should be in CMake instead of CPack. I agree and also
say it needs to be integrated as part of the build process when
specified.
Here's a real world workflow. I use JavaScriptCore in my Mac
application which
Thanks for providing the patch.
http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=2c50db26
Clint
On Wednesday, March 18, 2015 08:24:36 AM A. Klitzing wrote:
Ping? :-)
Am 11.03.2015 13:21 schrieb A. Klitzing aklitz...@gmail.com:
Hi there!
I added another improvement to the codesign
Ping? :-)
Am 11.03.2015 13:21 schrieb A. Klitzing aklitz...@gmail.com:
Hi there!
I added another improvement to the codesign feature. Sometimes it is
helpful to overwrite or pass additional parameters like --timestamp=none
to codesign.
But this shouldn't be the default for everyone.
So I
Hi there!
I added another improvement to the codesign feature. Sometimes it is
helpful to overwrite or pass additional parameters like --timestamp=none
to codesign.
But this shouldn't be the default for everyone.
So I added the variable CPACK_BUNDLE_APPLE_CODESIGN_PARAMETER.
Hope you like it.
Hi Clint,
I have another patch to tweak the error output a little bit. If codesign
fails it won't be possible to get the error message of codesign itself.
That is a little bit confusing because it just fails without an
understandable reason.
This patch will print the output of codesign if it
On Friday, February 20, 2015 12:07:55 PM A. Klitzing wrote:
Hi Clint,
I have another patch to tweak the error output a little bit. If codesign
fails it won't be possible to get the error message of codesign itself.
That is a little bit confusing because it just fails without an
Hi there!
As requested... I renamed the 3 APPLE variables to BUNDLE_APPLE in attached
patch.
Thanks
André Klitzing
Clinton Stimpson clin...@elemtech.com schrieb am Mon Oct 27 2014 at
17:42:50:
Hi André,
I can help you get this patch into the git repo. But before doing that,
Brad
Thanks for the patch.
Its in the repository now.
http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=bd3fbf3
Clint
On Tuesday, October 28, 2014 06:18:34 PM A. Klitzing wrote:
Hi there!
As requested... I renamed the 3 APPLE variables to BUNDLE_APPLE in attached
patch.
Thanks
André
On 10/21/2014 11:44 AM, Clinton Stimpson wrote:
Because the design of this Bundle generator is not consistent with the rest
of
the CPack generators, you don't have this same chance, and the only way to do
customization is to keep adding patches like yours.
Is this something that should be
On Thursday, October 23, 2014 11:13:15 AM Brad King wrote:
On 10/21/2014 11:44 AM, Clinton Stimpson wrote:
Because the design of this Bundle generator is not consistent with the
rest of the CPack generators, you don't have this same chance, and the
only way to do customization is to keep
Let me put my 2¢. I have feeling that we are mixing up signing (install)
packages, such as .pkg (OSX) or .msi (Windows), with signing bundles .app or
whatever OSX binaries (that can keep signature inside macho).
I think that CPack should be responsible of signing only what it creates. Since
On 10/23/2014 12:21 PM, Clinton Stimpson wrote:
Actually, the design is intentional -- that is, it has the feature of
creating
the application bundle for you, which involves handling for icons,
Info.plist,
and now the proposed code signing. Alternatively, we have handling for icons
and
Hi,
I attached another patch to address the given issues.
On 09/26/2014 10:08 AM, clin...@elemtech.com wrote:
I would suggest the SignPackage function be moved from
cmCPackDragNDropGenerator to cmCPackBundleGenerator because
its implementation is only usable by cmCPackBundleGenerator.
On Tuesday, October 21, 2014 04:37:56 PM A. Klitzing wrote:
Hi,
I attached another patch to address the given issues.
On 09/26/2014 10:08 AM, clin...@elemtech.com wrote:
I would suggest the SignPackage function be moved from
cmCPackDragNDropGenerator to cmCPackBundleGenerator because
André,
Please respond with comments or an updated patch to address Clinton's
review comments in order to help this contribution proceed.
On 09/26/2014 10:08 AM, clin...@elemtech.com wrote:
I would suggest the SignPackage function be moved from
cmCPackDragNDropGenerator to
It should not be an error for 'codesign' to not be available
in the PATH. The user may have set CPACK_COMMAND_CODESIGN
to some other location. The error should only occur if no
value for CPACK_COMMAND_CODESIGN is available when the tool
is actually needed for signing.
I attached another
- Original Message -
It should not be an error for 'codesign' to not be available
in the PATH. The user may have set CPACK_COMMAND_CODESIGN
to some other location. The error should only occur if no
value for CPACK_COMMAND_CODESIGN is available when the tool
is actually
Maybe it shouldn't even be a CPack thing. Maybe it should be an
install time step so that all CPack generators will contains signed
binaries if codesign is used...
D
On Mon, Sep 29, 2014 at 9:55 AM, clin...@elemtech.com wrote:
It should not be an error
Maybe it shouldn't even be a CPack thing. Maybe it should be an
install time step so that all CPack generators will contains signed
binaries if codesign is used...
I know this is a bit after the fact and I'm jumping in here pretty late,
but...
It would be nice to have package signing as
On Monday, September 29, 2014 01:23:04 PM Chuck Atkins wrote:
Maybe it shouldn't even be a CPack thing. Maybe it should be an
install time step so that all CPack generators will contains signed
binaries if codesign is used...
I know this is a bit after the fact and I'm jumping in here
Well, first patch had a little mistake. I attached an update...
From 4e19b766ff26a73f4667d8f88ab6ad64c40c37d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Klitzing?= aklitz...@gmail.com
Date: Fri, 26 Sep 2014 09:28:02 +0200
Subject: [PATCH] Add support for codesign on MacOS
---
On 09/25/2014 04:40 PM, A. Klitzing wrote:
I refactored the patches of Brian Milco to support
code signing of bundles in MacOS.
[snip]
On 09/26/2014 03:29 AM, A. Klitzing wrote:
Well, first patch had a little mistake. I attached an update...
Thanks!
I've applied the patch and merged to our
I would suggest the SignPackage function be moved from
cmCPackDragNDropGenerator to cmCPackBundleGenerator because its implementation
is only usable by cmCPackBundleGenerator. It uses CPACK_BUNDLE_NAME which is
only valid in the context of cmCPackBundleGenerator.
Clint
- Original
On 09/26/2014 09:52 AM, Brad King wrote:
I've applied the patch and merged to our 'next' branch for
testing:
CPack: Add support for code signing of bundles on MacOS
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1a9b0668
I reverted the topic because several CPackComponents tests
fail
Hi there,
I refactored the patches of Brian Milco to support code signing of bundles
in MacOS. As we don't need AppStore support at the moment we didn't added
the special generator for it. That could be a separate step later.
As long as it runs codesign only it should be trivial enough to add
25 matches
Mail list logo
