Re: [cmake-developers] Toward a more deterministic ninja generator

2016-06-17 Thread Nicolas Desprès
On Thu, Jun 16, 2016 at 7:14 PM, Brad King wrote: > On 06/14/2016 11:18 AM, Nicolas Desprès wrote: > > It makes the ninja generator more deterministic by sorting the > > build edge's inputs/outputs. It does not introduce any > > regression on my macbookpro. > > > > This

Re: [cmake-developers] Toward a more deterministic ninja generator

2016-06-16 Thread Brad King
On 06/14/2016 11:18 AM, Nicolas Desprès wrote: > It makes the ninja generator more deterministic by sorting the > build edge's inputs/outputs. It does not introduce any > regression on my macbookpro. > > This could help to fix issue #15968. What examples of non-determinism have you observed

Re: [cmake-developers] Toward a more deterministic ninja generator

2016-06-15 Thread Florent Castelli
To this, I would add that you could also remove duplicates. They’re rare but can happen in some conditions and trigger warnings in Ninja. /Florent > On 14 Jun 2016, at 17:18, Nicolas Desprès wrote: > > Hi, > > While working on something else I wrote this patch: >

[cmake-developers] Toward a more deterministic ninja generator

2016-06-14 Thread Nicolas Desprès
Hi, While working on something else I wrote this patch: https://github.com/nicolasdespres/CMake/commit/59e4e62ba014c6fcd4519b57b621d9434f99ff19 It makes the ninja generator more deterministic by sorting the build edge's inputs/outputs. It does not introduce any regression on my macbookpro. This