On 05/02/2013 01:14 PM, Brad King wrote:
On 05/02/2013 10:57 AM, Stephen Kelly wrote:
I've added a patch to fix-per-config-tll-include-dirs in my clone. Is that
what you're looking for?
Yes.
Thanks.
I've rewritten that topic history to organize the net fixes into
three commits:
Brad King wrote:
On 04/30/2013 07:38 PM, Stephen Kelly wrote:
Brad King wrote:
Reading the commit messages and code in more detail, it looks wrong
to have CachedLinkInterfaceIncludeDirectoriesEntries not per-config.
It looks like the generated value can be different per-config and
currently
On 05/02/2013 02:46 AM, Stephen Kelly wrote:
Brad King wrote:
On 04/30/2013 07:38 PM, Stephen Kelly wrote:
I'm saying that even after the current version of the topic the
caching is still accumulating across configurations in multi-config
generators. AFAICT that part is not yet fixed. The
Brad King wrote:
On 05/02/2013 02:46 AM, Stephen Kelly wrote:
Brad King wrote:
On 04/30/2013 07:38 PM, Stephen Kelly wrote:
I'm saying that even after the current version of the topic the
caching is still accumulating across configurations in multi-config
generators. AFAICT that part is
On 05/02/2013 10:57 AM, Stephen Kelly wrote:
I've added a patch to fix-per-config-tll-include-dirs in my clone. Is that
what you're looking for?
Yes.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Brad King wrote:
On 04/29/2013 06:29 AM, Stephen Kelly wrote:
I've force-pushed the fix-multi-config-tll-include-dirs branch with a
more- simple fix for this issue to my clone.
Okay, that looks good. Please rebase on the partial fix I merged last
week so we can test it in 'next'. I'll
On 04/30/2013 04:55 AM, Stephen Kelly wrote:
Brad King wrote:
Okay, that looks good. Please rebase on the partial fix I merged last
week so we can test it in 'next'. I'll squash all that together later.
Ok, done.
Reading the commit messages and code in more detail, it looks wrong
to have
Stephen Kelly wrote:
It can probably be refactored to bypass the genex evaluation though.
The refactoring I described can be done in the future I think, but doesn't
really solve the bug anyway, because it is evaluation of the generator
expression for the target itself which is causing
On 04/29/2013 06:29 AM, Stephen Kelly wrote:
I've force-pushed the fix-multi-config-tll-include-dirs branch with a more-
simple fix for this issue to my clone.
Okay, that looks good. Please rebase on the partial fix I merged last
week so we can test it in 'next'. I'll squash all that together
Brad King wrote:
On Fri, Apr 26, 2013 at 10:39 AM, Stephen Kelly
steve...@gmail.com wrote:
Brad King brad.king@... writes:
I looked into implementing this and realized that we're not propagating
usage requirements from the entire link closure, only from the direct
dependencies.
Are you
Brad King wrote:
The caching is simplified because we never need to clear it since these
are now only called during generation and never during configuration.
I've looked again at the code, and there is a condition for clearing the
cache if not configuring. I think this is because of export()
Brad King brad.king@... writes:
I looked into implementing this and realized that we're not propagating
usage requirements from the entire link closure, only from the direct
dependencies.
Are you sure? Maybe I don't understand what you mean. Can you post a code
snippet?
add_library(foo
On Fri, Apr 26, 2013 at 10:39 AM, Stephen Kelly steve...@gmail.com wrote:
Brad King brad.king@... writes:
I looked into implementing this and realized that we're not propagating
usage requirements from the entire link closure, only from the direct
dependencies.
Are you sure? Maybe I don't
On 04/25/2013 03:34 AM, Stephen Kelly wrote:
I haven't had time to investigate fully, but this patch should 'fix' the
problem:
[snip]
I'll investigate later to see if it's the right fix and why.
Great! I've turned that patch into this commit:
On 04/25/2013 11:02 AM, Stephen Kelly wrote:
Brad King wrote:
Great! I've turned that patch into this commit:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=de9d4a63
See commit message for an explanation that makes sense to me.
The commit message is correct, but it's not the whole
Brad King wrote:
I've pushed the fix-multi-config-tll-include-dirs branch to my clone.
That's a much more detailed explanation, thanks.
Pre-evaluating the expression as Debug regardless of the
configuration involved feels like a hack. Since this all occurs
at generate time already
On 4/25/2013 6:15 PM, Stephen Kelly wrote:
Brad King wrote:
Why can't GetIncludeDirectories just evaluate it-Value as a
genex with the current configuration, and if it is a valid target
name then lookup its INTERFACE_INCLUDE_DIRECTORIES and use that
immediately?
Good question. Reading the
17 matches
Mail list logo
