Re: [cmake-developers] [PATCH] Sort list of files for aux_source_directory() and file(glob, *)

2016-09-28 Thread Brad King
On 09/27/2016 08:07 PM, Junghyun Kim wrote: > 1) Add the same sort logic of the patch(#14491) to > cmAuxSourceDirectoryCommand.cxx > 2) Apply my patch and remove the sort logic of patch #14491 Please patch cmAuxSourceDirectoryCommand.cxx directly. KWSys Directory is a low-level API whose

Re: [cmake-developers] [PATCH] Sort list of files for aux_source_directory() and file(glob,*)

2016-09-27 Thread Junghyun Kim
Thanks for the information.   I am very happy that I do not need to justify the necessity of this feature.   On the other hand, I think this feature should also be applied to aux_source_directory() in order to support legacy projects.   There are two ways to implement it. 1) Add the

Re: [cmake-developers] [PATCH] Sort list of files for aux_source_directory() and file(glob, *)

2016-09-27 Thread Brad King
On 09/27/2016 12:20 AM, Junghyun Kim wrote: > If aux_source_directory(. SRCS) or file(glob SRCS "*.c") is used > files in SRCS are not sorted. The file(GLOB) command sorts as of CMake 3.6: file: Sort GLOB results to make it deterministic (#14491)