Re: [cmake-developers] [PATCH] cmFileCommand: sort list of files from glob command

2016-05-17 Thread Brad King
On 05/16/2016 05:23 PM, Reiner Herrmann wrote: > Unfortunately many projects still use this for finding source files [1], > without considering sorting. > Without sorting it in file(GLOB), most of those packages have to be > patched individually. Would sorting by default really have such a > notic

Re: [cmake-developers] [PATCH] cmFileCommand: sort list of files from glob command

2016-05-16 Thread Reiner Herrmann
On Mon, May 16, 2016 at 09:27:57AM -0400, Brad King wrote: > This has been proposed several times and never accepted because file(GLOB) > is a primitive. As Petr said our documentation explicitly discourages > the use case in question. Those projects that wish to ignore our advice > can use list(

Re: [cmake-developers] [PATCH] cmFileCommand: sort list of files from glob command

2016-05-16 Thread Brad King
On 05/16/2016 03:06 AM, Petr Kmoch wrote: > I'd like to express my concerns about the proposed change. > CMake strongly discourages using `file(GLOB)` to find source files [snip] > On 14 May 2016 at 12:30, Reiner Herrmann wrote: > @@ -1026,6 +1026,7 @@ bool > cmFileCommand::HandleGlobCommand(s

Re: [cmake-developers] [PATCH] cmFileCommand: sort list of files from glob command

2016-05-16 Thread Chuck Atkins
> > I'd like to express my concerns about the proposed change. CMake strongly > discourages using `file(GLOB)` to find source files, since file additions > then do not automatically trigger a buildsystem regeneration. > I second this. The intent of the patch is to address an issue that is only pr

Re: [cmake-developers] [PATCH] cmFileCommand: sort list of files from glob command

2016-05-16 Thread Petr Kmoch
Hi all. I'd like to express my concerns about the proposed change. CMake strongly discourages using `file(GLOB)` to find source files, since file additions then do not automatically trigger a buildsystem regeneration. So well-behaved projects, which do not feed such outputs to add_*() commands, wi