Re: [cmake-developers] [PATCH v7] For Windows encode process output to internally used encoding

2016-10-30 Thread Dāvis Mosāns
2016-08-17 16:47 GMT+03:00 Brad King : > I squashed in one warning fix: > > Windows: Encode child process output to internally-used encoding > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=12924660 > > However, then I had to revert the change from `next` because it >

Re: [cmake-developers] [PATCH v7] For Windows encode process output to internally used encoding

2016-08-17 Thread Brad King
On 08/17/2016 06:11 AM, Dāvis Mosāns wrote: >> Applied with minor tweaks and merged to `next` for testing: > > Great! Thanks! I squashed in one warning fix: Windows: Encode child process output to internally-used encoding https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=12924660 However,

Re: [cmake-developers] [PATCH v7] For Windows encode process output to internally used encoding

2016-08-16 Thread Brad King
On 08/15/2016 04:34 PM, Dāvis Mosāns wrote: > Typically Windows applications (eg. MSVC compiler) use current console's > codepage for output to pipes so we need to encode that to internally used > encoding (KWSYS_ENCODING_DEFAULT_CODEPAGE). Thanks. Applied with minor tweaks and merged to `next`