On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffmanbill.hoff...@kitware.com wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffmanbill.hoff...@kitware.com wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the
On Wed, Jul 18, 2012 at 12:10 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 18.07.2012 11:58, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 11:39 PM, Bill Hoffmanbill.hoff...@kitware.com
wrote:
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On
On 7/17/2012 8:10 AM, Peter Kümmel wrote:
On 17.07.2012 13:45, David Cole wrote:
Peter, can you rebase this on current 'master', push this to our stage
as a branch, and merge it to 'next'...?
Done. Let's see what happens on CDash.
Looks ok, but is not building on Borland:
On 17.07.2012 15:39, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 3:29 PM, Bill Hoffmanbill.hoff...@kitware.com wrote:
On 7/17/2012 8:10 AM, Peter Kümmel wrote:
On 17.07.2012 13:45, David Cole wrote:
Peter, can you rebase this on current 'master', push this to our stage
as a branch, and
On Tue, Jul 17, 2012 at 7:01 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 17.07.2012 15:39, Nicolas Desprès wrote:
On Tue, Jul 17, 2012 at 3:29 PM, Bill Hoffmanbill.hoff...@kitware.com
wrote:
On 7/17/2012 8:10 AM, Peter Kümmel wrote:
On 17.07.2012 13:45, David Cole wrote:
Peter, can
On 17.07.2012 19:11, Nicolas Desprès wrote:
I don't like the friend keyword either but I try to follow the current
architecture of CMake.
Yes, I know.
In cmLocalUnixMakefileGenerator you can see that:
friend class cmMakefileTargetGenerator;
friend class
On Tue, Jul 17, 2012 at 7:21 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 17.07.2012 19:11, Nicolas Desprès wrote:
I don't like the friend keyword either but I try to follow the current
architecture of CMake.
Yes, I know.
In cmLocalUnixMakefileGenerator you can see that:
friend
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
Thanks.
--
Bill Hoffman
Kitware, Inc.
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now so we can get the dashboard
building again.
On 7/17/2012 1:43 PM, Peter Kümmel wrote:
On 17.07.2012 19:32, Bill Hoffman wrote:
On 7/17/2012 1:21 PM, Peter Kümmel wrote:
OK, maybe it is simpler to add a the functions to
cmNinjaTargetGenerator which
forwards the call to the Local/Global classes.
Lets just add the friend stuff for now
On 07.07.2012 20:54, Nicolas Desprès wrote:
I have pushed the re-factor patch. Let me know what do you think. I
have tested on Linux and MacOSX with the Makefile and Ninja generator
and both work fine.
I've tested it here and BundleTest still fails.
It doesn't install the Resource files.
On Fri, Jul 6, 2012 at 9:56 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 7/6/2012 12:45 PM, Nicolas Desprčs wrote:
Both work. Generally I use helper class with language not supporting
multiple inheritance but if you prefer not to use it that's not a
problem. I'll do the patch. Thanks
On 07.07.2012, at 20:54, Nicolas Desprès wrote:
I have pushed the re-factor patch. Let me know what do you think. I
have tested on Linux and MacOSX with the Makefile and Ninja generator
and both work fine.
Which OS version and Tools do you have installed?
I merged in your patch and have
On Sat, Jul 7, 2012 at 9:02 PM, Claus Klein claus.kl...@arcormail.de wrote:
On 07.07.2012, at 20:54, Nicolas Desprès wrote:
I have pushed the re-factor patch. Let me know what do you think. I
have tested on Linux and MacOSX with the Makefile and Ninja generator
and both work fine.
Which OS
I forgot to say that most of the code is duplicated from the Makefile
generator. I have left some todo but this code will need to be
factored sooner or later.
On Fri, Jul 6, 2012 at 12:54 PM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
Hi,
I finally found the time to fix the Ninja
We should re-factor it sooner (not later).
This is great, thank you very much!
But we should definitely re-factor it before merging it to 'master'
Thx,
David
On Fri, Jul 6, 2012 at 7:05 AM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
I forgot to say that most of the code is duplicated
On 06.07.2012 12:54, Nicolas Desprès wrote:
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
(https://github.com/jkp/CMake/commits/jkp/ninja-generator). Although
there are other patches in this branch,
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and CreateAppBundle. WDYT?
Cheers,
Nico
On Fri, Jul 6, 2012 at 1:13 PM, David Cole david.c...@kitware.com wrote:
We should
On Fri, Jul 6, 2012 at 1:29 PM, Peter Kümmel syntheti...@gmx.net wrote:
On 06.07.2012 12:54, Nicolas Desprès wrote:
Hi,
I finally found the time to fix the Ninja generator on OS X. Mainly I
have fixed ExportImport and Qt4Deploy. I based my work on jkp's work
On 7/6/2012 7:33 AM, Nicolas Desprès wrote:
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and CreateAppBundle. WDYT?
Cheers,
Nico
Thanks, this is great.
I am not a big fan
On Fri, Jul 6, 2012 at 3:52 PM, Bill Hoffman bill.hoff...@kitware.com wrote:
On 7/6/2012 7:33 AM, Nicolas Desprès wrote:
I agree. Any idea how you would like to re-factor it? I am thinking
about using multiple inheritance by introducing a cmOSXBundleGenerator
class with CreateFramework and
On 7/6/2012 12:45 PM, Nicolas Desprès wrote:
Both work. Generally I use helper class with language not supporting
multiple inheritance but if you prefer not to use it that's not a
problem. I'll do the patch. Thanks for answering.
Great, thanks for doing the work. Lets go with the helper class,
24 matches
Mail list logo
