Re: [cmake-developers] [PATCH] Add Clang support to FindOpenMP

On 12/10/2015 10:49 AM, Chris Pavlina wrote: > Attached is a patch to add the correct option for building OpenMP > code using Clang. Thanks, applied: FindOpenMP: Add Clang support https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1549927d -Brad -- Powered by www.kitware.com Please keep

Re: [cmake-developers] set(CACHE) and the local scope

On Wednesday, December 09, 2015 17:35:28 Ben Boeckel wrote: > Hi, > > So some behavior I was unaware of until today came up: > > set(var ON) > option(var "description" OFF) > message("var: ${var}") Assuming I wouldn't know about the subtle characteristics of normal vs. cache

Re: [cmake-developers] [CMake][PATCH] AIX RPATH handling

Hi, I identify the root of the problem: if I specify version 3.4 in cmake_minimum_required, generated link command (stored in file link.txt) for an executable does not contains value specified in variable CMAKE_SHARED_LIBRARY_LINK_${lang}_FLAGS. Specifying 3.3 fix the problem. So this is a

Re: [cmake-developers] set(CACHE) and the local scope

On Thursday, December 10, 2015 15:26:54 Brad King wrote: > On 12/10/2015 03:20 PM, Alexander Neundorf wrote: > >> set(var ON) > >> option(var "description" OFF) > >> message("var: ${var}") > > > > I.e. on the first run it would be OFF (since that's the default value > > of the option), and all

Re: [cmake-developers] set(CACHE) and the local scope

On Thu, Dec 10, 2015 at 21:20:21 +0100, Alexander Neundorf wrote: > On Wednesday, December 09, 2015 17:35:28 Ben Boeckel wrote: > > So some behavior I was unaware of until today came up: > > > > set(var ON) > > option(var "description" OFF) > > message("var: ${var}") > > Assuming I

Re: [cmake-developers] set(CACHE) and the local scope

On 12/10/2015 03:20 PM, Alexander Neundorf wrote: >> set(var ON) >> option(var "description" OFF) >> message("var: ${var}") > > I.e. on the first run it would be OFF (since that's the default value > of the option), and all later runs it would have the value which is in the > cache. This is

Re: [cmake-developers] [PATCH] Imported targets for FindGTest

> - Add unit test to test imported targets and existing variables I should mention that to run the unit test, you must define the GTEST_ROOT environment variable to point to the gtest build, due to gtest being annoyingly crippled to be uninstallable for dubious reasons. You can pass

Re: [cmake-developers] [PATCH] Imported targets for FindGTest

> - Adds GTest::GTest and GTest::Main imported targets (including > Thread::Thread dependency for GTest::GTest and GTest::GTest for > GTest::Main; the latter might not be appropriate and could be removed if > needed--but I'm unaware of any situation where you would want to use > GTest::Main

[cmake-developers] [PATCH] Imported targets for FindGTest

Pushed to https://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/gtest- imported-targets and merged into next for review and testing. - Adds GTest::GTest and GTest::Main imported targets (including Thread::Thread dependency for GTest::GTest and GTest::GTest for GTest::Main; the

Re: [cmake-developers] Please comment on ios-universal topic

On 10-Dec-15 13:55, Gregor Jasny wrote: Hello, On 09/12/15 10:21, Ruslan Baratov wrote: IOS_INSTALL_COMBINED_BINARY Just to clarify you want to leave only one variable IOS_INSTALL_COMBINED_BINARY for the device + simulator on iOS platforms. Other platforms (in future) will be controlled by

Re: [cmake-developers] [PATCH] Support multiple directories by "cmake -E make_directory" command

On 12/09/2015 03:01 PM, Bartosz Kosiorek wrote: > support for multiple directories for make_directory command. Thanks. Applied with minor documentation tweak: cmake: Teach -E make_directory to support multiple input directories https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7984ac5e

Re: [cmake-developers] [CMake][PATCH] AIX RPATH handling

On 12/10/2015 04:03 AM, CHEVRIER, Marc wrote: > I identify the root of the problem: if I specify version 3.4 in > cmake_minimum_required, generated link command (stored in file link.txt) > for an executable does not contains value specified in variable > CMAKE_SHARED_LIBRARY_LINK_${lang}_FLAGS.

Re: [cmake-developers] [CMake][PATCH] AIX RPATH handling

Ok. I see the problem. Thanks for your investigation. I will work on that and submit a patch to solve this problem. Marc On 10/12/15 14:42, "Brad King" wrote: >On 12/10/2015 04:03 AM, CHEVRIER, Marc wrote: >> I identify the root of the problem: if I specify version

Re: [cmake-developers] set(CACHE) and the local scope

On 12/09/2015 05:35 PM, Ben Boeckel wrote: > So some behavior I was unaware of until today came up: > > set(var ON) > option(var "description" OFF) > message("var: ${var}") > > outputs "OFF" for the first configure and "ON" for subsequent > configures. This is because set(var CACHE)

[cmake-developers] [PATCH] Add Clang support to FindOpenMP

Hi, Attached is a patch to add the correct option for building OpenMP code using Clang. Per the llvm release notes it is necessary to give -fopenmp=libomp to build properly, not just -fopenmp. Tested on 64-bit Linux using

[cmake-developers] [CMake 0015877]: Performance regression in file generation

The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=15877 == Reported By:Jim King Assigned To:

[cmake-developers] [Apple/iOS/OS X] Create subdirectories in Resource directory for Frameworks and Application bundle.

Hello. With CMake 3.5 it is possible to put Resources into the Bundle (Frameworks and Applications) More information: https://cmake.org/gitweb?p=cmake.git;a=blob;f=Help/prop_tgt/RESOURCE.rst So with code: add_executable(ExecutableTarget addDemo.c resourcefile.txt

Re: [cmake-developers] set(CACHE) and the local scope

On Thu, Dec 10, 2015 at 08:50:10 -0500, Brad King wrote: > That is a long-standing subtlety introduced without discussion, review, > or tests here: > > BUG: change in how set cache overrides local definitions. Should mainly be a > NOP change for most cases >