Re: [cmake-developers] Patch to only consider build dependencies between files in the source directory

Hi Brad, Attached is a new attempt. It seems to work correctly in my tests with the Makefile generator. (Which, to be fair, is the only generator that we use in production mode at the moment...) Cheers, Attila 0001-CMAKE_DEPENDS_IN_PROJECT_ONLY-feature-addition.patch Description:

[cmake-developers] [CMake 0016025]: Add support WINDOWS_EXPORT_ALL_SYMBOLS for executable exports lib

The following issue has been SUBMITTED. == https://cmake.org/Bug/view.php?id=16025 == Reported By:Yury Zhuravlev Assigned To:

Re: [cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

Awesome, thanks! I'll check monday and report, but this looks like it'll work the same as the patch I sent last, which I've been using the past few days. Looking forward to have this feature in CMake ! Le ven. 18 mars 2016 à 16:03, Brad King a écrit : > On 03/17/2016

Re: [cmake-developers] Patch to only consider build dependencies between files in the source directory

On 03/17/2016 09:54 AM, Attila Krasznahorkay wrote: > Attached is a new attempt. It seems to work correctly in my tests > with the Makefile generator. Thanks. > + // If it's an absolute path, check if it starts with the source > + // direcotory: > + return ( ( path.find( SourceDir

[cmake-developers] Contribution for Issue #0015146

Hi, I like to contribute code for issue #0015146. I had issues to get the /MANIFESTUAC flag (Microsoft C/C++ Compiler) working in CMake. I saw that it is a known bug which is not resolved yet since 2014. So I tried my best to solve the issue. What I did: I introduced a new flag in

Re: [cmake-developers] Startup Project Configuration [mantis 15578]

Here's Davy's patch rebased against current master with a unit test added. Tested on Visual Studio 2013 only. Let me know if I screwed up the rebase. Some conflicts weren't totally obvious to me how to handle. Thanks, Taylor On Thu, Jun 18, 2015 at 9:10 AM, Brad King

[cmake-developers] [CMake 0016021]: Cannot build on OS X with GCC

The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=16021 == Reported By:Erik Schnetter Assigned To:

Re: [cmake-developers] CMake aliasing system

I've openned new issue for further discussion: * https://github.com/ruslo/CMake/issues/3 On 18-Mar-16 06:24, Tamás Kenéz wrote: Ruslo, I think we all could argue both against and for implementing cmake-ini files inside the cmake command. I mean I'm also aware of all the pros and cons. It's

[cmake-developers] Fwd: [CMake 0016022]: GenerateExportHeader DEFINE_NO_DEPRECATED define conflicts

Hi, regarding this issue report, I’ve just attached a patch for the current HEAD of the master branch that fixes the issue. Please have a look and it would be great if somebody could apply it. It currently causes problems in particular

Re: [cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

On 03/16/2016 04:59 AM, Charles Huet wrote: > Sure, done. > > If you have other ideas on how to improve this patch, I'll be happy to > implement them. Great. Did you mean to attach a revised patch? Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the

Re: [cmake-developers] CMake aliasing system

Ruslo, I think we all could argue both against and for implementing cmake-ini files inside the cmake command. I mean I'm also aware of all the pros and cons. It's just that we weigh differently. I like loosely connected simpler building blocks and my own cmake-wrapping extension script works fine,

[cmake-developers] [CMake 0016023]: OS X CMake.app (version 3.5) contains empty CFBundleIdentifier, which is malformed

The following issue has been SUBMITTED. == https://public.kitware.com/Bug/view.php?id=16023 == Reported By:Sean McBride Assigned To:

Re: [cmake-developers] more use of cmXMLWriter

Hi all! Hi Daniel! Thank you for the work done. I'm the developer CPack IFW generator. I heard about cmXMLWriter and planned to use it, but I couldn't find the time to do it. I looked 0007-CPack-IFW-port-to-cmXMLWriter.patch and at first glance everything should work as before, but I haven't

Re: [cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

Yes, sorry about that. Le mer. 16 mars 2016 à 15:46, Brad King a écrit : > On 03/16/2016 04:59 AM, Charles Huet wrote: > > Sure, done. > > > > If you have other ideas on how to improve this patch, I'll be happy to > > implement them. > > Great. Did you mean to attach a

Re: [cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

On 03/16/2016 12:13 PM, Charles Huet wrote: >> On 03/16/2016 04:59 AM, Charles Huet wrote: >>> If you have other ideas on how to improve this patch, I'll be happy to >>> implement them. All paths that are given to WritePhonyBuild in the outputs and depends options should be sent through

Re: [cmake-developers] Ninja and add_subdirectory EXCLUDE_FROM_ALL

ConvertToNinjaPath sadly makes the path relative to the binary dir, not the source dir. I added a utility function 'ConvertToNinjaFolderRule' that does the same thing as ConvertToNinjaPath, but makes relative to the source dir, and adds the '/all' suffix. I also made the lines less than 79