Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

2018-12-09 Thread Craig Scott
>From what I understand from a very limited quick search just now, it seems that /W3 is the default warning level for Visual Studio (according to the Microsoft docs ), but CMake explicitly adds it

Re: [cmake-developers] [CMake] dependencies of cross compiliations

2018-12-09 Thread Craig Scott
On Tue, Dec 4, 2018 at 6:56 PM Torsten Robitzki wrote: > > Am 27.11.2018 um 19:55 schrieb Eric Noulard : > > > > However from my point of view and my cross-compiling experience when you > cross-compile you have: > > > > 1) the host compiler which is used to compile "host tools" > > 2) the target

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

2018-12-09 Thread Mateusz Loskot
On Sun, 9 Dec 2018 at 12:14, Craig Scott wrote: > > From what I understand from a very limited quick search just now, > it seems that /W3 is the default warning level for Visual Studio Yes, it is the default level indeed. > but CMake explicitly adds it as a default compiler flag in >

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

2018-12-09 Thread Mateusz Loskot
On Sun, 9 Dec 2018 at 14:09, Marc CHEVRIER wrote: > > I think the discussion is shifting from the initial problem which was > unwanted warning « Command line warning D9025: overriding '/W3' with '/W4' ». I disagree with your opinion. Fixing just the warning would be a symptomatic treatment. >

Re: [cmake-developers] [CMake] [MSVC] Setting warning level on target feels like long-time bug

2018-12-09 Thread Ray Donnelly
Cmake is already full of do much hardcoded logic / flags and does new releases so frequently (maybe there's some correlation between these two) that adding this would hardly impact upon its quality or maintainability. So to that end, hardcoding the default per msvc version so that it's not added