[cmake-developers] [CMake 0011866]: InstallRequiredSystemLibraries Watcom Support Patch

2011-02-15 Thread Mantis Bug Tracker

The following issue has been SUBMITTED. 
== 
http://public.kitware.com/Bug/view.php?id=11866 
== 
Reported By:d3x0r
Assigned To:
== 
Project:CMake
Issue ID:   11866
Category:   CMake
Reproducibility:always
Severity:   minor
Priority:   normal
Status: new
== 
Date Submitted: 2011-02-15 18:23 EST
Last Modified:  2011-02-15 18:23 EST
== 
Summary:InstallRequiredSystemLibraries Watcom Support Patch
Description: 
Attached diff from git vs today's head 6720f97d3b07f89af283024d29fad2194edd06f7 
(I think)




Steps to Reproduce: 
use Include(installRequiredSystemLibraries) and use target generator "watcom
wmake"
== 

Issue History 
Date ModifiedUsername   FieldChange   
== 
2011-02-15 18:23 d3x0r  New Issue
2011-02-15 18:23 d3x0r  File Added: watcom-cmake.patch  
 
==

___
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] XCode recursive folders support

2011-02-15 Thread Johan Björk
Thanks & done.

/Johan


On Tue, Feb 15, 2011 at 3:00 PM, Brad King  wrote:

> On 02/15/2011 08:39 AM, Johan Björk wrote:
> > Hi everyone,
> >
> > I created a patch which adds support for multiple folders in Xcode;
> >  http://www.vtk.org/Bug/view.php?id=10039
> >
> > I wasn't able to find a good place for common string helpers or similar,
> > in cmSourceGroupCommand.cxx, there is an inline copy of a tokenize()
> > function which I bluntly copied to cmGlobalXCodeGenerator.cxx in my
> > patch, but that's really ugly :(.
> >
> > Where should code like that go? In KWSys?
>
> Please factor it out into cmSystemTools.(h|cxx).
>
> Thanks,
> -Brad
>
___
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


Re: [cmake-developers] XCode recursive folders support

2011-02-15 Thread Brad King
On 02/15/2011 08:39 AM, Johan Björk wrote:
> Hi everyone,
> 
> I created a patch which adds support for multiple folders in Xcode;
>  http://www.vtk.org/Bug/view.php?id=10039
> 
> I wasn't able to find a good place for common string helpers or similar,
> in cmSourceGroupCommand.cxx, there is an inline copy of a tokenize()
> function which I bluntly copied to cmGlobalXCodeGenerator.cxx in my
> patch, but that's really ugly :(.
> 
> Where should code like that go? In KWSys?

Please factor it out into cmSystemTools.(h|cxx).

Thanks,
-Brad
___
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers


[cmake-developers] XCode recursive folders support

2011-02-15 Thread Johan Björk
Hi everyone,

I created a patch which adds support for multiple folders in Xcode;
http://www.vtk.org/Bug/view.php?id=10039

I wasn't able to find a good place for common string helpers or similar,
in cmSourceGroupCommand.cxx, there is an inline copy of a tokenize()
function which I bluntly copied to cmGlobalXCodeGenerator.cxx in my patch,
but that's really ugly :(.

Where should code like that go? In KWSys?

Cheers
/Johan
___
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers