Re: [cmake-developers] Some documentation patches

2011-10-13 Thread Rolf Eike Beer
Brad King wrote: - Some of the patches remove trailing whitespace from lines unrelated to the real change. Please identify the set of files from which you've blanket-removed whitespace, create a commit that does just that, and then rebase the rest of the patches on it. That will

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Stephen Kelly
Stephen Kelly wrote: The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. This is even more interesting now. http://www.cdash.org/CDash/testDetails.php?test=118872016build=1620094 On gentoo, the build of

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Rolf Eike Beer
Stephen Kelly wrote: The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. This is even more interesting now. http://www.cdash.org/CDash/testDetails.php?test=118872016build=1620094 On gentoo, the build of

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Rolf Eike Beer
Stephen Kelly wrote: The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. This is even more interesting now. http://www.cdash.org/CDash/testDetails.php?test=118872016build=1620094 On gentoo, the build of

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Rolf Eike Beer
Stephen Kelly wrote: The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. This is even more interesting now. http://www.cdash.org/CDash/testDetails.php?test=118872016build=1620094 On gentoo, the build of

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Stephen Kelly
Rolf Eike Beer wrote: Stephen Kelly wrote: The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. This is even more interesting now. http://www.cdash.org/CDash/testDetails.php?test=118872016build=1620094

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Rolf Eike Beer
Rolf Eike Beer wrote: Stephen Kelly wrote: The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. This is even more interesting now. http://www.cdash.org/CDash/testDetails.php?test=118872016build=1620094

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Rolf Eike Beer
Rolf Eike Beer wrote: I'm not certain that's correct though. Those flags don't seem to be used when I build. I also don't know what those flags do. Linking CXX executable exec /home/stephen/dev/qt48/kde/bin/cmake -E cmake_link_script CMakeFiles/exec.dir/link.txt --verbose=1

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Stephen Kelly
On Thu, Oct 13, 2011 at 4:33 PM, Richard Wackerbarth rich...@nfsnet.org wrote: Steve, Here is the output from the version of test19 that you sent privately. The version of cmake was built with last night's dashboard. I don't see the failure here. Am I doing something wrong? Hi, it doesn't

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread David Cole
On Thu, Oct 13, 2011 at 12:01 PM, Stephen Kelly steve...@gmail.com wrote: On Thu, Oct 13, 2011 at 4:33 PM, Richard Wackerbarth rich...@nfsnet.org wrote: Steve, Here is the output from the version of test19 that you sent privately. The version of cmake was built with last night's dashboard.

Re: [cmake-developers] Some documentation patches

2011-10-13 Thread Nicolas Desprès
On Thu, Oct 13, 2011 at 8:30 AM, Rolf Eike Beer e...@sf-mail.de wrote: Brad King wrote: - Some of the patches remove trailing whitespace from lines unrelated to    the real change.  Please identify the set of files from which you've    blanket-removed whitespace, create a commit that does

Re: [cmake-developers] Some documentation patches

2011-10-13 Thread Nicolas Desprès
2011/10/13 Brad King brad.k...@kitware.com: On 10/12/2011 11:10 AM, Nicolas Desprès wrote: I have extracted some documentation patches I have made while I was working on the ninja-generator and some enhancement for ccmake.  I would like to submit them now. They are addressing: - usage

Re: [cmake-developers] Some documentation patches

2011-10-13 Thread Nicolas Desprès
2011/10/13 Nicolas Desprès nicolas.desp...@gmail.com: 2011/10/13 Brad King brad.k...@kitware.com: On 10/12/2011 11:10 AM, Nicolas Desprès wrote: I have extracted some documentation patches I have made while I was working on the ninja-generator and some enhancement for ccmake.  I would like

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Stephen Kelly
Stephen Kelly wrote: Ok, knowing why it fails on APPLE is good enough for me for now. The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. I was given access to a freebsd box to see why the build

Re: [cmake-developers] Some documentation patches

2011-10-13 Thread Brad King
On 10/13/2011 2:14 PM, Nicolas Desprès wrote: 2011/10/13 Nicolas Desprèsnicolas.desp...@gmail.com: Thanks for the review. I have fix all the remarks. Pushed on my github: https://github.com/polrop/CMake/commits/some-documentation-fixes Thanks. I will fetch it from there when I get a chance

Re: [cmake-developers] Some documentation patches

2011-10-13 Thread Brad King
On 10/13/2011 2:14 PM, Nicolas Desprès wrote: 2011/10/13 Nicolas Desprèsnicolas.desp...@gmail.com: Thanks for the review. I have fix all the remarks. Pushed on my github: https://github.com/polrop/CMake/commits/some-documentation-fixes That looks pretty good. I have two more comments: -

Re: [cmake-developers] Apple tests for target_link_libraries failing

2011-10-13 Thread Stephen Kelly
Stephen Kelly wrote: Ok, knowing why it fails on APPLE is good enough for me for now. The tests can be enabled on APPLE again later, I've flipped the if condition so we can see why it fails on some non-APPLE platforms too. I was given access to a freebsd box to see why the build