[cmake-developers] [CMake 0013591]: Ninja generator fail with multi-line COMMENT in custom command

2012-10-16 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13591 == Reported By:Eric NOULARD Assigned To:

Re: [cmake-developers] Bug introduced in generate-time target checking code

2012-10-16 Thread Stephen Kelly
Stephen Kelly wrote: Stephen Kelly wrote: Stephen Kelly wrote: None of the outputs have a backtrace. Any idea why? Can a backtrace be provided? Reading the code, I'm not seeing which iteration is going past the end. I added some asserts and found that the problem is in iterating over

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread David Cole
I had to do this to get the bootstrap version of CMake to work (and the BootstrapTest to pass): $ git diff diff --git a/Source/CMakeLists.txt b/Source/CMakeLists.txt index 9d46355..8bf6c40 100644 --- a/Source/CMakeLists.txt +++ b/Source/CMakeLists.txt @@ -264,8 +264,6 @@ set(SRCS cmTarget.cxx

Re: [cmake-developers] Bug introduced in generate-time target checking code

2012-10-16 Thread Brad King
On 10/16/2012 08:43 AM, Stephen Kelly wrote: Still, some of the platforms fail the test, and don't give any information about why: http://open.cdash.org/testSummary.php?project=1name=GeneratorExpressiondate=2012-10-16 Can someone please provide more information (backtrace or further

[cmake-developers] [CMake 0013592]: Inefficient Ninja DAG with add_custom_command

2012-10-16 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13592 == Reported By:Frank Miller Assigned To:

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread Nils Gladitz
I certainly wouldn't mind though I'm not sure what that means. Do the changes in next still potentially make it into 2.8.10? Brad mentioned this would be on the TODO list for after 2.8.10. I've tried to run all tests successfully before submitting but I can't tell if any of those were called

[cmake-developers] Best practices questions

2012-10-16 Thread Petr Kmoch
Hi, I tried submitting my first patch recently (Issue 0013587) and I have a few follow-up questions regarding best practices: 1) Looking at the dashboard, I apparently forgot to quote a path somewhere in the test and it failed on spaces. What is the preferred way for me to provide a fix for the

Re: [cmake-developers] Best practices questions

2012-10-16 Thread Brad King
On 10/16/2012 10:36 AM, Petr Kmoch wrote: 1) Looking at the dashboard, I apparently forgot to quote a path somewhere in the test and it failed on spaces. What is the preferred way for me to provide a fix for the tests? A new commit normally continuing history of the patch as I submitted it?

Re: [cmake-developers] EXCLUDE_FROM_DEFAULT_BUILD testing

2012-10-16 Thread Brad King
On 10/16/2012 11:04 AM, Brad King wrote: I tested it locally on VS 6, 7.1, 8, 9, 10, and 11 all with spaces in the path. I need to investigate the failures on the dashboard to identify the problem. Since we're trying to keep the dashboard as clean as possible right now (to more directly test

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread David Cole
On Tue, Oct 16, 2012 at 10:12 AM, Nils Gladitz glad...@sci-vis.de wrote: I certainly wouldn't mind though I'm not sure what that means. Do the changes in next still potentially make it into 2.8.10? Going into 'next' is how stuff gets tested on the dashboards, and then later Brad and I merge

Re: [cmake-developers] patch for cmake that adds a new timestamp command

2012-10-16 Thread Nils Gladitz
Ah that might explain it ... I may have been using nmake on Windows and ninja on linux. Thanks! Nils On 10/16/2012 05:27 PM, David Cole wrote: On Tue, Oct 16, 2012 at 10:12 AM, Nils Gladitz glad...@sci-vis.de wrote: I certainly wouldn't mind though I'm not sure what that means. Do the

[cmake-developers] [CMake 0013593]: CMake mistakenly says what is newer

2012-10-16 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=13593 == Reported By:Vadim Zhukov Assigned To:

Re: [cmake-developers] Best practices questions

2012-10-16 Thread Benjamin Eikel
Hello, Am Dienstag, 16. Oktober 2012 um 16:36:49 schrieb Petr Kmoch: 2) Is there a code style document I could read somewhere? I now understand line width is preferred at 79 columns max. and I believe I've figured out brace indenting; anything else I should follow? for writing CMake code I

Re: [cmake-developers] [CMake] Random behavior of CTEST_USE_LAUNCHERS

2012-10-16 Thread Brad King
On 10/16/2012 03:09 PM, Nils Gladitz wrote: Well what would be awesome is having the launcher extract individual diagnostic messages. Limitations of that kind of log scraping was precisely the reason we created CTEST_USE_LAUNCHERS in the first place. At most CTest should add markup CDash can

Re: [cmake-developers] [CMake] Random behavior of CTEST_USE_LAUNCHERS

2012-10-16 Thread David Cole
Well, the mixing of lines of output from parallel compiles was the main reason log scraping didn't work well. At least with the launchers, we'd be able to scrape from a single output stream associated with a single build step and we wouldn't have the mixing of lines problem anymore. Nils has a

[cmake-developers] Bugs on the roadmap

2012-10-16 Thread David Cole
The following bugs are on the roadmap (still in the 2.8.10 section), even though they are unassigned: http://public.kitware.com/Bug/view.php?id=8170 http://public.kitware.com/Bug/view.php?id=9905 http://public.kitware.com/Bug/view.php?id=11536 http://public.kitware.com/Bug/view.php?id=11785

Re: [cmake-developers] Bugs on the roadmap

2012-10-16 Thread David Cole
Thanks, Eike. Note that I am not asking *who* should be looking at these bugs. I am asking if anyone is *actually* looking at them at all If you are not looking at them, no need for a response. If you are looking at them, please assign them to yourself. If nobody replies or claims these