Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Daniel Pfeifer
2012/11/6 Stephen Kelly steve...@gmail.com Stephen Kelly wrote: lots of amazing stuff So that it is fully aware of all of its [transitive] dependencies (and any includes and compile defintions requirements) and I would use it like this: add_executable(foo_exe ...)

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Stephen Kelly
Brad King wrote: On 11/06/2012 02:07 PM, Stephen Kelly wrote: I don't think we should honor both properties at once. If the new name is set the old names should be ignored (perhaps with a warning if an old name is set too). That could be an option. I think it gets complicated though.

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Stephen Kelly
Daniel Pfeifer wrote: So that it is fully aware of all of its [transitive] dependencies (and any includes and compile defintions requirements) and I would use it like this: add_executable(foo_exe ...) target_link_libraries(foo_exe boost::mpl) Yeah, I like that!! That breaks cycles,

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Brad King
On 11/07/2012 07:33 AM, Stephen Kelly wrote: I think 2.8.11 will have to generate export files that provide both old and new interfaces. This is currently the case in my branch. Good. The generator expression content is created in FooTargets.cmake and the old-style information is still

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Stephen Kelly
Brad King wrote: On 11/07/2012 07:33 AM, Stephen Kelly wrote: The generator expression content is created in FooTargets.cmake and the old-style information is still generated in FooTargets-Config.cmake One reason we split out the FooTargets-Config.cmake files is so that multiple separate

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Stephen Kelly
Stephen Kelly wrote: add_library(foo SHARED IMPORTED) set_property(TARGET foo INTERFACE_LINK_LIBRARIES bar) set_property(TARGET foo LINK_INTERFACE_LIBRARIES_DEBUG bat) I forgot to also populate the LINK_INTERFACE_LIBRARIES in all cases. Eg: set_property(TARGET foo LINK_INTERFACE_LIBRARIES

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Brad King
On 11/07/2012 08:30 AM, Stephen Kelly wrote: I'm a bit confused by this line. In a union, where does the duplication come from? The term union is an unordered set operation. Order matters here. The upstream will generate different properties which contain duplicate information. Lets say

Re: [cmake-developers] Enabling more compiler warnings

2012-11-07 Thread Brad King
On 11/06/2012 08:55 AM, Stephen Kelly wrote: + set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -ansi -Wcast- align -Wchar-subscripts -Wall -W -Wshadow) Adding -ansi here will require several other fixes as revealed by the dashboard last night. Also, your fix commit:

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Stephen Kelly
Brad King wrote: On 11/07/2012 08:30 AM, Stephen Kelly wrote: The upstream will generate different properties which contain duplicate information. Lets say this is generated: I think this example would be easier to understand if you write out: (1) What the upstream CMakeLists.txt file

Re: [cmake-developers] Enabling more compiler warnings

2012-11-07 Thread Stephen Kelly
Brad King wrote: On 11/06/2012 08:55 AM, Stephen Kelly wrote: + set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -ansi -Wcast- align -Wchar-subscripts -Wall -W -Wshadow) Adding -ansi here will require several other fixes as revealed by the dashboard last night. I've removed that

Re: [cmake-developers] Enabling more compiler warnings

2012-11-07 Thread Brad King
On 11/07/2012 09:40 AM, Stephen Kelly wrote: I've removed that one. I'm not sure what it caused specifically. Was it all of these? http://open.cdash.org/viewBuildError.php?buildid=2650259 Yes. Does the cmake regex system have a way to match word boundaries? I need to be able to match

Re: [cmake-developers] Enabling more compiler warnings

2012-11-07 Thread Stephen Kelly
Brad King wrote: On 11/07/2012 09:40 AM, Stephen Kelly wrote: Does the cmake regex system have a way to match word boundaries? I need to be able to match '-W\b' such that '-Wall' is not matched. No, but you can do if(NOT ${CMAKE_C_FLAGS} MATCHES -W ) Note the space on the left

Re: [cmake-developers] Generator expressisons in target properties

2012-11-07 Thread Brad King
On 11/07/2012 09:33 AM, Stephen Kelly wrote: Ok. Thanks for the full example. Additionally, the order of the elements in INTERFACE_LINK_LIBRARIES is the same as the order in IMPORTED_LINK_INTERFACE_LIBRARIES_DEBUG (as added by tll()) **. Okay. If downstream uses 2.8.10, the effect is

Re: [cmake-developers] Enabling more compiler warnings

2012-11-07 Thread Brad King
On 11/07/2012 10:06 AM, Stephen Kelly wrote: Brad King wrote: On 11/07/2012 09:40 AM, Stephen Kelly wrote: Does the cmake regex system have a way to match word boundaries? I need to be able to match '-W\b' such that '-Wall' is not matched. No, but you can do if(NOT ${CMAKE_C_FLAGS}

[cmake-developers] [CMake 0013659]: [PATCH] Patchset git master: several documentation improvements/corrections, typos, bug fixes

2012-11-07 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13659 == Reported By:Andreas Mohr Assigned To:

[cmake-developers] CMake 2.8.10.1 available for download

2012-11-07 Thread David Cole
Oops. :-) There were some problems reported almost immediately with our 2.8.10 release last week. Thanks to the swift work of Brad King, Rolf Eike Beer and Stephen Kelly, those problems have been fixed already, and we've prepared a 2.8.10.1 bug fix release to address those issues right away. The

[cmake-developers] CMake 2.8.10 release webinar scheduled

2012-11-07 Thread David Cole
Hi there. Hopefully you're all busy updating to the new CMake 2.8.10.1 release right now. If you'd like a quick (15-20 minute) overview of the new stuff in the 2.8.10 release, please join us for our scheduled webinar on the topic next week: https://www3.gotomeeting.com/register/872830198 See

[cmake-developers] Bug fix requests for the *next* release of CMake...

2012-11-07 Thread David Cole
Hi all, Replies requested. Short replies only. Read on. Just a short reply with bug numbers or links to the bugs is all we need here. Example one-line reply: http://public.kitware.com/Bug/view.php?id=13571 Please move specific discussions into the bugs themselves or start a new thread to

[cmake-developers] [CMake 0013660]: -- doesn't work as advertised

2012-11-07 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=13660 == Reported By:Dave Abrahams Assigned To: