Re: [cmake-developers] [CMake] 2.8.11-rc3 generator expression error
Stephen Kelly wrote: It can probably be refactored to bypass the genex evaluation though. The refactoring I described can be done in the future I think, but doesn't really solve the bug anyway, because it is evaluation of the generator expression for the target itself which is causing problems here. I've force-pushed the fix-multi-config-tll-include-dirs branch with a more- simple fix for this issue to my clone. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014119]: infinite loop compiler chancged: change error message to delete CMakeFiles folder to try fix this
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14119 == Reported By:Shimon Doodkin Assigned To: == Project:CMake Issue ID: 14119 Category: (No Category) Reproducibility:have not tried Severity: minor Priority: normal Status: new == Date Submitted: 2013-04-29 07:06 EDT Last Modified: 2013-04-29 07:06 EDT == Summary:infinite loop compiler chancged: change error message to delete CMakeFiles folder to try fix this Description: http://www.mail-archive.com/cmake@cmake.org/msg44765.html http://public.kitware.com/Bug/view.php?id=13756 change the error message: You have changed variables that require your cache to be deleted. Configure will be re-run and you may have to reset some variables. The following variables have changed: add to it: Delete CMakeFiles folder to try fix this (not CMakeCache.txt) solution was: After this behavior, you have to manually delete the CMakeFiles directory (not CMakeCache.txt) to recover. == Issue History Date ModifiedUsername FieldChange == 2013-04-29 07:06 Shimon Doodkin New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Code Changes to support C++ Windows Forms
I created a topic called WindowsFormsResx following the developer guide instructions and have committed my staged changes and a test project. I don't know how to send out a link to this, but would be happy to do so if someone pointed me in the right direction. - John On 2013-04-28 20:46, Jean-Christophe Fillion-Robin wrote: Hi John, Seems you forgot to send a link to the associated topic. Jc On Sun, Apr 28, 2013 at 10:20 PM, john.farr...@helleboreconsulting.com wrote: Hello all! New CMake developer here! I have modified the latest version of CMake from Git to be able to use .resx files and integrate them into Visual Studio, perform the correct associations, and enable use of the Visual Studio designer for Windows Forms applications after a solution and projects are configured by CMake. The changes were fairly minimal, but really help me out! I have a project that is mostly cross-platform, but there are a few plugins that are windows-specific. I wanted to use CMake to build and manage the project, but when CMake configured the windows GUI's, I would lose all of the designer information, which is totally unacceptable for ever having to make a change to the GUI. This change is targeted specifically at C++ Windows Forms applications using CLI. I'd like to push these changes up, so feedback is welcome! - John Farrier -- Powered by www.kitware.com [1] Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html [2] Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ [3] Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers [4] -- +1 919 869 8849 Links: -- [1] http://www.kitware.com [2] http://www.kitware.com/opensource/opensource.html [3] http://www.cmake.org/Wiki/CMake_FAQ [4] http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] [CMake] 2.8.11-rc3 generator expression error
On 04/29/2013 06:29 AM, Stephen Kelly wrote: I've force-pushed the fix-multi-config-tll-include-dirs branch with a more- simple fix for this issue to my clone. Okay, that looks good. Please rebase on the partial fix I merged last week so we can test it in 'next'. I'll squash all that together later. Also I realized my local topic using GetLinkInformation is wrong because it includes usage requirements from everything linked, not just from the link *interface* closure. I'll drop that one in favor of yours. While working through all of the above I realized that AppendTllIncludes and LinkInterfaceIncludeDirectoriesEntries are not safe. Users can re-write the LINK_LIBRARIES property and those other structures will not be updated. IIUC they only exist to provide a backtrace for include directory entries. Please drop them for now at the expense of the backtraces which can be restored later by tracking the backtraces of all tll() link information (similar to tid() now). Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Code Changes to support C++ Windows Forms
Hi John, Seems your topic isn't available on the CMake stage: http://cmake.org/gitweb?p=stage/cmake.git I would suggest you push your topic on github instead. The stage is used by module maintainer or CMake core developers [1] Hth Jc [1] http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer On Mon, Apr 29, 2013 at 8:36 AM, john.farr...@helleboreconsulting.comwrote: I created a topic called WindowsFormsResx following the developer guide instructions and have committed my staged changes and a test project. I don't know how to send out a link to this, but would be happy to do so if someone pointed me in the right direction. - John On 2013-04-28 20:46, Jean-Christophe Fillion-Robin wrote: Hi John, Seems you forgot to send a link to the associated topic. Jc On Sun, Apr 28, 2013 at 10:20 PM, john.farrier@**helleboreconsulting.comjohn.farr...@helleboreconsulting.com wrote: Hello all! New CMake developer here! I have modified the latest version of CMake from Git to be able to use .resx files and integrate them into Visual Studio, perform the correct associations, and enable use of the Visual Studio designer for Windows Forms applications after a solution and projects are configured by CMake. The changes were fairly minimal, but really help me out! I have a project that is mostly cross-platform, but there are a few plugins that are windows-specific. I wanted to use CMake to build and manage the project, but when CMake configured the windows GUI's, I would lose all of the designer information, which is totally unacceptable for ever having to make a change to the GUI. This change is targeted specifically at C++ Windows Forms applications using CLI. I'd like to push these changes up, so feedback is welcome! - John Farrier -- Powered by www.kitware.com [1] Visit other Kitware open-source projects at http://www.kitware.com/** opensource/opensource.htmlhttp://www.kitware.com/opensource/opensource.html[2] Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/**CMake_FAQhttp://www.cmake.org/Wiki/CMake_FAQ[3] Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-**bin/mailman/listinfo/cmake-**developershttp://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers[4] -- +1 919 869 8849 Links: -- [1] http://www.kitware.com [2] http://www.kitware.com/**opensource/opensource.htmlhttp://www.kitware.com/opensource/opensource.html [3] http://www.cmake.org/Wiki/**CMake_FAQhttp://www.cmake.org/Wiki/CMake_FAQ [4] http://public.kitware.com/cgi-**bin/mailman/listinfo/cmake-** developershttp://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- +1 919 869 8849 -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Code Changes to support C++ Windows Forms
Done and Pull Request sent. Visual Studio C++ Windows Forms Designer Support Thanks. I look forward to helping this get into the CMake baseline! - John On 2013-04-29 08:08, Jean-Christophe Fillion-Robin wrote: Hi John, Seems your topic isn't available on the CMake stage: http://cmake.org/gitweb?p=stage/cmake.git [6] I would suggest you push your topic on github instead. The stage is used by module maintainer or CMake core developers [1] Hth Jc [1] http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer [7] On Mon, Apr 29, 2013 at 8:36 AM, john.farr...@helleboreconsulting.com wrote: I created a topic called WindowsFormsResx following the developer guide instructions and have committed my staged changes and a test project. I don't know how to send out a link to this, but would be happy to do so if someone pointed me in the right direction. - John On 2013-04-28 20:46, Jean-Christophe Fillion-Robin wrote: Hi John, Seems you forgot to send a link to the associated topic. Jc On Sun, Apr 28, 2013 at 10:20 PM, john.farr...@helleboreconsulting.com wrote: Hello all! New CMake developer here! I have modified the latest version of CMake from Git to be able to use .resx files and integrate them into Visual Studio, perform the correct associations, and enable use of the Visual Studio designer for Windows Forms applications after a solution and projects are configured by CMake. The changes were fairly minimal, but really help me out! I have a project that is mostly cross-platform, but there are a few plugins that are windows-specific. I wanted to use CMake to build and manage the project, but when CMake configured the windows GUI's, I would lose all of the designer information, which is totally unacceptable for ever having to make a change to the GUI. This change is targeted specifically at C++ Windows Forms applications using CLI. I'd like to push these changes up, so feedback is welcome! - John Farrier -- Powered by www.kitware.com [1] [1] Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html [2] [2] Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ [3] [3] Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers [4] [4] -- +1 919 869 8849 [5] Links: -- [1] http://www.kitware.com [1] [2] http://www.kitware.com/opensource/opensource.html [2] [3] http://www.cmake.org/Wiki/CMake_FAQ [3] [4] http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers [4] -- +1 919 869 8849 Links: -- [1] http://www.kitware.com [2] http://www.kitware.com/opensource/opensource.html [3] http://www.cmake.org/Wiki/CMake_FAQ [4] http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers [5] tel:%2B1%20919%20869%208849 [6] http://cmake.org/gitweb?p=stage/cmake.git [7] http://www.cmake.org/Wiki/CMake:Module_Maintainers#New_Maintainer -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please review CXXFeatures.cmake
On Sunday 28 April 2013, Rolf Eike Beer wrote:
One question I see increasingly often is how do I test for C++11 support
or for specific parts of that. For 2.8.12 I plan to include the check
module I wrote for that a while back, and that I have reworked in the last
weeks. You can find the current state in the rework branch of this
repository:
git://anongit.kde.org/scratch/dakon/cmake-cxx11
Line 75: if (CROSS_COMPILING)
Do you mean if(CMAKE_CROSSCOMPILING) ?
Is the try_run() in all cases necessary ?
It would be better if a try_compile() would suffice, that's faster and then it
works the same way when cross-compiling and when not.
Line 139:
if (NOT CXXFEATURES_FIND_COMPONENTS)
set(CXXFEATURES_FIND_COMPONENTS ${_CXX_ALL_FEATURES})
endif ()
foreach (_cxx_feature IN LISTS _CXX_ALL_FEATURES)
cxx_check_feature(${_cxx_feature} ${FEATURE_NAME})
endforeach (_cxx_feature)
Is this how it is supposed to be or should the foreach() loop run over
CXXFEATURES_FIND_COMPONENTS ?
I didn't try, but it seems it can fail if I give an unknown component. Is
there a check that only known components (CXX features) are requested ?
Alex
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] RFC: pretty/HTML output in test logs in ctest/cdash
On Thursday 18 April 2013, Alexander Neundorf wrote: Hi, attached are two patches for ctest and cdash from Volkan (on CC). They are not ready for inclusion, but before we continue to work in this, we'd like to get some comments whether this is a good idea, the right approach, etc. So, here we go. We are using cdash a lot, and for many of our tests the log is quite verbose and somewhat hard to read. When looking for the reason why a test failed, it can be somewhat hard to find the line which contains ERROR. Also, a lot of stuff is repeated every line, which also makes the log harder to read, e.g. the directory part of the file where the log came from: timestamp /some/where/deep/in/a/subdir/test.py: Something... timestamp /some/where/deep/in/a/subdir/test.py: happend... timestamp /some/where/deep/in/a/subdir/test.py: here... timestamp /some/where/deep/in/a/subdir/test.py: ... The directory part is actually so wide that we have to scroll to see actual text. So, to help with this, we came up with the idea to use HTML to format the log so that it becomes easier to read. The attached patch for ctest adds a new test property GENERATE_HTML, and if this is enabled, ctest generates HTML. It searches the lines which made the test fail and colors them red, and the lines which make a test pass are colored green. This makes it easier to find the fail/succeed lines. (In the patch the fail strings are still hardcoded, this would have to use the respective test property.) On the cdash side, if /span is found in the log, it is considered HTML and not escaped. I guess this should be done in a different way, which does not involve parsing the log text. Comments so far ? For making our log lines shorter, we are not sure yet how to do that. We could add support for squish XML to ctest, so that ctest reads the squish XML and converts it to HTML which is in some way shorter, maybe a HTML table, or something. Or we could add a test property with a regular expression, if that regexp matches, ctest replaces it with a shorter version or something. Or we could modify our test scripts so that they already generate the pretty HTML, which ctest then simply sends to cdash. That's the ideas we have so far, but it doesn't feel quite right yet. So, what do you think ? Any comments ? Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] ADDITIONAL_MAKE_CLEAN_FILES only works in Makefile generators / automoc cleaning problem
Hi, in automoc, for every target foo a foo_automoc target is created, and for each of those a file foo_automoc.cpp is created. When this file does not exist, automoc reruns and all moc files should be regenerated. To achieve this, I added this file in cmQtAutomoc.cxx to the ADDITIONAL_MAKE_CLEAN_FILES property, so it is removed on make clean. Now after some emails on the cmake list, it seems ADDITIONAL_MAKE_CLEAN_FILES is used only by the Makefile-generators, but not by e.g. the VS generators ? The target is created using cmMakefile::AddUtilityCommand(). What would be the recommended way to add a generated file, so that it is removed when cleaning ? Do I need to create a cmSourceFile and set it to GENERATED ? Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ADDITIONAL_MAKE_CLEAN_FILES only works in Makefile generators / automoc cleaning problem
On 04/29/2013 03:05 PM, Alexander Neundorf wrote: Now after some emails on the cmake list, it seems ADDITIONAL_MAKE_CLEAN_FILES is used only by the Makefile-generators, but not by e.g. the VS generators ? VS does its own cleaning of the build outputs it knows. The target is created using cmMakefile::AddUtilityCommand(). What would be the recommended way to add a generated file, so that it is removed when cleaning ? Do I need to create a cmSourceFile and set it to GENERATED ? VS needs to know that the file is the output of a custom command. In order for CMake to tell VS about this, the file needs to be listed as an OUTPUT in add_custom_command. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please review CXXFeatures.cmake
Alexander Neundorf wrote: On Sunday 28 April 2013, Rolf Eike Beer wrote: One question I see increasingly often is how do I test for C++11 support or for specific parts of that. For 2.8.12 I plan to include the check module I wrote for that a while back, and that I have reworked in the last weeks. You can find the current state in the rework branch of this repository: git://anongit.kde.org/scratch/dakon/cmake-cxx11 Is the try_run() in all cases necessary ? It would be better if a try_compile() would suffice, that's faster and then it works the same way when cross-compiling and when not. I'm not sure about this, but the other ones I consider real bugs. Thanks for catching them, will fix soon. Eike -- signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please review CXXFeatures.cmake
On Monday 29 April 2013, Rolf Eike Beer wrote: Alexander Neundorf wrote: On Sunday 28 April 2013, Rolf Eike Beer wrote: One question I see increasingly often is how do I test for C++11 support or for specific parts of that. For 2.8.12 I plan to include the check module I wrote for that a while back, and that I have reworked in the last weeks. You can find the current state in the rework branch of this repository: git://anongit.kde.org/scratch/dakon/cmake-cxx11 Is the try_run() in all cases necessary ? It would be better if a try_compile() would suffice, that's faster and then it works the same way when cross-compiling and when not. I'm not sure about this, but the other ones I consider real bugs. Thanks for catching them, will fix soon. Or IOW: if possible at all, try really hard to get away with only try_compile(), i.e. avoid try_run(). Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014121]: Custom command errors are hidden when CTest launchers are used with Ninja
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14121 == Reported By:Nils Gladitz Assigned To: == Project:CMake Issue ID: 14121 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-04-29 16:51 EDT Last Modified: 2013-04-29 16:51 EDT == Summary:Custom command errors are hidden when CTest launchers are used with Ninja Description: I couldn't get any build errors from custom commands on my CDash dashboard when using Ninja with CTest launchers. Neither are there errors from custom commands with failure exit status nor from those with output matched by CTEST_CUSTOM_ERROR_MATCH. Steps to Reproduce: I've set up a test project for which I tested make and ninja with and without launchers. CTEST_CUSTOM_ERROR_MATCH is set to FooBar. The project contains three custom commands with the following outputs and exit codes: CustomCommand1: this is a FooBar message (exit success) CustomCommand2: this is a fatal error (exit failure) CustomCommand3: this is a FooBar fatal error (exit failure) These are the results that I got (numbers in braces indicate which custom commands produce output visible on CDash): Ninja (Launchers enabled): 0 Build Errors Ninja (Launchers disabled): 4 Build Errors (1, 2, 3) Unix Makefiles (Launchers enabled): 2 Build Errors (2, 3) Unix Makefiles (Launchers disabled): 4 Build Errors (1, 2, 3) CTEST_CUSTOM_ERROR_MATCH seems to only work with launchers disabled with Makefiles as well so I assume this is by design (though unexpected). At the very least the exit status in the Ninja + Launchers case should be evaluated as it is with Makefiles. == Issue History Date ModifiedUsername FieldChange == 2013-04-29 16:51 Nils Gladitz New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] ADDITIONAL_MAKE_CLEAN_FILES only works in Makefile generators / automoc cleaning problem
On Monday 29 April 2013, Brad King wrote: On 04/29/2013 03:05 PM, Alexander Neundorf wrote: Now after some emails on the cmake list, it seems ADDITIONAL_MAKE_CLEAN_FILES is used only by the Makefile-generators, but not by e.g. the VS generators ? VS does its own cleaning of the build outputs it knows. The target is created using cmMakefile::AddUtilityCommand(). What would be the recommended way to add a generated file, so that it is removed when cleaning ? Do I need to create a cmSourceFile and set it to GENERATED ? VS needs to know that the file is the output of a custom command. In order for CMake to tell VS about this, the file needs to be listed as an OUTPUT in add_custom_command. This is now in the AutomocFixCleaningHandling branch. It would be nice if you could have a look at it. Thanks Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
