The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14306
==
Reported By:ycollet
Assigned To:
On Tue, Jul 23, 2013 at 5:59 PM, Stephen Kelly steve...@gmail.com wrote:
Nicolas Desprès wrote:
Hi Stephen,
Did you have any chance to look at the code? I would love to see it
integrated in the next release. That being said, there is no pressure.
I'll have a look now.
Thanks!
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14307
==
Reported By:ycollet
Assigned To:
Nicolas Desprès wrote:
+UpdateOutputToSourceMap(outputs, file);
is missing a 'this-', as per the style. There's a couple of repeats of
that.
Done
You seem to have missed this one.
There are also other style issues.
* Don't put an else after a return
* Wrap single line blocks in {}
On Wed, Jul 24, 2013 at 11:29 AM, Stephen Kelly steve...@gmail.com wrote:
Nicolas Desprès wrote:
+UpdateOutputToSourceMap(outputs, file);
is missing a 'this-', as per the style. There's a couple of repeats of
that.
Done
You seem to have missed this one.
There are also other
Nicolas Desprès wrote:
That's said we can optimize further as I mentioned in my comment (
https://github.com/nicolasdespres/CMake/commit/59c871da8b00554812e93ba9c6e47d864424efb0#L0R2023
).
Do you have an opinion about it?
Do I understand correctly that the issue is that OutputToSource
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14308
==
Reported By:ycollet
Assigned To:
On 07/22/2013 04:18 PM, Rolf Eike Beer wrote:
Since d0170584c54b515b7eb2d044c3d48332523b3a37 there is a comment stating
that
spaces, quotes, or other characters special in CMake syntax are not allowed
in a test name. This raised 2 topics:
This was just documenting an existing limitation.
Ben,
Please revise this topic to add a test using the Tests/RunCMake
infrastructure to diagnose the error case instead.
Thanks,
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and
On 07/15/2013 02:00 PM, Stephen Kelly wrote:
Brad King wrote:
On 7/15/2013 11:25 AM, Stephen Kelly wrote:
The solution I think is to add the specified include directories to the
cmTargetExport instance which gets created when using the EXPORT, and to
append the directories only when
ping.
In sum this cmake -E tar issue for *.tar.xz files needs confirmation
for MSYS on the Microsoft version of Windows. I am pretty sure this
is a simple issue since under MSYS handling of *.tar.xz files is
straightforward from the command line, and my understanding is that
libarchive drops
In sum this cmake -E tar issue for *.tar.xz files needs confirmation
for MSYS on the Microsoft version of Windows. I am pretty sure this
is a simple issue since under MSYS handling of *.tar.xz files is
straightforward from the command line, and my understanding is that
libarchive drops back
On 07/21/2013 04:19 PM, Alan W. Irwin wrote:
So on MSYS platforms the command-line tools
are working fine for manipulating xz-compressed tarballs, but
cmake -E tar xfz test.tar.xz
fails (and also appears to be using the unxz command-line tool
that is not correctly finding the
On Wed, Jul 24, 2013 at 12:18 PM, Stephen Kelly steve...@gmail.com wrote:
Nicolas Desprès wrote:
That's said we can optimize further as I mentioned in my comment (
https://github.com/nicolasdespres/CMake/commit/59c871da8b00554812e93ba9c6e47d864424efb0#L0R2023
).
Do you have an
On 2013-07-24 16:09- David Cole wrote:
In sum this cmake -E tar issue for *.tar.xz files needs confirmation
for MSYS on the Microsoft version of Windows. I am pretty sure this
is a simple issue since under MSYS handling of *.tar.xz files is
straightforward from the command line, and my
On 2013-07-24 13:18-0400 Brad King wrote:
On 07/21/2013 04:19 PM, Alan W. Irwin wrote:
So on MSYS platforms the command-line tools
are working fine for manipulating xz-compressed tarballs, but
cmake -E tar xfz test.tar.xz
fails (and also appears to be using the unxz command-line tool
that is
The following issue has been SUBMITTED.
==
http://www.cmake.org/Bug/view.php?id=14309
==
Reported By:jmcm
Assigned To:
Brad King wrote:
On 07/22/2013 04:18 PM, Rolf Eike Beer wrote:
Since d0170584c54b515b7eb2d044c3d48332523b3a37 there is a comment stating
that spaces, quotes, or other characters special in CMake syntax are
not allowed
in a test name. This raised 2 topics:
This was just documenting an
18 matches
Mail list logo
