Re: [cmake-developers] Alias targets for 2.8.12
Brad King wrote: The topic looks like a great start. I won't promise to take it for 2.8.12 yet but let's proceed with review. - The documentation in add_library and add_executable lists a bunch of things one can't do but not an example of what one can do. I think this documentation should have an explicit list of what is intended and allowed and then exclude everything else. That way if we missed a use case we can treat it as a bug later and add the error case. I'm not sure how to do this one. Do you want an example code snippet of allowed commands? - Should add_executable be (dis)allowed to add a library alias, and vice-versa for add_library? Yes, done. - The documentation does not mention that alias targets cannot be installed or exported. Fixed. - Add more positive use cases (or negative if not allowed) to the test suite: - add_custom_command/add_custom_target COMMAND argv0 translation - add_test NAME/COMMAND signature argv0 translation - generator expression references e.g. $TARGET_FILE:... in add_test and add_custom_* commands - Alias for an object library with $TARGET_OBJECTS:... All done. - Look for other uses of cmMakefile FindTargetToUse and FindTarget; all of them need tests for alias behavior and/or should be preceded by !IsAlias checks (many are already done). Reviewed. I think everything is covered. - How does this interact with $TARGET_PROPERTY:NAME? The name of the aliased target is returned, not the alias name itself. - When if(TARGET xyz) returns true how can one tell from CMake code whether xyz is an alias or a real target? Can one get the real target if it is an alias? I added a ALIASED_TARGET target property for that. An alternative would be if(ALIAS xyz) but I don't think that's really needed. if() is complex enough already. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014332]: cpack = 2.8.2 DEB generator produces invalid .deb when long filenames are involved
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14332 == Reported By:David Keller Assigned To: == Project:CMake Issue ID: 14332 Category: CPack Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-02 06:45 EDT Last Modified: 2013-08-02 06:45 EDT == Summary:cpack = 2.8.2 DEB generator produces invalid .deb when long filenames are involved Description: When project installed files have long filenames (e.g. doxygen generated files), cpack creates a .deb which cannot be installed because it's internal archive seems corrupted. Steps to Reproduce: Install cmake = 2.8.2 $ tar xvzf cpack-bug.tar.gz $ cd cpack-bug $ mkdir build cd build $ cmake .. $ cpack -G DEB $ sudo dpkg -i cpack_bug*.deb (Reading database ... 536878 files and directories currently installed.) Unpacking cpack_bug (from cpack_bug-1.1.0-Linux.deb) ... dpkg: error processing cpack_bug-1.1.0-Linux.deb (--install): corrupted filesystem tarfile - corrupted package archive Errors were encountered while processing: cpack_bug-1.1.0-Linux.deb Additional Information: Tested on Debian-6 Tested on Ubuntu 10.04 LTS == Issue History Date ModifiedUsername FieldChange == 2013-08-02 06:45 David Keller New Issue 2013-08-02 06:45 David Keller File Added: cpack-bug.tar.gz == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Alias targets for 2.8.12
On 08/02/2013 06:04 AM, Stephen Kelly wrote: Brad King wrote: The topic looks like a great start. I won't promise to take it for 2.8.12 yet but let's proceed with review. - The documentation in add_library and add_executable lists a bunch of things one can't do but not an example of what one can do. I think this documentation should have an explicit list of what is intended and allowed and then exclude everything else. That way if we missed a use case we can treat it as a bug later and add the error case. I'm not sure how to do this one. Do you want an example code snippet of allowed commands? No, I think just a prose list of example uses e.g. linking into other targets. Thanks for the other fixes. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Alias targets for 2.8.12
On 08/02/2013 08:00 AM, Brad King wrote: No, I think just a prose list of example uses e.g. linking into other targets. Thanks for the other fixes. FYI, I added this to your topic: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9a0a1945 to fix the AliasTarget test on Watcom. Please squash that into the appropriate commit in the next revision of the topic. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Alias targets for 2.8.12
Brad King wrote: On 08/02/2013 08:00 AM, Brad King wrote: No, I think just a prose list of example uses e.g. linking into other targets. Thanks for the other fixes. FYI, I added this to your topic: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9a0a1945 to fix the AliasTarget test on Watcom. Please squash that into the appropriate commit in the next revision of the topic. Thanks. I've added the extra prose documentation now too. I think all the follow up commits should be squashed into the initial commit. I've only kept them separate until now to simplify review. Will I go ahead and squash it all together now? Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Alias targets for 2.8.12
On 08/02/2013 08:58 AM, Stephen Kelly wrote: Will I go ahead and squash it all together now? Yes, please. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014333]: Unable to add custom pages to NSIS installer packages
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14333 == Reported By:David Golub Assigned To: == Project:CMake Issue ID: 14333 Category: CPack Reproducibility:N/A Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-02 11:12 EDT Last Modified: 2013-08-02 11:12 EDT == Summary:Unable to add custom pages to NSIS installer packages Description: It's currently not possible to add custom pages or initialization commands to CPack-generated NSIS installers. I'm submitting a patch to add a couple of new customization points to make this possible. == Issue History Date ModifiedUsername FieldChange == 2013-08-02 11:12 David GolubNew Issue 2013-08-02 11:12 David GolubFile Added: 0001-CPack-NSIS-Add-support-for-custom-pages-and-initiali.patch == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014334]: Probléme CMake
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14334 == Reported By:gfrbh Assigned To: == Project:CMake Issue ID: 14334 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-02 16:17 EDT Last Modified: 2013-08-02 16:17 EDT == Summary:Probléme CMake Description: Bonjour j'ai un probléme CMake il me marque CMake ne sera pas en mesure de générer correctement ce projet. Pile des appels (appel le plus récent en premier): CMakeLists.txt: 12 (projet) Comment puis-je réglé sa merci. == Issue History Date ModifiedUsername FieldChange == 2013-08-02 16:17 gfrbh New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Please review CXXFeatures.cmake
Am Sonntag, 28. April 2013, 13:57:26 schrieb Rolf Eike Beer: One question I see increasingly often is how do I test for C++11 support or for specific parts of that. For 2.8.12 I plan to include the check module I wrote for that a while back, and that I have reworked in the last weeks. You can find the current state in the rework branch of this repository: Ok, I finally put it into the CMake repository: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8ea3dcd28d290f5eb15ab2caeab1ca925dd8c136 Brad, please don't merge that next week as I first want to get some more expected compiler results squashed into that. And of course sort out why it is failing at the dashboards. Eike signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0014335]: CMake does not error on duplicate else()
The following issue has been SUBMITTED. == http://cmake.org/Bug/view.php?id=14335 == Reported By:Rolf Eike Beer Assigned To: == Project:CMake Issue ID: 14335 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-08-03 00:43 EDT Last Modified: 2013-08-03 00:43 EDT == Summary:CMake does not error on duplicate else() Description: This should definitely give a syntax error as a stray else() also does: if (foo) message(STATUS foo) else () message(STATUS not foo) else () message(STATUS funky) endif () == Issue History Date ModifiedUsername FieldChange == 2013-08-03 00:43 Rolf Eike Beer New Issue == -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Suspicious Clang versions
http://open.cdash.org/testDetails.php?test=201937899build=2986383 (MacOS 10.7) The CXX compiler identification is Clang 4.0.0 I do not believe that. Especially as http://open.cdash.org/testDetails.php?test=201937829build=2986379 (MacOS 10.8) shows 3.4.0. But since even 3.4 does not seem to be released I wonder what's going on there? Eike -- signature.asc Description: This is a digitally signed message part. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
