[cmake-developers] Volunteering to become maintainer of FindSWIG

2013-11-18 Thread Julien Schueller
Hello, I'd like to help maintain the orphaned module FindSWIG [1]. I'll plan on fixing #0013449 [2]. [1] http://www.cmake.org/Wiki/CMake:Module_Maintainers [2] http://public.kitware.com/Bug/view.php?id=13449 Regards, -- Julien Schueller Phimeca Engineering -- Powered by www.kitware.com

[cmake-developers] [CMake 0014577]: ProgramDataBaseFileName tag is missing in VS XXXX vc(x)proj files since 2.8.12.x

2013-11-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14577 == Reported By:Soeren Freudiger Assigned To:

[cmake-developers] [CMake 0014578]: More consistent paths for CPACK_NSIS_CREATE_ICONS_EXTRA and CPACK_NSIS_DELETE_ICONS_EXTRA

2013-11-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14578 == Reported By:Bjoern Thiel Assigned To:

[cmake-developers] [CMake 0014579]: Dependency check mechanism ignores deleted header files

2013-11-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14579 == Reported By:Adrien Bruneton Assigned To:

[cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-11-18 Thread Daniele E. Domenichelli
Hello, Please review the topic ExternalProject_GitUpdate ExternalProject handles git remote branches by commit hash. Due to this, the git repository ends in detached states, and local commits are discarded. This patch uses git pull --rebase for remote branches instead of git checkout. If there

Re: [cmake-developers] Weird behaviour of arguments in macro

2013-11-18 Thread Daniele E. Domenichelli
On 15/11/13 17:41, Brad King wrote: On 11/15/2013 03:27 AM, Daniele E. Domenichelli wrote: So I believe that some more documentation would be helpful... If you agree, I can write it... Fine with me! One reason we changed to the rst-formatted documentation is to make it easier to write and

[cmake-developers] [CMake 0014580]: Individual installation directory prefix pr component

2013-11-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://www.cmake.org/Bug/view.php?id=14580 == Reported By:Lars Assigned To:

Re: [cmake-developers] Invalid/Reserved target names

2013-11-18 Thread Brad King
On 11/15/2013 11:39 AM, Brad King wrote: The policy has not been released yet so I think it would be fine to extend it to cover this. Please include documentation and test cases. Thanks for working on this. Here are some comments. It looks like you added the reserved check to

Re: [cmake-developers] Volunteering to become maintainer of FindSWIG

2013-11-18 Thread Brad King
On 11/18/2013 03:03 AM, Julien Schueller wrote: I'd like to help maintain the orphaned module FindSWIG [1]. I'll plan on fixing #0013449 [2]. [1] http://www.cmake.org/Wiki/CMake:Module_Maintainers [2] http://public.kitware.com/Bug/view.php?id=13449 Great, thanks for volunteering! Please

Re: [cmake-developers] Invalid/Reserved target names

2013-11-18 Thread Nils Gladitz
On 11/15/2013 11:39 AM, Brad King wrote: It looks like you added the reserved check to cmGeneratorExpression in the IsValidTargetName method. This method is used in other places to validate generator expression syntax, and in those places the reserved target names may be allowed. Can I keep the

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-11-18 Thread Jean-Christophe Fillion-Robin
Hi Daniele, This is a great improvement. It is so easy to loose local change to an external project A made while debugging/tweaking it for a better interaction into an other project B with B depending on A. Will give a try and let you know how it goes. Thanks Jc On Mon, Nov 18, 2013 at 6:19

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-11-18 Thread Robert Maynard
I am understanding properly that the last paragraph properly, this will fix the problem that setting GIT_TAG to a named branch doesn't keep the branch up to date with the remotes version of the branch? Overall I really like this change to ExternalProject, and I see it being more in line with how

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-11-18 Thread Matt McCormick
Hi Daniele, Thanks for the contribution! Code review looks good -- I like how there is a reset --hard to the previous head_sha and message if the stash pop does not work as expected. I have checkout out the branch, will test it locally, and make any notes of unexpected behavior. Thanks, Matt

Re: [cmake-developers] Weird behaviour of arguments in macro

2013-11-18 Thread Brad King
On 11/18/2013 08:41 AM, Daniele E. Domenichelli wrote: Done, see topic macro-args-docs. Good start. Please place the :: starting a literal block at the end of the previous paragraph when the block is part of the paragraph. For example: +Therefore you will NOT be able to use commands like: +

Re: [cmake-developers] compile_feature test results

2013-11-18 Thread Brad King
On 11/12/2013 10:10 PM, Stephen Kelly wrote: Brad King wrote: 1. Revert the target_compile_features topic until this is resolved. Done. Rebased to master and pushed to my clone. Okay, thanks. 2. Create a new topic that adds a *test* in which you build the new infrastructure. (This way

[cmake-developers] RST and documentation

2013-11-18 Thread Stephen Kelly
Hi, We've had a while now to get used to the new docs system. Mostly I like it, though I haven't really looked much into what rst offers. 1) Indentation Something that I liked about the previous system was that the output from cmake --help-* was indented. Can we indent the rst output too? 2)

Re: [cmake-developers] cmake --help output indentation (was: RST and documentation)

2013-11-18 Thread Brad King
On 11/18/2013 02:56 PM, Stephen Kelly wrote: We've had a while now to get used to the new docs system. Mostly I like it, though I haven't really looked much into what rst offers. This is really the start of several threads so I will branch out now. 1) Indentation Something that I liked

Re: [cmake-developers] organizing concept documentation (was: RST and documentation)

2013-11-18 Thread Brad King
On 11/18/2013 02:56 PM, Stephen Kelly wrote: We've had a while now to get used to the new docs system. Mostly I like it, though I haven't really looked much into what rst offers. This is really the start of several threads so I will branch out now. 3) Language documentation Note there is

Re: [cmake-developers] cmake --help-custom-modules compatibility (was: RST and documentation)

2013-11-18 Thread Alexander Neundorf
On Monday 18 November 2013, Brad King wrote: On 11/18/2013 02:56 PM, Stephen Kelly wrote: We've had a while now to get used to the new docs system. Mostly I like it, though I haven't really looked much into what rst offers. This is really the start of several threads so I will branch out

[cmake-developers] IEEE SC2013, come up and say hello!

2013-11-18 Thread Robert Maynard
If you are at Denver this week for IEEE Supercomputing (http://www.supercomp.org), please stop by our booth (#4207) and say hello. There will be CMake and software process experts available to discuss best practices and new developments in CMake/CTest/CPack and CDash. We'd like to hear about what

Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate

2013-11-18 Thread Daniele E. Domenichelli
On 18/11/13 16:39, Robert Maynard wrote: I am understanding properly that the last paragraph properly, this will fix the problem that setting GIT_TAG to a named branch doesn't keep the branch up to date with the remotes version of the branch? Yes, exactly... setting GIT_TAG to master (or any

Re: [cmake-developers] Weird behaviour of arguments in macro

2013-11-18 Thread Daniele E. Domenichelli
Hello Brad, On 18/11/13 18:44, Brad King wrote: Please place the :: starting a literal block at the end of the previous paragraph when the block is part of the paragraph. [...] Also please use ``inline-code-example`` syntax for text referring to constructs from the literal blocks. [...]