[cmake-developers] [CMake 0014591]: find_path appears to ignore PATH_SUFFIXES
The following issue has been SUBMITTED.
==
http://public.kitware.com/Bug/view.php?id=14591
==
Reported By:holtgrewe
Assigned To:
==
Project:CMake
Issue ID: 14591
Category: CMake
Reproducibility:always
Severity: major
Priority: normal
Status: new
==
Date Submitted: 2013-11-22 05:00 EST
Last Modified: 2013-11-22 05:00 EST
==
Summary:find_path appears to ignore PATH_SUFFIXES
Description:
I am using the CMakeLists.txt from below and tried it with different CMake
versions. Note that the include/zlib.h file exists.
The problem occured with 2.12.1 (see below).
Steps to Reproduce:
See below.
Additional Information:
C:\Temp\example-buildcmake --version
cmake version 2.8.11.1
C:\Temp\example-buildcmake ..\example -G Visual Studio 11
-- The C compiler identification is MSVC 17.0.60610.1
-- The CXX compiler identification is MSVC 17.0.60610.1
-- Check for working C compiler using: Visual Studio 11
-- Check for working C compiler using: Visual Studio 11 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Visual Studio 11
-- Check for working CXX compiler using: Visual Studio 11 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- RESULT C:/seqan-contrib-D20130710-x86/vs11/include
-- RESULT2 C:/seqan-contrib-D20130710-x86/vs11/include
-- RESULT3 C:/seqan-contrib-D20130710-x86/vs11/include
-- EXISTS C:/seqan-contrib-D20130710-x86/vs11/include/zlib.h
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Temp/example-build
C:\Temp\example-buildcmake --version
cmake version 2.8.11.2
C:\Temp\example-buildcmake ..\example -G Visual Studio 11
-- The C compiler identification is MSVC 17.0.60610.1
-- The CXX compiler identification is MSVC 17.0.60610.1
-- Check for working C compiler using: Visual Studio 11
-- Check for working C compiler using: Visual Studio 11 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Visual Studio 11
-- Check for working CXX compiler using: Visual Studio 11 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- RESULT C:/seqan-contrib-D20130710-x86/vs11/include
-- RESULT2 C:/seqan-contrib-D20130710-x86/vs11/include
-- RESULT3 C:/seqan-contrib-D20130710-x86/vs11/include
-- EXISTS C:/seqan-contrib-D20130710-x86/vs11/include/zlib.h
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Temp/example-build
C:\Temp\example-buildcmake --version
cmake version 2.8.12.1
C:\Temp\example-buildcmake ..\example -G Visual Studio 11
-- The C compiler identification is MSVC 17.0.60610.1
-- The CXX compiler identification is MSVC 17.0.60610.1
-- Check for working C compiler using: Visual Studio 11
-- Check for working C compiler using: Visual Studio 11 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Visual Studio 11
-- Check for working CXX compiler using: Visual Studio 11 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- RESULT RESULT-NOTFOUND
-- RESULT2 RESULT2-NOTFOUND
-- RESULT3 C:/seqan-contrib-D20130710-x86/vs11/include
-- EXISTS C:/seqan-contrib-D20130710-x86/vs11/include/zlib.h
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Temp/example-build
== CMakeLists.txt ==
cmake_minimum_required (VERSION 2.8)
set (CMAKE_MODULE_PATH C:/seqan-trunk/util/cmake ${CMAKE_MODULE_PATH})
set (CMAKE_FIND_ROOT_PATH C:/seqan-contrib-D20130710-x86/vs11)
find_path (RESULT zlib.h PATH_SUFFIXES include)
message (STATUS RESULT ${RESULT})
find_path (RESULT2 zlib.h C:/seqan-contrib-D20130710-x86/vs11 PATH_SUFFIXES
include)
message (STATUS RESULT2 ${RESULT2})
find_path (RESULT3 zlib.h C:/seqan-contrib-D20130710-x86/vs11/include)
message (STATUS RESULT3 ${RESULT3})
if (EXISTS C:/seqan-contrib-D20130710-x86/vs11/include/zlib.h)
message (STATUS EXISTS C:/seqan-contrib-D20130710-x86/vs11/include/zlib.h)
else ()
message (STATUS DOES NOT EXIST
C:/seqan-contrib-D20130710-x86/vs11/include/zlib.h)
endif ()
==
Issue History
Date ModifiedUsername FieldChange
==
2013-11-22 05:00 holtgrewe New Issue
[cmake-developers] [CMake 0014592]: RunCMake.include_directories (SourceDirectoryInInterface BinaryDirectoryInInterface) tests fail.
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=14592 == Reported By:George Sakhnovsky Assigned To: == Project:CMake Issue ID: 14592 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2013-11-22 09:06 EST Last Modified: 2013-11-22 09:06 EST == Summary:RunCMake.include_directories (SourceDirectoryInInterface BinaryDirectoryInInterface) tests fail. Description: after building cmake 2.8.12.1 on CentOS 6.4, make test fails: The following tests FAILED: 256 - RunCMake.include_directories (Failed) possibly related to the recent addition of target_include_directories() ### [sakhngeo@repoman cmake-2.8.12.1]$ bin/ctest -VV -R RunCMake.include_directories UpdateCTestConfiguration from :/usr/local/src/cmake-2.8.12.1/DartConfiguration.tcl Parse Config file:/usr/local/src/cmake-2.8.12.1/DartConfiguration.tcl Add coverage exclude regular expressions. Add coverage exclude: XCode Add coverage exclude: Kdevelop Add coverage exclude: /Source/(cm|kw)sys/ Add coverage exclude: /CMakeFiles/CMakeTmp/ Add coverage exclude: [A-Za-z]./[Qq]t/qt-.+-opensource-src UpdateCTestConfiguration from :/usr/local/src/cmake-2.8.12.1/DartConfiguration.tcl Parse Config file:/usr/local/src/cmake-2.8.12.1/DartConfiguration.tcl Test project /usr/local/src/cmake-2.8.12.1 Constructing a list of tests Guessing configuration NoConfig Done constructing a list of tests Checking test dependency graph... Checking test dependency graph end test 256 Start 256: RunCMake.include_directories 256: Test command: /usr/local/src/cmake-2.8.12.1/bin/cmake -DCMAKE_MODULE_PATH=/usr/local/src/cmake-2.8.12.1/Tests/RunCMake -DRunCMake_GENERATOR=Unix Makefiles -DRunCMake_GENERATOR_TOOLSET= -DRunCMake_SOURCE_DIR=/usr/local/src/cmake-2.8.12.1/Tests/RunCMake/include_directories -DRunCMake_BINARY_DIR=/usr/local/src/cmake-2.8.12.1/Tests/RunCMake/include_directories -P /usr/local/src/cmake-2.8.12.1/Tests/RunCMake/include_directories/RunCMakeTest.cmake 256: Test timeout computed to be: 1500 256: -- NotFoundContent - PASSED 256: -- DebugIncludes - PASSED 256: -- TID-bad-target - PASSED 256: CMake Error at RunCMake.cmake:74 (message): 256: SourceDirectoryInInterface - FAILED: 256: 256: Result is [0], not [1]. 256: 256: stderr does not match that expected. 256: 256: Actual stdout: 256: 256:actual-out -- The C compiler identification is GNU 4.4.7 256:actual-out -- The CXX compiler identification is GNU 4.4.7 256:actual-out -- Check for working C compiler: /usr/bin/cc 256:actual-out -- Check for working C compiler: /usr/bin/cc -- works 256:actual-out -- Detecting C compiler ABI info 256:actual-out -- Detecting C compiler ABI info - done 256:actual-out -- Check for working CXX compiler: /usr/bin/c++ 256:actual-out -- Check for working CXX compiler: /usr/bin/c++ -- works 256:actual-out -- Detecting CXX compiler ABI info 256:actual-out -- Detecting CXX compiler ABI info - done 256:actual-out -- Configuring done 256:actual-out -- Generating done 256:actual-out -- Build files have been written to: /usr/local/src/cmake-2.8.12.1/Tests/RunCMake/include_directories/SourceDirectoryInInterface-build 256: 256: Expected stderr to match: 256: 256:expect-err CMake Error in CMakeLists.txt: 256:expect-err Target testTarget INTERFACE_INCLUDE_DIRECTORIES property contains path: 256:expect-err 256:expect-err .*RunCMake/include_directories/foo 256:expect-err 256:expect-err which is prefixed in the source directory. 256: 256: Actual stderr: 256: 256:actual-err 256: 256: Call Stack (most recent call first): 256: include_directories/RunCMakeTest.cmake:6 (run_cmake) 256: 256: 1/1 Test http://public.kitware.com/Bug/view.php?id=256: RunCMake.include_directories .***Failed1.86 sec 0% tests passed, 1 tests failed out of 1 Total Test time (real) = 2.54 sec The following tests FAILED: 256 - RunCMake.include_directories (Failed) Errors while running CTest == Issue History Date ModifiedUsername FieldChange == 2013-11-22 09:06 George SakhnovskyNew Issue ==
Re: [cmake-developers] Review Request: Topic ExternalProject-independent-step-targets
Please review the topic ExternalProject-independent-step-targets. Looks mostly reasonable. However, I'm concerned people will misuse it to try to make all step targets independent when they shouldn't... configure of project B usually depends on a successful install of project A when B depends on A, and the target dependencies are the only thing making sure things work properly for parallel builds. The file dependencies alone are not sufficient. People *WILL* run into parallel build issues if they accidentally make something independent when it shouldn't be. (And it will probably be difficult to troubleshoot/debug...) So I would add to the documentation saying that typically, only the download and update steps ought to be considered as independent step targets. Also, I would ask Brad if the -# :: line you've removed is important for the new documentation generation scheme... I would assume so, but I do not know enough about how it works yet. HTH, David C. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request: Topic ExternalProject-independent-step-targets
On 11/22/2013 12:28 PM, David Cole wrote: So I would add to the documentation saying that typically, only the download and update steps ought to be considered as independent step targets. Would it make sense to only allow it for specific steps, or to disallow it for specific steps for which it is known bad? Also, I would ask Brad if the -# :: line you've removed is important for the new documentation generation scheme... I would assume so, but I do not know enough about how it works yet. Actually the topic should be rebased on master to resolve conflicts with the documentation formatting cleanup I made here: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=01ecd24f Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request: Topic ExternalProject_GitUpdate
Jc, Matt, On 11/18/2013 10:10 AM, Jean-Christophe Fillion-Robin wrote: Will give a try and let you know how it goes. [snip] On 11/18/2013 12:40 PM, Matt McCormick wrote: I have checkout out the branch, will test it locally, and make any notes of unexpected behavior. Thanks for looking at this topic. Once you have reported back from local experimentation we can proceed with it. Thanks, -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Invitation to connect on LinkedIn
LinkedIn I'd like to include you in my network to share updates and stay in touch. - Jayesh Jayesh PATEL Technical Lead at Grit Innovation Perth Area, Australia Confirm that you know Jayesh PATEL: https://www.linkedin.com/e/-rtxjh0-hobqj4qk-5z/isd/18241708292/O8KZDGVc/?hs=falsetok=3YPeRC736ogC01 -- You are receiving Invitation to Connect emails. Click to unsubscribe: http://www.linkedin.com/e/-rtxjh0-hobqj4qk-5z/ZGg-5-2d2hd9jQi1ZWe-Yk2ath91_BVSt0Bgvyjz/goo/cmake-developers%40cmake%2Eorg/20061/I5983053395_1/?hs=falsetok=1fFmVpnC-ogC01 (c) 2012 LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Invitation to connect on LinkedIn
On 11/22/2013 01:00 PM, Jayesh PATEL wrote: I'd like to include you in my network to share updates and stay in touch. http://community.linkedin.com/questions/19313/how-do-i-stop-linkedin-sending-out-invitation-emai.html -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Review Request: Topic ExternalProject-independent-step-targets
On 22/11/13 19:03, Brad King wrote: On 11/22/2013 12:28 PM, David Cole wrote: So I would add to the documentation saying that typically, only the download and update steps ought to be considered as independent step targets. Would it make sense to only allow it for specific steps, or to disallow it for specific steps for which it is known bad? I wouldn't allow it only for specific step, because user might want to add some custom step and they could be either dependent or independent. For now I added some documentation and added an AUTHOR_WARNING if used for the steps configure, build, install, or test. Also, I would ask Brad if the -# :: line you've removed is important for the new documentation generation scheme... I would assume so, but I do not know enough about how it works yet. Actually the topic should be rebased on master to resolve conflicts with the documentation formatting cleanup I made here: I moved the :: in the previous line, as Brad did ;) Anyway I rebased the branch on master and solved the conflicts Cheers, Daniele -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] documenting a CMake 'use' file
Now that CMake is using RST for documentations, is there a good guide for how to document modules that mainly provide new functions? In particular, I am wondering if it is possible, and if so, what recommendations there are if any, to document functions 'doxygen style', i.e. the documentation immediately preceding the function definitions, rather than all at the top. And/or, what parts of a CMake module are extracted for documentation and is there a way to say 'ignore comments after this point'? Any pointers are appreciated. Thanks, -- Matthew -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] documenting a CMake 'use' file
On 11/22/2013 03:24 PM, Matthew Woehlke wrote: In particular, I am wondering if it is possible, and if so, what recommendations there are if any, to document functions 'doxygen style', i.e. the documentation immediately preceding the function definitions, rather than all at the top. See the cmake-developer.7 manual Module Documentation section. -Brad -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
