Re: [cmake-developers] A policy for Policies

2015-06-18 Thread Brad King
On 06/11/2015 02:20 PM, Stephen Kelly wrote: So, KDE4 as a platform breaks the cmake compatibility design for its downstreams. At least ECM, used by KDE Frameworks 5, doesn't do that. That is unfortunate :( I still think they should be unconditional warnings. Yes, see below. I also think

Re: [cmake-developers] Startup Project Configuration [mantis 15578]

2015-06-18 Thread Brad King
On 06/16/2015 07:34 PM, Davy Durham wrote: Would that involve different macro's anyhow? I could try and write a macro specifically to check that, or were you thinking I should be able to use the macros that are already there? And would you be opposed to my writing a dedicated one? Please

[cmake-developers] [CMake 0015623]: Raspbian puts some system libraries in /usr/lib/arm-linux-gnueabihf which CMake doesn't search

2015-06-18 Thread Mantis Bug Tracker
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15623 == Reported By:Eric Wing Assigned To:

Re: [cmake-developers] CMake instances sharing some modifiable resources

2015-06-18 Thread Brad King
On 06/17/2015 04:56 PM, Robert Goulet wrote: I saw the file(LOCK) command That should be what you need. All the file_append.cmake scripts need to agree on a file path to lock (like output.txt.lock). -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ

Re: [cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread Brad King
On 06/18/2015 01:41 PM, James Johnston wrote: 3. Patch Windows-Embarcadero.cmake, as I propose here. I think that makes sense. +set(CMAKE_JOB_POOL_LINK BCC32LinkPool) Hmm. What if the user sets this too? Perhaps we should allow users/projects to take control of this setting by making the

Re: [cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread James Johnston
See updated attached patch. I've retested it to ensure the VTK 5.4.2 build I've been working with still builds correctly - and it still does. Thank you for considering it. -James -Original Message- From: Brad King [mailto:brad.k...@kitware.com] +set(CMAKE_JOB_POOL_LINK

[cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread James Johnston
Hi, The attached patch is in regards to issue #15620 in mantis bug tracker (Ninja generator triggers race condition in Borland bcc32 linker causing intermittent build failure). Thanks to Brad King's suggestion, I think using job pools is a lot easier than trying my proposed workaround (which I

Re: [cmake-developers] [PATCH] Fixed Borland linker issue when used with Ninja generator

2015-06-18 Thread Brad King
On 06/18/2015 03:05 PM, James Johnston wrote: See updated attached patch. Thanks, applied: Embarcadero: Run at most one linker invocation at a time http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=078b60f0 I moved most of the explanation from comments to the commit message and left a

Re: [cmake-developers] CMake instances sharing some modifiable resources

2015-06-18 Thread Robert Goulet
True it works; I was wrongly setting the file lock on the file I was trying to write into. Thanks! -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Thursday, June 18, 2015 9:28 AM To: Robert Goulet Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers]