Re: [cmake-developers] FindZLIB module should find debug and release variants

2015-08-23 Thread Rolf Eike Beer
Michael Scott wrote: Hi, Carrying on in the list of open issues to look at for contributing to CMake, I've had a look at issue 15280 - FindZLIB module should find debug and release variants. I've made some changes to the FindZLIB module which should make it so that debug and release

[cmake-developers] FindBZip2.cmake

2015-08-23 Thread Rolf Eike Beer
Brad, you introduced in 7c912af2 that this module not only looks into the Windows registry, but also added PATH_SUFFIXES include and lib for find_* calls. Am I gettings something wrong? Wouldn't CMake automatically append those to all paths given? Another thing which I found is that there

[cmake-developers] FindZLIB module should find debug and release variants

2015-08-23 Thread Michael Scott
Hi, Carrying on in the list of open issues to look at for contributing to CMake, I've had a look at issue 15280 - FindZLIB module should find debug and release variants. I've made some changes to the FindZLIB module which should make it so that debug and release variants are found as

Re: [cmake-developers] FindZLIB module should find debug and release variants

2015-08-23 Thread Roger Leigh
On 23/08/2015 10:07, Michael Scott wrote: Carrying on in the list of open issues to look at for contributing to CMake, I've had a look at issue 15280 - FindZLIB module should find debug and release variants. I've made some changes to the FindZLIB module which should make it so that debug and

[cmake-developers] I fear $COMPILE_FEATURES:* is not really useful...

2015-08-23 Thread Rolf Eike Beer
Yes, sadly. I have this code: if (NOT CMAKE_VERSION VERSION_LESS 3.1) set_property(TARGET osmium_convert PROPERTY CXX_STANDARD 11) target_compile_definitions(osmium_convert PRIVATE $$COMPILE_FEATURES:cxx_decltype_incomplete_return_types:BOOST_RESULT_OF_USE_DECLTYPE) endif() So, in theory,

[cmake-developers] FindZLIB module should find debug and, release variants

2015-08-23 Thread Michael Scott
I don't think so. The debug suffix is a Windows-ism which you don't see on UNIX. Okay great, I thought this was the case. One criticism of the patch: It's not using SelectLibraryConfigurations to choose between the release and debug variants. Could it be updated to do that for consistency?

[cmake-developers] cmake's built-in support for android using nvidia nsight tegra

2015-08-23 Thread Peter List
TLDR: How do I tell cmake to include Ant Build in my vcxproj, so that it will package my project into an APK? I can generate vcxproj that builds a Tegra-Android *.so file, but it does not build me an APK, and my vcxproj is missing the Ant Build property section. As a reference, if I use Visual