Re: [cmake-developers] Add command line options for deprecation message control

2015-11-06 Thread Michael Scott
Thanks for the feedback. Please split up the rest of the patch into a series of steps like that Okay I'll see if I can break it down further. ignoreWarningLevels => force Yes that does sound better, thanks. increments the count by default instead of only when an explicit option has been

Re: [cmake-developers] Add command line options for deprecation message control

2015-11-06 Thread Brad King
On 11/04/2015 06:40 PM, Michael Scott wrote: > Here is the patch with all, new, error related code removed and > including the relevant documentation changes. Thanks. Now this is getting down closer to a reviewable scale. However, this will be much easier to review as a series of small

Re: [cmake-developers] [PATCH 0/3] Support for multilingual SLAs for the CPack DMG generator

2015-11-06 Thread Brad King
On 11/05/2015 09:05 AM, Levermann, Simon wrote: > fixed in the attached version. Thanks. I've applied it with a few tweaks. I found a better place for the variable docs than my previous suggestion. I also updated indentation style and tweaked the way we include Carbon.h. Merged to 'next' for

[cmake-developers] Adding Ninja file dependency to ExternalProject target

2015-11-06 Thread Chris Bieneman
Hi cmake-developers, I’m working on a patch to LLVM to support running our clang test-suite using ExternalProject. The complication here is that we want to configure the test-suite’s CMake build with the clang that is produced from the LLVM/Clang build. In my patch I try adding a dependency