On 03/22/2016 03:25 PM, Yves Frederix wrote:
> Do I understand it correctly that you suggest to pass a locally-owned
> copy of the string into the call to VariableAccessed? If so, then I am
> not sure how this would solve the problem. The problem is not that def
> is changed by VariableAccessed, th
On 03/22/2016 02:28 PM, Taylor Braun-Jones wrote:
>> Done - see attached.
>
> Whoops - I didn't update unit test in patch 0002 properly. Here's a
> new patch that's not broken.
Thanks. Actually I had made that same fix when applying the changes.
I just hadn't posted back here yet. Anyway, here
Hi Brad,
Do I understand it correctly that you suggest to pass a locally-owned
copy of the string into the call to VariableAccessed? If so, then I am
not sure how this would solve the problem. The problem is not that def
is changed by VariableAccessed, the problem is that the original char*
after
The following issue has been SUBMITTED.
==
https://public.kitware.com/Bug/view.php?id=16032
==
Reported By:Braden McDaniel
Assigned To:
On Tue, Mar 22, 2016 at 12:15 PM, Taylor Braun-Jones
wrote:
> On Tue, Mar 22, 2016 at 11:49 AM, Brad King wrote:
>> Please revise 0001 to apply cleanly on top of 78ec0461.
>>
>> Also please revise 0002 to avoid using the ZERO_CHECK target because
>> it does not exist in all VS generators. I had
The following issue has been SUBMITTED.
==
https://cmake.org/Bug/view.php?id=16031
==
Reported By:Thibault Notargiacomo
Assigned To:
On Tue, Mar 22, 2016 at 11:49 AM, Brad King wrote:
> Please revise 0001 to apply cleanly on top of 78ec0461.
>
> Also please revise 0002 to avoid using the ZERO_CHECK target because
> it does not exist in all VS generators. I had added custom target
> to the test case to use instead.
Done - see
The following issue has been SUBMITTED.
==
https://cmake.org/Bug/view.php?id=16030
==
Reported By:Gregor Jasny
Assigned To:
==
On 03/22/2016 10:30 AM, Daniel Pfeifer wrote:
> cmGlobalKdevelopGenerator: port to cmXMLWriter
> https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dfd8b4d3
>
> Oops, I saw this one failed the dashboard build. A fixup is attached.
> Sorry for the noise.
Thanks. I've applied that and wil
On 03/22/2016 10:52 AM, Yves Frederix wrote:
> What happens is that 'def' is assigned at the beginning of the
> function, but during the call to vv->VariableAccessed(...), there is
> an internal memory re-allocation
Thanks for tracking this down! Let's just add a
std::string local_def = def;
On 03/21/2016 04:17 PM, Taylor Braun-Jones wrote:
> The solution is to just list all folders in the .sln file first (patch
> 0002). With the fix in patch 0002, ALL_BUILD can then be put in
> PREDEFINED_TARGETS_FOLDER (patch 0003).
Thanks! This has been a long-standing annoyance.
Please revise 00
Hi all,
Some time ago I reported an issue with using variable_watch in 3.4.1
on the user list (reproduced by David Cole using master at that time),
see https://cmake.org/pipermail/cmake/2015-December/062213.html.
I finally found some time to get back to this and after some debugging
I did find th
The following issue has been SUBMITTED.
==
https://cmake.org/Bug/view.php?id=16029
==
Reported By:stw_sesa
Assigned To:
==
On Mon, Mar 21, 2016 at 3:39 PM Brad King wrote:
> On 03/19/2016 05:08 PM, Daniel Pfeifer wrote:
> > I ported some more generators to cmXMLWriter.
>
> Thanks. I've applied and merged to 'next' for testing:
>
> cmXMLWriter: overload Element() method for empty elements
> https://cmake.org/gitweb?p
Dear Both,
Here is my next attempt. ;-) Hopefully I'm at least getting closer...
Cheers,
Attila
0001-Introducing-the-CMAKE_DEPENDS_IN_PROJECT_ONLY-variab.patch
Description: Binary data
> On 18 Mar 2016, at 16:57, David Cole wrote:
>
> Brad's point with "/" or null terminator
The following issue has been SUBMITTED.
==
https://cmake.org/Bug/view.php?id=16028
==
Reported By:David Wagner
Assigned To:
==
16 matches
Mail list logo