date:20160602

Re: [cmake-developers] CMake execute_process/signal_handler on Unix

2016-06-02 Thread Yordanov, Dimitar

Hi Brad,

thanks for responding!

* Brad King  [16-06-01 17:18 CEST]:
> On 06/01/2016 09:04 AM, Yordanov, Dimitar wrote:
> > I'm looking into an issue with a CMake build on Linux hanging in a
> > select syscall, when using EXECUTE_PROCESS without any additional
> > arguments. The subprocess executed is "chmod". The child finishes and
> > is marked as a zombie, but CMake did not realize that. The only
> > descriptors left open are the one of the signaling pipe.
> 
> The code in question uses a well-known idiom to make SIGCHLD
> select()able.  It has worked well for years on many platforms.
> Are you running inside some kind of virtualization or emulation
> environment?

Actually not. The server is maybe under heavy load, but should it
matter?

> 
> > is the use of a shared variable "kwsysProcesses" in the signal
> > handler. I think the usage of non volatile shared objects should be
> > avoided in signal handlers and we should just do as less as we
> > can in there.
> 
> IIRC we suppress signals while updating the shared variables.
> CMake also doesn't use threads.

Possibly I'm on the wrong track, but couldn't the compiler reorder the
code where kwsysProcess is set, and move it out of the blocked
section? Should it be volatile to avoid such scenario?

> > Why do we need the "(void)pipeStatus;" lines. For debugging?
> 
> Some compilers complain we don't use the return value of write().
> Therefore we must assign it to a variable.  Then compilers
> complain that the variable is assigned a value that is never
> used.  The cast suppresses this.

I thought (void)write(...); is a portable way to say that we are not
interested in the return value. Not that I would change running code
for that.

> > Why do we need to read from the pipe in the signal handler?
> 
> If many signals are received in succession before the select()
> wakes up and reads from the pipe then it could fill the pipe
> and block in the handler.  We do a non-blocking read to make
> sure the pipe never has more than one byte in it.  All we care
> about is waking up any blocking select().

The write end is also non-blocking so it would not block the signal
handler. I was just trying to understand the implementation and if I'm
not misunderstanding something.

> 
> BTW, in the long run I'd like to drop this code completely and
> move to libuv.  Meanwhile I'd rather not spend too much time
> updating the existing implementation.

Thanks for sharing.

Best wishes
Dimitar

> 
> -Brad
> 
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Productbuild CPack generator

2016-06-02 Thread Domen Vrankar

> Does anyone here know if we have test coverage already for some cpack
> generators where we create a package, then unpack it to verify the results?
>

Tests/CPackComponentsDEB (Deb), Tests/CPackComponentsForAll (RPM) and tests
in Tests/RunCMake/CPack (at the moment Deb, RPM, TGZ) all verify content of
generated packages.

I intended for Tests/RunCMake/CPack to be the location of all tests for
CPack generated packages that can be verified with command line tools in a
way that you specify the type of test and if other generators have the same
capabilities they should use the same test with additional generator
specific variables in a separate file.
Unfortunately atm there are still some issues with those tests with the
most annoying being the verbosity because of:
- test should automatically cover different packaging styles [monolithic,
components, ...],
- for most tests files count and content should be the same with each
generator's Helpers.cmake providing the format (at the moment each test has
to provide special ExpectedFiles cmake script so it's too complicated to
write tests)

It's on my TODO list to extend Tests/RunCMake/CPack so hopefully I'll get
to it in the following week or two.
If you'd like to add your tests to it there is a README.txt file there that
explains how it works and how to add your own tests to it.

Regards,
Domen
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?

2016-06-02 Thread Matthäus G . Chajdas

Thanks!

Cheers,
  Matthäus

Am 02.06.2016 um 15:44 schrieb Brad King:
> On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote:
>> done - I had to squash and force push once more, because I used the
>> wrong author in the first commit.
>>
>> Everything is now in one commit here:
>> https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e95b62110715c06fb76b57fdfb13ea493a94c0c4
>>
>> Thanks for the timely feedback!
> 
> I renamed the topic to 'FindOpenCL-imported-target', added some minor
> tweaks, and merged to 'next' for testing:
> 
>  FindOpenCL: Add an imported target
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b66d4739
> 
> If any fixes are needed please extend the topic and merge to 'next'
> again.
> 
> Thanks,
> -Brad
> 

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Productbuild CPack generator

2016-06-02 Thread clinton

Hi Harry, 

I have submitted a productbuild generator this morning. 
https://cmake.org/gitweb?p=cmake.git;a=commit;h=b746bd5c 

Its capabilities should be about equal to the PackageMaker generator. The code 
for distribution.xml is shared between PackageMaker and productbuild. 
The preflight/postflight script support should be better with this new 
generator than with PackageMaker. 

Please do help with testing and development. 

>From your other email with suggestions, I have implemented the --version 
>parameter for pkgbuild and product build, and fixed finding the pkgutil and 
>productbuild exectuables. 

I tried a user controlled setting for --install-location but ran into some 
difficulty getting cmCPackGenerator to cooperate. 
I decided to leave --install-location as '/' and do not see any negative 
effects of that. That can be revisited, of course. 

Does anyone here know if we have test coverage already for some cpack 
generators where we create a package, then unpack it to verify the results? 

Clint 

- On Jun 2, 2016, at 6:21 AM, Harry Mallon  wrote: 

> I found this on the other mailing list but it isn't getting much love. Is 
> anyone
> out there who can tell me how far from being merged in it is? It would really
> reduce the hackery in our cmake scripts here and I am happy to contribute to
> it's testing and development if I get some time.
> http://public.kitware.com/pipermail/cmake/2016-May/063493.html

> Harry

> Harry Mallon

> CODEX | Software Engineer

> 60 Poland Street | London | England | W1F 7NT

> E ha...@codexdigital.com | T +44 203 7000 989

> Website | Facebook | Twitter

> --

> Powered by www.kitware.com

> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ

> Kitware offers various services to support the CMake community. For more
> information on each offering, please visit:

> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html

> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html

> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake-developers
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] fix issue #0016076 Add a --bindir option to bootstrap and use it to install cmake in custom directory

2016-06-02 Thread BUNEL Nicolas

Hi,

Thanks for applying this patch.
I tried to use --bindir option with a clone of 'next' branch, and it's OK.
Cmake is correctly installed in the PREFIX/BIN_DIR directory.

Thanks
Nicolas

-Message d'origine-
De : Brad King 
Envoyé : mercredi 1 juin 2016 20:11

On 05/30/2016 10:50 AM, BUNEL Nicolas wrote:
> Here, the new patch

Thanks.

I've applied the patches, squashed, and made some minor tweaks.
It has been merged to 'next' for testing:

 Add option to control 'bin' directory of CMake's own installation (#16076)
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=18bfbc97

Please try out that version.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [MODERN] CMake 3.6+ vs Qt 5.6 vs MSVC2015

2016-06-02 Thread Konstantin Podsvirov

Hi all! Modern master updated! :-)

It's time to upgrade: CMake 3.6.20160602 now available!

Let me remind you of the link.

Windows 32bit:

http://ifw.podsvirov.pro/cmake/cmake-master-win32-online.exe

Windows 64bit:

http://ifw.podsvirov.pro/cmake/cmake-master-win64-online.exe

If you have used it before, you can update via "CMake Maintenance Tool"

I used Windows 7, but it should work for Windows Vista and Windows 8 and 
Windows 10.

I ask those wishing to test the functionality.

And new:

 Linux (Debian) amd64:

 http://ifw.podsvirov.pro/cmake/cmake-master-amd64-online.run

 Please test it :-)

>>  01.10.2015, 09:29, Konstantin Podsvirov" :
>>>   Hi all! Modern master alive! :-)
>>>
>>>   It's been almost a month and it's time to upgrade:
>>>
>>>   3.3.20150901 CMake => CMake 3.3.20151001
>>>
>>>   Dear friends, I have a question and call for help.
>>>
>>>   With my assistance the project has an option for component installation 
>>> project:
>>>
>>>   CMake_INSTALL_COMPONENTS
>>>
>>>   Unfortunately not all files found your component.
>>>   The files to be installed without specifying a component fall into 
>>> 'Unspecified' component.
>>>   Need to parse them out and assign them to the component context.
>>>
>>>   Now have the components:
>>>
>>>   - cmake;
>>>   - ctest;
>>>   - cpack;
>>>   - cmake-gui;
>>>   - sphinx-man;
>>>   - sphinx-html;
>>>   - sphinx singlehtml;
>>>   - sphinx-qthelp
>>>
>>>   and General for everything else
>>>
>>>   Is Unspecified;
>>>
>>>   A list of unaccounted for 'Unspecified' of files to install on the Window 
>>> is attached.
>>>
>>>   Links to the installers were specified earlier (see below).
>>>
>>>   On 28.07.2015, 17:49, "Konstantin Podsvirov" :
   Hi dear CMake developers!

   27.07.2015, 18:52, "Brad King" :
>   On 07/24/2015 03:46 AM, Konstantin Podsvirov wrote:
>>   To solve the problem you run cmake-gui is now possible with the
>>   the following changes:
>
>   Applied as two separate commits with minor tweaks:
>
>   cmake-gui: Install Qt5 Windows platform plugin
>   http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=42f0155b
>
>   CMake: Add option CMake_INSTALL_DEPENDENCIES
>   http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=068e7962

   Code now in 'master' branch.

   Thanks, Brad!

   Meet/install/CMake built modern update on MSVC2015 c QtDialog based on 
 Qt 5.5 from today :-)

   Windows 32bit:

   http://ifw.podsvirov.pro/cmake/cmake-master-win32-online.exe

   Windows 64bit:

   http://ifw.podsvirov.pro/cmake/cmake-master-win64-online.exe

   cmake-gui should work now, but if not, then update your system and 
 install

   The Visual C++ Redistributable for Visual Studio 2015 from the link 
 below:

   http://www.microsoft.com/en-us/download/details.aspx?id=48145

   As always, questions and suggestions are welcome.
>>>
>>>   --
>>>   Regards,
>>>   Konstantin Podsvirov
>>>   ,--
>>>
>>>   Powered by www.kitware.com
>>>
>>>   Please keep messages on-topic and check the CMake FAQ at: 
>>> http://www.cmake.org/Wiki/CMake_FAQ
>>>
>>>   Kitware offers various services to support the CMake community. For more 
>>> information on each offering, please visit:
>>>
>>>   CMake Support: http://cmake.org/cmake/help/support.html
>>>   CMake Consulting: http://cmake.org/cmake/help/consulting.html
>>>   CMake Training Courses: http://cmake.org/cmake/help/training.html
>>>
>>>   Visit other Kitware open-source projects at 
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>>   Follow this link to subscribe/unsubscribe:
>>>   http://public.kitware.com/mailman/listinfo/cmake-developers
>>
>>  Regards,
>>  Konstantin Podsvirov

Regards,
Konstantin Podsvirov
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH 1/1] Compiler/TI: Pass libraries as last part to linker

2016-06-02 Thread Brad King

On 06/02/2016 04:53 AM, Alexander Stein wrote:
> If e.g. libc.a is passed before any objects the linker raises the follwing
> warning: cannot resolve archive libc.a to a compatible library, as no
> input files have been encountered
> In the end the library is skipped and missing symbols occur.
> 
> Signed-off-by: Alexander Stein 

Thanks, applied:

 Compiler/TI: Pass libraries as last part to linker
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=89317915

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?

2016-06-02 Thread Brad King

On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote:
> done - I had to squash and force push once more, because I used the
> wrong author in the first commit.
> 
> Everything is now in one commit here:
> https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e95b62110715c06fb76b57fdfb13ea493a94c0c4
> 
> Thanks for the timely feedback!

I renamed the topic to 'FindOpenCL-imported-target', added some minor
tweaks, and merged to 'next' for testing:

 FindOpenCL: Add an imported target
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b66d4739

If any fixes are needed please extend the topic and merge to 'next'
again.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Productbuild CPack generator

2016-06-02 Thread Harry Mallon

I found this on the other mailing list but it isn't getting much love. Is 
anyone out there who can tell me how far from being merged in it is? It would 
really reduce the hackery in our cmake scripts here and I am happy to 
contribute to it's testing and development if I get some time.
http://public.kitware.com/pipermail/cmake/2016-May/063493.html

Harry

Harry Mallon

CODEX | Software Engineer

60 Poland Street | London | England | W1F 7NT

E ha...@codexdigital.com | T +44 203 7000 
989

Website | Facebook 
| Twitter

[http://www.codexdigital.com/?action=asset&id=E55D8A6F-AF62-4978-8FF1-435A85AFADBF]
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Some trivial patches

2016-06-02 Thread Daniel Pfeifer

On Thu, Jun 2, 2016 at 11:15 AM, Tobias Hunger  wrote:
> On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote:
>> On 06/01/2016 05:04 AM, Tobias Hunger wrote:
>> > Attached you will find a couple of really small changes that add const to a
>> > method and fix a couple of typos in comments. Trivial stuff.
>>
>> Thanks.  I've applied the changes:
>>
>>  cmSearchPath: Fix typo in comment
>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e
>>
>>  cmSourceFileLocation: Fix typo in comment
>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64
>>
>>  cmGlobalGenerator: Make IsMultiConfig() const
>>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf
>>
>> > This is mostly to figure out how to contribute code:-)
>>
>> Good job.  For large changes (e.g. cmake-daemon work) feel free
>> to publish your branch somewhere and post a link here.  For most
>> changes please post here.
>
> Why did the typo fixes end up in the master branch and the const fix in the 
> next
> branch?

Because of the code freeze for CMake 3.6:
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/16479

> Do I need to do something to get it from next to master at some point?

No.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Some trivial patches

2016-06-02 Thread Tobias Hunger

On Mi, 2016-06-01 at 11:18 -0400, Brad King wrote:
> On 06/01/2016 05:04 AM, Tobias Hunger wrote:
> > Attached you will find a couple of really small changes that add const to a
> > method and fix a couple of typos in comments. Trivial stuff.
> 
> Thanks.  I've applied the changes:
> 
>  cmSearchPath: Fix typo in comment
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=814e774e
> 
>  cmSourceFileLocation: Fix typo in comment
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd4fef64
> 
>  cmGlobalGenerator: Make IsMultiConfig() const
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2175e5bf
> 
> > This is mostly to figure out how to contribute code:-)
> 
> Good job.  For large changes (e.g. cmake-daemon work) feel free
> to publish your branch somewhere and post a link here.  For most
> changes please post here.

Why did the typo fixes end up in the master branch and the const fix in the next
branch?

Do I need to do something to get it from next to master at some point?

Best Regards,
Tobias

-- 
Tobias Hunger, Senior Software Engineer | The Qt Company
The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin
Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho. Sitz der
Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] [PATCH 1/1] Compiler/TI: Pass libraries as last part to linker

2016-06-02 Thread Alexander Stein

If e.g. libc.a is passed before any objects the linker raises the follwing
warning: cannot resolve archive libc.a to a compatible library, as no
input files have been encountered
In the end the library is skipped and missing symbols occur.

Signed-off-by: Alexander Stein 
---
 Modules/Compiler/TI-C.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Modules/Compiler/TI-C.cmake b/Modules/Compiler/TI-C.cmake
index 479666c..ebc79f4 100644
--- a/Modules/Compiler/TI-C.cmake
+++ b/Modules/Compiler/TI-C.cmake
@@ -7,4 +7,4 @@ set(CMAKE_C_CREATE_PREPROCESSED_SOURCE " 
--preproc_only --c_fi
 
 set(CMAKE_C_COMPILE_OBJECT  " --compile_only 
--c_file=--output_file=")
 set(CMAKE_C_ARCHIVE_CREATE " -r  ")
-set(CMAKE_C_LINK_EXECUTABLE " --run_linker 
--output_file= --map_file=.map  
  ")
+set(CMAKE_C_LINK_EXECUTABLE " --run_linker 
--output_file= --map_file=.map  
  ")
-- 
2.7.3

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] fixup! Simplify boolean expressions

2016-06-02 Thread Daniel Pfeifer

My "Simplify boolean expressions" refactoring caused  C4800 warnings
for MSVC builds. A fixup is attached, as I cannot ssh at the moment.
From ece15fe51c46cb93823ccd8a54243d35ebdc0d3c Mon Sep 17 00:00:00 2001
From: Daniel Pfeifer 
Date: Thu, 2 Jun 2016 09:59:36 +0200
Subject: [PATCH] fixup! Simplify boolean expressions

---
 Source/cmDependsFortran.cxx  | 3 +--
 Source/cmELF.cxx | 6 +++---
 Source/cmGeneratedFileStream.cxx | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/Source/cmDependsFortran.cxx b/Source/cmDependsFortran.cxx
index f7db417..a20fb98 100644
--- a/Source/cmDependsFortran.cxx
+++ b/Source/cmDependsFortran.cxx
@@ -654,8 +654,7 @@ bool cmDependsFortran::ModulesDiffer(const char* modFile,
 // but also do not include a date so we can fall through to
 // compare them without skipping any prefix.
 unsigned char hdr[2];
-finModFile.read(reinterpret_cast(hdr), 2);
-bool okay = static_cast(finModFile);
+bool okay = !finModFile.read(reinterpret_cast(hdr), 2).fail();
 finModFile.seekg(0);
 if (!okay || hdr[0] != 0x1f || hdr[1] != 0x8b) {
   const char seq[1] = { '\n' };
diff --git a/Source/cmELF.cxx b/Source/cmELF.cxx
index db32184..c7f8a2d 100644
--- a/Source/cmELF.cxx
+++ b/Source/cmELF.cxx
@@ -143,7 +143,7 @@ public:
   {
 this->Stream.seekg(pos);
 this->Stream.read(buf, size);
-return static_cast(this->Stream);
+return !this->Stream.fail();
   }
 
   // Lookup the SONAME in the DYNAMIC section.
@@ -497,7 +497,7 @@ private:
 this->NeedSwap) {
   ByteSwap(x);
 }
-return static_cast(this->Stream);
+return !this->Stream.fail();
   }
   bool Read(ELF_Dyn& x)
   {
@@ -505,7 +505,7 @@ private:
 this->NeedSwap) {
   ByteSwap(x);
 }
-return static_cast(this->Stream);
+return !this->Stream.fail();
   }
 
   bool LoadSectionHeader(ELF_Half i)
diff --git a/Source/cmGeneratedFileStream.cxx b/Source/cmGeneratedFileStream.cxx
index 562ff88..dee174b 100644
--- a/Source/cmGeneratedFileStream.cxx
+++ b/Source/cmGeneratedFileStream.cxx
@@ -42,7 +42,7 @@ cmGeneratedFileStream::~cmGeneratedFileStream()
   // stream will be destroyed which will close the temporary file.
   // Finally the base destructor will be called to replace the
   // destination file.
-  this->Okay = static_cast(*this);
+  this->Okay = !this->fail();
 }
 
 cmGeneratedFileStream& cmGeneratedFileStream::Open(const char* name,
@@ -71,7 +71,7 @@ cmGeneratedFileStream& cmGeneratedFileStream::Open(const char* name,
 bool cmGeneratedFileStream::Close()
 {
   // Save whether the temporary output file is valid before closing.
-  this->Okay = static_cast(*this);
+  this->Okay = !this->fail();
 
   // Close the temporary output file.
   this->Stream::close();
-- 
2.8.3

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] CMake execute_process/signal_handler on Unix

Re: [cmake-developers] Productbuild CPack generator

Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?

Re: [cmake-developers] Productbuild CPack generator

Re: [cmake-developers] [PATCH] fix issue #0016076 Add a --bindir option to bootstrap and use it to install cmake in custom directory

Re: [cmake-developers] [MODERN] CMake 3.6+ vs Qt 5.6 vs MSVC2015

Re: [cmake-developers] [PATCH 1/1] Compiler/TI: Pass libraries as last part to linker

Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?

[cmake-developers] Productbuild CPack generator

Re: [cmake-developers] Some trivial patches

Re: [cmake-developers] Some trivial patches

[cmake-developers] [PATCH 1/1] Compiler/TI: Pass libraries as last part to linker

[cmake-developers] fixup! Simplify boolean expressions

13 matches

Site Navigation

Mail list logo

Footer information