Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

2016-07-14 Thread Ben Campbell
On 15/07/16 06:47, Brad King wrote: On 07/13/2016 06:59 PM, Ben Campbell wrote: I've revised my patch to: Thanks. Please use `git format-patch` and then attach it. The inline patch was corrupted and does not apply. Oop - new patch attached! 1/1 Test #268: CMakeOnly.AllFindModules

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Kornel Benko
Am Donnerstag, 14. Juli 2016 um 16:06:17, schrieb Brad King > On 07/14/2016 03:59 PM, Kornel Benko wrote: > >> What you can do is not add your own flag and instead do > >> > >> set(CMAKE_CXX_STANDARD 14) > >> set(CMAKE_CXX_EXTENSIONS OFF) > > > > I did this, as it

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Kornel Benko
Am Donnerstag, 14. Juli 2016 um 15:27:00, schrieb Brad King > On 07/14/2016 02:48 PM, Kornel Benko wrote: > > I am asking about '-std=gnu++11'. > On 07/14/2016 02:45 PM, Kornel Benko wrote: > > The new cmake-files from QT5.7 are somehow responsible that this happens. > >

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Brad King
On 07/14/2016 02:48 PM, Kornel Benko wrote: > I am asking about '-std=gnu++11'. On 07/14/2016 02:45 PM, Kornel Benko wrote: > The new cmake-files from QT5.7 are somehow responsible that this happens. The file `lib/cmake/Qt5Core/Qt5CoreConfigExtras.cmake` in Qt 5.7 contains: set_property(TARGET

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Kornel Benko
Am Donnerstag, 14. Juli 2016 um 14:36:43, schrieb Brad King > In lyx I see the > > development/cmake/modules/FindCXX11Compiler.cmake I had to reread. Yes, I know this file too. There is set the '-std=c++14'. But I am asking about '-std=gnu++11'. Kornel

Re: [cmake-developers] [PATCH] Improve FindGIF version detection (fix for issue #16196)

2016-07-14 Thread Brad King
On 07/13/2016 06:59 PM, Ben Campbell wrote: > I've revised my patch to: Thanks. Please use `git format-patch` and then attach it. The inline patch was corrupted and does not apply. > 1/1 Test #268: CMakeOnly.AllFindModules .***Failed8.07 sec > > Not quite sure what the environment

Re: [cmake-developers] CMP0065 warning not supressed when --trace used

2016-07-14 Thread Alan W. Irwin
On 2016-07-14 13:49-0400 Brad King wrote: On 07/14/2016 01:32 PM, Alan W. Irwin wrote: I am addressing this mostly to you because you are the author of CMP0065 which has the special property that by default it does not warn when the policy is not set. However, I find it does warn when --trace

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Kornel Benko
Am Donnerstag, 14. Juli 2016 um 14:36:43, schrieb Brad King > On 07/14/2016 01:59 PM, Kornel Benko wrote: > > I was trying to compile lyx with QT5.7. > > ... > > found that the flags in the flag.cmake files were mismatched. > > > > Therefore I started searching, where the

Re: [cmake-developers] [PATCH v5] SystemTools: Teach GetEnv to use correct encoding on Windows

2016-07-14 Thread Brad King
On 07/13/2016 10:17 PM, Dāvis wrote: > On Windows getenv (and putenv) uses ANSI codepage so it needs to be encoded > to internally used encoding (eg. UTF-8). Here we use _wgetenv (and _wputenv) > instead and encode that. Thanks. Based on that I've constructed a revised topic for KWSys:

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Brad King
On 07/14/2016 01:59 PM, Kornel Benko wrote: > I was trying to compile lyx with QT5.7. > ... > found that the flags in the flag.cmake files were mismatched. > > Therefore I started searching, where the extra ' --std=gnu++11' came > from, and found it in Modules/Compiler/GNU-CXX.cmake. It appears

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Kornel Benko
Am Donnerstag, 14. Juli 2016 um 13:35:06, schrieb Brad King > On 07/14/2016 01:13 PM, Kornel Benko wrote: > > -- The CXX compiler identification is GNU 6.1.0 > > -- CMAKE_CXX11_EXTENSION_COMPILE_OPTION = -std=gnu++11 > > I expected here "--

Re: [cmake-developers] CMP0065 warning not supressed when --trace used

2016-07-14 Thread Brad King
On 07/14/2016 01:49 PM, Brad King wrote: > Add -DCMAKE_POLICY_WARNING_CMP0065=OLD to disable the warning. Sorry, I meant `-DCMAKE_POLICY_DEFAULT_CMP0065=OLD`: https://cmake.org/cmake/help/v3.6/variable/CMAKE_POLICY_DEFAULT_CMP.html -Brad -- Powered by www.kitware.com Please keep

[cmake-developers] CMP0065 warning not supressed when --trace used

2016-07-14 Thread Alan W. Irwin
Hi Chuck: I am addressing this mostly to you because you are the author of CMP0065 which has the special property that by default it does not warn when the policy is not set. However, I find it does warn when --trace is set which I am fairly sure is a (minor) bug. Please take a look at the

Re: [cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Brad King
On 07/14/2016 01:13 PM, Kornel Benko wrote: > -- The CXX compiler identification is GNU 6.1.0 > -- CMAKE_CXX11_EXTENSION_COMPILE_OPTION = -std=gnu++11 > I expected here "-- CMAKE_CXX11_EXTENSION_COMPILE_OPTION = -std=c++14". That is the option for C++11 with extensions. See

[cmake-developers] Wrong cxx-extension flags

2016-07-14 Thread Kornel Benko
I have 2 compilers installed. The attached minimal CMakeLists.txt example shows everything OK if using the compiler at standard place. -- The C compiler identification is GNU 4.8.4 -- The CXX compiler identification is GNU 4.8.4 -- Check for working C compiler: /usr/bin/cc -- Check for working C

Re: [cmake-developers] cmake -E capabilities

2016-07-14 Thread Brad King
On 07/11/2016 10:13 AM, Tobias Hunger wrote: > https://github.com/hunger/CMake/commits/cmake-capabilities > > is in a state now that could use another review. Thanks. I've applied the infrastructure update commits after making a few minor fixes and merged to `next` for testing: Make CMake