[cmake-developers] patch VS2010 generator : handle VS_GLOBAL_RootNamespace as well as VS_GLOBAL_ROOTNAMESPACE

2016-07-20 Thread Benjamin Ballet via cmake-developers
Hi folks, As user I'm currently working on migrating C++CLI projects to CMake. I wasted a few hours because I used VS_GLOBAL_RootNamespace (a specialized version of VS_GLOBAL_ property) instead of VS_GLOBAL_ROOTNAMESPACE. So here is a patch to save the next one from wasting those same hours.

Re: [cmake-developers] [PATCH v4] For consoles output on Windows use our own std::streambuf

2016-07-20 Thread Brad King
On 07/09/2016 10:12 PM, Dāvis Mosāns wrote: > int main(int ac, char const* const* av) > { > +#if defined(_WIN32) > + // Replace streambuf so we can output Unicode to console > + cmsys::ConsoleBuf *cbufio = CM_NULLPTR; > + cmsys::ConsoleBuf *cbuferr = CM_NULLPTR; > + std::streambuf *coutbuf =

Re: [cmake-developers] [PATCH v4 2/4] Deprecate const char* SystemTools::GetEnv function

2016-07-20 Thread Brad King
On 07/07/2016 05:54 PM, Dāvis Mosāns wrote: > Source/kwsys/SystemTools.hxx.in | 14 -- Thanks. Applied to KWSys first: http://review.source.kitware.com/21348 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

Re: [cmake-developers] [PATCH v5 2/2] Add MinGW support for FStream

2016-07-20 Thread Brad King
On 07/18/2016 09:28 AM, Brad King wrote: > Thanks. I've added this and its parent commit to KWSys: > > http://review.source.kitware.com/21339 This is now in KWSys `master`. I've updated it in CMake: KWSys 2016-07-19 (9d1dbd95) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9ef2b2b1

Re: [cmake-developers] [PATCH v3 6/7] Use Windows version of Directory::Load for MinGW too

2016-07-20 Thread Brad King
On 07/06/2016 03:12 PM, Dāvis Mosāns wrote: > Otherwise it would use POSIX functions which works only for ASCII paths. Thanks. Applied to KWSys first with minor tweaks: http://review.source.kitware.com/21349 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the

Re: [cmake-developers] [PATCH v4 3/4] Use SystemTools::GetEnv and HasEnv functions

2016-07-20 Thread Brad King
On 07/18/2016 10:00 AM, Brad King wrote: > On 07/07/2016 05:54 PM, Dāvis Mosāns wrote: >> Source/kwsys/SystemTools.cxx| 38 >> +++-- >> Source/kwsys/testSystemTools.cxx| 9 --- > > Applied to upstream KWSys first: > >

Re: [cmake-developers] Security Report for CMake

2016-07-20 Thread Brad King
On 07/20/2016 02:31 AM, Justin Clift wrote: > Amir pointed out there may be other locations with the same > unquoted path problem in the template. Thanks. I'm not very familiar with NSIS or the syntax in the template file so we'll be dependent on others to find/fix any remaining problems.

Re: [cmake-developers] Improved WIX support

2016-07-20 Thread Stuermer, Michael SP/HZA-ZSEP
> -Original Message- > From: Nils Gladitz [mailto:nilsglad...@gmail.com] > Sent: Wednesday, July 20, 2016 12:03 PM > To: Stuermer, Michael SP/HZA-ZSEP; CMake Developers > Subject: Re: [cmake-developers] Improved WIX support > > On 19.07.2016 17:43, Stuermer, Michael SP/HZA-ZSEP wrote: > >

Re: [cmake-developers] Improved WIX support

2016-07-20 Thread Nils Gladitz
On 19.07.2016 17:43, Stuermer, Michael SP/HZA-ZSEP wrote: Hello there, in short: I fixed some minor issues with WIX toolset support and added the possibility to integrate service installation/uninstallation with generated msi packages. Please review and comment what is missing for

Re: [cmake-developers] Security Report for CMake

2016-07-20 Thread Justin Clift
On 19 Jul 2016, at 21:29, Brad King wrote: > On 07/19/2016 01:46 PM, Cyril VALLICARI wrote: >> Here a Patch that correct the vulnerability > > Thanks, applied: > > NSIS: Quote uninstaller path when executing it in a shell >