Re: [cmake-developers] How to speed up CMake configuration on macOS

2019-03-23 Thread Ben Boeckel via cmake-developers
On Sat, Mar 23, 2019 at 15:07:39 +0100, Gregor Jasny via cmake-developers wrote: > in the past when building CMake (itself) I spent long times waiting for > configuration of the embedded libraries. Mostly libcurl send / receive > signature detection. Today I had the idea of using system

Re: [cmake-developers] Question about fetching big repositories with ExternalProject_Add

2019-03-14 Thread Ben Boeckel via cmake-developers
On Mon, Mar 11, 2019 at 16:50:21 +0100, workbe...@gmx.at wrote: > i play around much with ExternalProject_Add and i found some kind of > "error". When fetching big repositories like llvm cmake don't show any > output when cloning the repository which makes the user believe cmake > stucks, is there

Re: [cmake-developers] $LIST_LENGTH{} syntax

2019-01-22 Thread Ben Boeckel via cmake-developers
On Tue, Jan 22, 2019 at 19:31:43 +0100, tors...@robitzki.de wrote: > Currently, the Code that evaluates the ${}-Syntax only evaluates the key, if > the key is not an empty string: > > const char* cmCommandArgumentParserHelper::ExpandSpecialVariable( > const char* key, const char* var) > { >

Re: [cmake-developers] Referencing all sources in compile command

2019-01-02 Thread Ben Boeckel via cmake-developers
ers files sneaking in on its commandline. > On Mon, Dec 31, 2018 at 2:17 PM Ben Boeckel wrote: > > Other questions which spring to mind: > > > > - Does it support making just the compile artifacts from the source > > files or does it always do the link

Re: [cmake-developers] Referencing all sources in compile command

2018-12-31 Thread Ben Boeckel via cmake-developers
On Sun, Dec 30, 2018 at 13:09:23 -0800, Saleem Abdulrasool wrote: > I was looking at supporting Swift as a language in CMake. I know that > CMake has some preliminary support that assumes that you are building on > macOS with Xcode. I am trying to support building swift libraries and >

Re: [cmake-developers] Preferred case for macro names?

2018-11-14 Thread Ben Boeckel
On Tue, Nov 13, 2018 at 11:36:24 +0100, Eric Noulard wrote: > > My personal tendency is to use lower case for local variables and upper > > case for global variables. May be we can normalize variables to upper case > > regarding global variables used by CMake itself (which is globally the > >

Re: [cmake-developers] Preferred case for macro names?

2018-11-14 Thread Ben Boeckel
On Tue, Nov 13, 2018 at 06:11:26 -0500, David Cole via cmake-developers wrote: > I would just like to point out that some modules (ExternalData, > ExternalProject, to name two specific examples) adopted the convention > to prefix all their provided function names with the module name and > an

Re: [cmake-developers] option to prevent in-source builds

2018-11-09 Thread Ben Boeckel
On Fri, Nov 09, 2018 at 07:28:54 -0500, Taylor Holberton wrote: > A lot of projects that use CMake already have a `./cmake` directory, I > would think `./cmake/init.json` would fit nicer as opposed to the hidden > directory. I'm not a fan of hidden directories in software projects anyway. There

Re: [cmake-developers] Python bindings for CTest

2018-10-19 Thread Ben Boeckel
On Fri, Oct 19, 2018 at 12:33:34 -0400, Brad King wrote: > If your goal is to submit to CDash, one could generate the .xml > files directly from python and not need CTest at all. There is some code in Spack which does this already (though it is very Spack-specific, it might provide some help):

Re: [cmake-developers] BundleUtilities question

2018-09-07 Thread Ben Boeckel
On Fri, Aug 24, 2018 at 12:24:39 +, Kinga Kasa wrote: > Error: copying file (when tries to copy the framework to the correct place) > and > "warning: cannot resolve item @rpath/QtNetwork.framework/Versions/5/QtNetwork > warning: gp_resolved_file_type non-absolute file >

Re: [cmake-developers] ctest parallelism for --repeat-until-failure

2018-09-04 Thread Ben Boeckel
On Fri, Mar 23, 2018 at 09:33:28 -0700, Jupp Müller wrote: > I have a question regarding the behavior of ctest with regard to the > --repeat-until-failure option. It seems that this option > sequentializes test execution for single tests in a test suite, while > different tests can be run parallel

Re: [cmake-developers] RfD: deprecate link_directories() and link_libraries()

2018-09-03 Thread Ben Boeckel
On Tue, Aug 21, 2018 at 09:14:37 +0200, Gregor Jasny via cmake-developers wrote: > How would one deal with '#pragma comment lib' w/o link_directories()? I usually disable it with `-DBOOST_ALL_NO_LIB` (for Boost). In addition, I find them to be not useful because Boost library names change between

Re: [cmake-developers] How to obtain a list of target dependencies

2018-03-12 Thread Ben Boeckel
On Mon, Mar 12, 2018 at 15:11:28 -0500, Robert Dailey wrote: > I'm going to add the CMake Dev group as well, since I asked this same > question last year around May and I didn't get any response. Hoping > for some help this time around. I don't see anything documented, so > maybe the developers

Re: [cmake-developers] Cmake-server question

2018-02-15 Thread Ben Boeckel
On Wed, Feb 14, 2018 at 19:19:39 +0100, Paweł Rutka wrote: > I would like to ask about some important feature: > Is there any possibility to provide form Cmake Server side location of > command that generate the target? The Use Case is as follow: > In IDE you want to, after Class creation,

Re: [cmake-developers] cmake_format

2018-02-07 Thread Ben Boeckel
On Wed, Feb 07, 2018 at 13:27:28 +0100, Cristian Adam wrote: > I don't remember seeing this tool advertised on the CMake mailing lists: > > https://github.com/cheshirekow/cmake_format/tree/master/cmake_format Cool! I have some feature requests, but I'll add them over there :) . --Ben --

Re: [cmake-developers] Adding backtraces to every command

2018-01-31 Thread Ben Boeckel
On Wed, Jan 31, 2018 at 18:53:39 +, Rich Chiodo via cmake-developers wrote: > We're (Microsoft) investigating tighter integration with CMake -Server > and the IDE. > > One of the things we need is to be able to get the location of where a > property is set. > > CMake has a backtracing

Re: [cmake-developers] Undocumented command line flags (-H, -B) why?

2018-01-16 Thread Ben Boeckel
On Tue, Jan 16, 2018 at 14:42:32 +0100, Cristian Adam wrote: > I don't know why it wasn't a pull request on gitlab though. > Thu, 30 Jun 2016 12:24:02 -0700 This predates Gitlab usage for patch submission (which started around July 2016). --Ben -- Powered by www.kitware.com Please keep

Re: [cmake-developers] Undocumented command line flags (-H, -B) why?

2018-01-16 Thread Ben Boeckel
On Tue, Jan 16, 2018 at 13:10:07 +0100, Eric Noulard wrote: > I came accross -H and -B undocumented command line flags for cmake: > https://stackoverflow.com/questions/24460486/cmake-build-type-not-being-used-in-cmakelists-txt/24470998#24470998 > > Is there any reason to keep those undocumented?

Re: [cmake-developers] kwsysProcess threadsafety

2018-01-05 Thread Ben Boeckel
On Fri, Jan 05, 2018 at 20:34:53 +0100, Sebastian Holtermann wrote: > 2) Use libuv instead libuv for process management is on the list. I think it is waiting for porting to all of CMake's platforms to actually happen. I'm seeing this PR hung up on process:

Re: [cmake-developers] Build failure due to {cd bindir} failed on Windows/Ninja

2018-01-01 Thread Ben Boeckel
On Fri, Dec 29, 2017 at 13:32:54 -0800, Jom O'Fisher wrote: > >> Ninja should be using relative paths for the build tree and absolute > for anything outside of it. > That appears to be the case, so I need a better theory. I noticed another > difference between compilation phase and link phase. The

Re: [cmake-developers] Build failure due to {cd bindir} failed on Windows/Ninja

2017-12-29 Thread Ben Boeckel
On Thu, Dec 28, 2017 at 12:51:20 -0800, Jom O'Fisher wrote: > (1) Invoke cmake to generate ninja project. Success. > * Note that generated rules.ninja has .o compilation dependencies with > absolute paths and .so link dependencies with relative paths. Ninja should be using relative paths for the

Re: [cmake-developers] PLplot contract test

2017-11-08 Thread Ben Boeckel
On Wed, Nov 08, 2017 at 12:39:15 -0800, Alan W. Irwin wrote: > software@raven> time (nice -19 ctest -S > ~/cmake/Dashboards/Scripts/CMakeScripts/my_dashboard.cmake -VV >& ctest.out16) > X11 connection rejected because of wrong authentication. > X11 connection rejected because of wrong

Re: [cmake-developers] CMake PCH Prototype

2017-09-05 Thread Ben Boeckel
On Sat, Sep 02, 2017 at 12:15:28 +0200, Máté Ferenc Nagy-Egri via cmake-developers wrote: > Do I understand correctly, that this work is not going to be > mainlined? I was very much hoping it would. Development stalled. We close MRs which need work and haven't been actively developed in order to

Re: [cmake-developers] C++11 all features available?

2017-08-21 Thread Ben Boeckel
On Mon, Aug 21, 2017 at 15:53:11 +0200, Sebastian Holtermann wrote: > - std::array I don't see why not. > - std::basic_regex (and friends) Note that we require backwards compat with the old regex engine, so this one needs to be used carefully and only on internal uses. > - std::thread (and

Re: [cmake-developers] List of commands

2017-08-17 Thread Ben Boeckel
On Thu, Aug 17, 2017 at 14:34:27 -0300, Ivam Pretti wrote: > Hi there I am new at coding with cmake and I would like to know if there is > a list of commands avaiable. Thanks anyway. The cmake-commands(7) manpage has a listing of the builtin commands. They're also available in the HTML

Re: [cmake-developers] Undocumented change in behavior in cmake 3.9.X (SWIG)

2017-08-17 Thread Ben Boeckel
On Thu, Aug 17, 2017 at 17:41:35 +0930, Simon Lees wrote: > We at openSUSE have noticed a change in behavior presumably in > swig_link_libraries in one package cproton_perl.so is now being > generated rather then libcproton_perl.so I presume the lines generating > the library are below (I am not

Re: [cmake-developers] Future of ccmake and cmake-gui

2017-08-17 Thread Ben Boeckel
On Wed, Aug 16, 2017 at 23:02:52 +0200, Jean-Michaël Celerier wrote: > @Ben Boeckel : > > The idea for process creation is to migrate to libuv once all of the > dependencies are supported. > Quick question : why not asio instead ? it's bound to end up in the > standard library

Re: [cmake-developers] Future of ccmake and cmake-gui

2017-08-16 Thread Ben Boeckel
On Wed, Aug 16, 2017 at 09:16:24 -0700, Eric Wing wrote: > It has native backends for Windows, GTK2, GTK3, Motif, Haiku. Because > it historically didn't have a Mac OS X backend, most people overlooked > it. However...I've been implementing a native Mac OS X backend. It's > not finished, but there

Re: [cmake-developers] Future of ccmake and cmake-gui

2017-08-16 Thread Ben Boeckel
On Tue, Aug 15, 2017 at 22:33:04 +0200, Daniel Pfeifer wrote: > With !977 merged, it is possible to base ccmake and cmake-gui on top of the > cmake server. > For demonstration, I copied the contents of the Source/CursesDialog > directory and added a proxy implementation of the classes `cmake` and

Re: [cmake-developers] Fwd: [CMake] cmake-gui on windows and qt5 dlls

2017-08-14 Thread Ben Boeckel
On Mon, Aug 14, 2017 at 20:09:17 +1000, Craig Scott wrote: > It shouldn't be an issue having non-static Qt libs linked to cmake-gui, but > as reported on the CMake users mailing list, it can be a problem when the > directory cmake-gui is in is on the PATH. If CMake's bin directory appears > on the

Re: [cmake-developers] Signing of DEB and RPM packages

2017-07-25 Thread Ben Boeckel
On Tue, Jul 25, 2017 at 17:43:03 +0200, Roman Wüger wrote: > is the signing of DEB packages (debsigs) and RPM packages (rpmsign or > rpm --addsign) supported at the moment? It doesn't appear to be supported right now (no results from grep'ing for "debsig" or "addsign"). --Ben -- Powered by

Re: [cmake-developers] FindPNG.cmake doesn't return a LIBRARY_DIR variable

2017-07-12 Thread Ben Boeckel
On Wed, Jul 12, 2017 at 14:22:40 +0200, Rolf Eike Beer wrote: > First, FindPNG.cmake doesn't care about pkg-config files, if that is bug > or feature depends on your personal things. CMake will detect the > library using the full path (as it has done), and construct proper -L > and -l from

Re: [cmake-developers] Making your regular expression engine more reliable

2017-05-19 Thread Ben Boeckel
On Thu, May 18, 2017 at 12:44:57 -0700, Alan W. Irwin wrote: > So your unit tests for regular expressions obviously missed at least > this issue. I have no idea what those unit tests are (or even if they > exist), but one possibility for attempting to wring most of the bugs out > of your regular

Re: [cmake-developers] Compile targets affected by changeset

2017-05-19 Thread Ben Boeckel
On Thu, May 18, 2017 at 17:48:26 -0400, Robert Patterson via cmake-developers wrote: > 'make' has a limitation where if 'make target1 target2 target3' is > invoked, target1, target2, and target3 are built serially, not in > parallel. Well, this makes sense since there's no `-j` flag given. Are

Re: [cmake-developers] Does JOB_POOL_[COMPILE|LINK] work with custom_target?

2017-05-15 Thread Ben Boeckel
On Mon, May 15, 2017 at 11:46:37 +0200, Eric Noulard wrote: > No answer whatsoever on this? I don't think it is supported right now. > I'd like to be able assign some custom targets to a ninja job pool. > If I were to implement the feature would it be acceptable upstream ? I think it'd be fine.

Re: [cmake-developers] Splitting CMakeLib

2017-05-10 Thread Ben Boeckel
On Wed, May 10, 2017 at 17:56:07 +0300, Egor Pugin wrote: > I'd like to re-use some CMake internal components, but CMakeLib looks too fat. > Is it possible to split it into several libraries? Are such changes > welcome to contribute? What is the use case? CMake does not ship an SDK to link

Re: [cmake-developers] Trouble with FindPNG module

2017-04-24 Thread Ben Boeckel
On Mon, Apr 24, 2017 at 19:58:52 +0100, Roger Leigh wrote: > While you can install as many of the runtime packages as you like, the > headers go into /usr/include and so they conflict with each other, > limiting you to a single development package at one time (checked the > behaviour to verify

Re: [cmake-developers] Trouble with FindPNG module

2017-04-24 Thread Ben Boeckel
On Mon, Apr 24, 2017 at 19:17:39 +0100, Roger Leigh wrote: > Sounds like that's exactly the problem. You can only have one libpng > *development* package installed at once. You probably want the regular > "libpng-dev" package installed if you want to build against the standard > libpng. Ah,

Re: [cmake-developers] Trouble with FindPNG module

2017-04-24 Thread Ben Boeckel
On Mon, Apr 24, 2017 at 12:20:27 -0500, Robert Dailey wrote: > -- The C compiler identification is GNU 4.9.4 > -- The CXX compiler identification is GNU 4.9.4 > -- Check for working C compiler: /usr/bin/gcc-4.9 > -- Check for working C compiler: /usr/bin/gcc-4.9 -- works > -- Detecting C compiler

Re: [cmake-developers] Trouble with FindPNG module

2017-04-24 Thread Ben Boeckel
On Mon, Apr 24, 2017 at 09:54:18 -0500, Robert Dailey wrote: > On Fri, Apr 21, 2017 at 4:48 PM, Robert Dailey > wrote: > > I'm running CMake 3.8.0 on Ubuntu 14. I invoke the following: > > > > find_package(PNG REQUIRED) > > > > Which gives me the output in CMake: > > >

Re: [cmake-developers] Support for unified headers in Android NDK

2017-04-20 Thread Ben Boeckel
On Thu, Apr 20, 2017 at 14:31:58 -0500, Robert Dailey wrote: > Google is supporting unified headers for sysroot as of NDK r14: > > https://android.googlesource.com/platform/ndk/+/master/docs/UnifiedHeaders.md > > Is there a plan to add support for this natively into CMake? There is a merge

Re: [cmake-developers] Feature suggestion: auto-create missing files

2017-04-12 Thread Ben Boeckel
On Tue, Apr 11, 2017 at 21:28:40 +0200, Alexander Neundorf wrote: > personally I'm not convinced. > Technically it would violate the "the source dir is read-only" rule. > A typo would generate files. With multiple build dirs the behaviour will be > slightly different in the two dirs. > ...not

Re: [cmake-developers] Feature suggestion: auto-create missing files

2017-04-11 Thread Ben Boeckel
On Tue, Apr 11, 2017 at 11:52:52 -0400, Brad King wrote: > If this were to be done I'd first like to see a policy introduced to > get rid of the magic extension guessing we do now. Without knowing > the full file name with confidence we wouldn't be able to create it. This is already an issue

Re: [cmake-developers] Debugger for CMake

2017-02-14 Thread Ben Boeckel
On Mon, Feb 13, 2017 at 20:18:02 -0700, Justin Berger wrote: > I agree on the maximizing code reuse, but that doesn't require them to use > the same operational mode -- the two modes do fundamentally different > things; even while sharing most internal components. Is the idea that you > could only

Re: [cmake-developers] Eclipse CDT Managed build

2017-01-26 Thread Ben Boeckel
On Thu, Jan 26, 2017 at 11:41:21 -0500, Paul Smith wrote: > IMO the right place for managing relocatable builds is in the > compiler/linker, not in the build tool. This is about making the files CMake writes relocatable, not the resulting binaries. --Ben -- Powered by www.kitware.com Please

Re: [cmake-developers] Eclipse CDT Managed build

2017-01-25 Thread Ben Boeckel
On Wed, Jan 25, 2017 at 15:45:33 +, Bøe, Sebastian wrote: > Not modifying the CMakeListst.txt is acceptable for this use-case. > > But not being able to share, or relocate, the build tree is a problem. > > Would support for relocatable build trees need major changes throughout > CMake, or is

Re: [cmake-developers] Eclipse CDT Managed build

2017-01-25 Thread Ben Boeckel
On Wed, Jan 25, 2017 at 14:51:26 +, Bøe, Sebastian wrote: > But in this use-case CMake would only be run once and then the > IDE project would take over project configuration for the rest > of the application lifetime. CMake does not generally create relocatable build trees, so you cannot

Re: [cmake-developers] Eclipse CDT Managed build

2017-01-25 Thread Ben Boeckel
On Wed, Jan 25, 2017 at 14:31:32 +, Bøe, Sebastian wrote: > I was wondering if anyone has given thought to if > it is feasible to have generator support for Eclipse CDT > Managed builds? It would likely be possible, but I don't know of any work towards this goal. > My motivation for managed

Re: [cmake-developers] [PATCH] CMAKE_DL_LIBS: fix typo

2017-01-23 Thread Ben Boeckel
On Sat, Jan 21, 2017 at 01:51:15 +, Thiago Perrotta wrote: > Since this is a very small fix (literally just one character) and this is > my first patch here, I didn't bother to read the instructions for > contributing / submitting patches. Therefore, feel free to use this patch > according to

Re: [cmake-developers] Requesting Advice: Installing object files

2017-01-18 Thread Ben Boeckel
On Wed, Jan 18, 2017 at 11:47:42 -0800, Chris Bieneman wrote: > On Jan 18, 2017, at 5:58 AM, Ben Boeckel <ben.boec...@kitware.com> wrote: > > Plus our plan for installing OBJECT libraries was to install them as > > INTERFACE libraries, leaving the objects themse

Re: [cmake-developers] Requesting Advice: Installing object files

2017-01-18 Thread Ben Boeckel
On Wed, Jan 18, 2017 at 10:14:26 +0100, Nils Gladitz wrote: > On 17.01.2017 23:25, Chris Bieneman wrote: > > Hello CMake-developers! > > > > In one of the LLVM sub-projects we have a problem where we need to > > install object files, which doesn't seem like a particularly easy > > task. I'm

Re: [cmake-developers] COMPILE_FEATURES, Mac and non-Apple clang versions

2017-01-04 Thread Ben Boeckel
On Wed, Jan 04, 2017 at 12:12:46 +1100, Craig Scott wrote: > We have many projects which do exactly the scenario you mention above where > a project can be built standalone or added to another project via > add_subdirectory(). We have not found it necessary to test if a project is > top level or

Re: [cmake-developers] import another compiler to cmake

2016-12-21 Thread Ben Boeckel
On Wed, Dec 21, 2016 at 13:00:29 +0100, Payam Samimi wrote: > I'm working for a big company in Germany as software developer. They > develope their code and test modules in c++ and using CMake. Additionally > they use their own compiler which is company specific and they would like > import or

Re: [cmake-developers] not able to push topic to stage

2016-12-20 Thread Ben Boeckel
On Tue, Dec 20, 2016 at 17:50:02 +0100, Domen Vrankar wrote: > Has anything changed regarding how topics should be pushed to stage and > then to next for testing? > > When following what's written here: https://cmake.org/Wiki/CMake/Git/Develop > I get a git hook error: > > remote: >

Re: [cmake-developers] Add native options to the clean step of 'cmake --build .. --clean-first'

2016-12-16 Thread Ben Boeckel
On Fri, Dec 16, 2016 at 09:46:22 +0100, Yves Frederix wrote: > Although I am not fully convinced that the above might actually happen > in 'normal' practice, I do agree that it is a risk that should not be > introduced simply to get less verbose output for the clean step (my > use case). Pulling

Re: [cmake-developers] CMake vs libtool versioning of shared libraries

2016-12-15 Thread Ben Boeckel
On Thu, Dec 15, 2016 at 14:08:35 -0500, Brad King wrote: > On 12/15/2016 01:57 PM, Kim Walisch wrote: > > Lets suppose I do not want to stick to my previous libtool versioning > > but instead version my library according to cmake best practices. How > > should I set VERSION and SOVERSION given my

Re: [cmake-developers] Add native options to the clean step of 'cmake --build .. --clean-first'

2016-12-15 Thread Ben Boeckel
On Wed, Dec 14, 2016 at 21:26:13 +0100, Yves Frederix wrote: > In PR https://gitlab.kitware.com/cmake/cmake/merge_requests/329 I am > suggesting to not only pass the additional/native build options to the > actual build step, but also to the 'clean' step in case of a call like > `cmake --build ...

Re: [cmake-developers] Specifying sources without file extensions

2016-12-08 Thread Ben Boeckel
On Thu, Dec 08, 2016 at 08:01:03 -0500, Brad King wrote: > On 12/08/2016 01:41 AM, Craig Scott wrote: > > file names without extensions is a feature which is simply missing > > documentation or is it an undocumented feature that projects are not > > supposed to use? Since there are error messages

Re: [cmake-developers] Developer workflow with gitlab

2016-10-31 Thread Ben Boeckel
On Mon, Oct 31, 2016 at 19:26:19 +0100, Gregor Jasny via cmake-developers wrote: > I wonder what's the recommended workflow for CMake developers with > commit access to stage? I'd like to use feature branches in gitlab but > wonder how those are best merged into 'next'? > > Could you please

Re: [cmake-developers] Java_INCLUDE_DIRS not populated by FindJava.cmake

2016-10-17 Thread Ben Boeckel
On Mon, Oct 17, 2016 at 15:32:06 +1100, Craig Scott wrote: > In case anyone is wondering, the use case for me is when implementing a > SWIG custom command to generate java wrappers, the jni.h header needs to be > found by the generated sources. There's FindJNI for that. --Ben -- Powered by

Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

2016-08-25 Thread Ben Boeckel
On Tue, Aug 23, 2016 at 08:00:09 +0200, Rolf Eike Beer wrote: > Am Dienstag, 23. August 2016, 10:06:01 schrieb Craig Scott: > > So how would you want the feature to work? I'd suggest an initial set of > > requirements something like the following: > > > >- Need to support the ability to

Re: [cmake-developers] [PATCH] Use full path for all source files in ninja build.

2016-08-08 Thread Ben Boeckel
On Sun, Aug 07, 2016 at 04:54:52 +0200, Florent Castelli wrote: > I'd say that you shouldn't do this unless you have tested it extensively > with very long command lines, making sure that there is a response file > fallback if it grows too much. > There are issues in CMake already on Windows

Re: [cmake-developers] [PATCH] Use full path for all source files in ninja build.

2016-08-03 Thread Ben Boeckel
On Wed, Aug 03, 2016 at 11:11:45 -0700, Chaoren Lin wrote: > Also, in the case of vim, the makeprg is user-supplied, so vim has no idea > that it contains a path. What about instead of "cd path && ninja", using "ninja -C path"? --Ben -- Powered by www.kitware.com Please keep messages on-topic

Re: [cmake-developers] [PATCH] Use full path for all source files in ninja build.

2016-08-02 Thread Ben Boeckel
On Tue, Aug 02, 2016 at 11:11:44 -0700, Chaoren Lin via cmake-developers wrote: > Similarly, the :make command in vim will have no knowledge of build.gradle, > and only tries to parse the build errors directly. FWIW, I haven't encountered any problems with Vim's :make with CMake's generated Ninja

Re: [cmake-developers] Strange behaviour with check_library_exists on Windows

2016-07-28 Thread Ben Boeckel
On Thu, Jul 28, 2016 at 13:33:35 +0300, Sergei Nikulov wrote: > -- Looking for CertFreeCertificateContext in crypt32; > -- Looking for CertFreeCertificateContext in crypt32; - found > crypt32 found These are tested using try_compile. Is there anything interesting under CMakeFiles/CMakeTmp/* when

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Ben Boeckel
On Wed, Jul 27, 2016 at 17:49:40 +0200, Sebastian Holtermann wrote: > Is there an error exit function in CMake? > Or just exit(-1); Here's an example I found: this->Makefile->IssueMessage( cmake::INTERNAL_ERROR, "fileFound is true but FileFound is empty!"); after that, it is treated

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Ben Boeckel
On Tue, Jul 26, 2016 at 23:38:34 +0200, Sebastian Holtermann wrote: > Doing so I found that Base64 allows '+' and '/' as characters which is > bad for directory names obviously. > For now these characters get replaced with 'A' and 'B'. '_' and '@' would be better replacements (with comments why

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Ben Boeckel
On Tue, Jul 26, 2016 at 17:31:00 +0200, Sebastian Holtermann wrote: > I have prepared an other approach which uses checksum suffixes > instead of nested directory generation. > This was tested on my Debian/amd64/Makefile setup. Interesting; I like it. Might be worthwhile to reuse it for the .o

Re: [cmake-developers] [PATCH] Discussion needed: FindBISON: refine VERBOSE feature of BISON_TARGET

2016-07-15 Thread Ben Boeckel
On Fri, Jul 15, 2016 at 10:52:23 -0400, Brad King wrote: > On 07/15/2016 10:45 AM, Eon Jeong wrote: > > I considered that way, but doing this can't figure "VERBOSE" used > > without from never used. same empty string value. > > You could hack it with something like > > if("${ARGN}" MATCHES

Re: [cmake-developers] Don't enclose CMake version to generated files

2016-07-11 Thread Ben Boeckel
On Mon, Jul 11, 2016 at 17:16:22 +0200, Christoph Grüninger wrote: > this comes from the open build system, which is the system used by > openSuse to generate the packages. If the CMake version is updated, > which happens quite often, the generated files are altered and the > packages are rebuild,

Re: [cmake-developers] Don't enclose CMake version to generated files

2016-07-11 Thread Ben Boeckel
On Sun, Jul 10, 2016 at 15:35:24 +0200, Christoph Grüninger wrote: > I just updated openSuse's CMake package. We have a patch, that removes > the CMake version from generated files. This is aiming to reduce the > re-publishing of generated files. Please find the current patch attached. > What do

Re: [cmake-developers] [patch] One more pattern for extracting file name from URL

2016-07-05 Thread Ben Boeckel
On Tue, Jul 05, 2016 at 13:46:06 -0400, Brad King wrote: > On 07/05/2016 01:31 PM, Ben Boeckel wrote: > > Here's another idea: add an `OUTPUT_FILE ` keyword argument to > > `file(DOWNLOAD)` to get the actual filename after content disposition > > resolution (probably sim

Re: [cmake-developers] [patch] One more pattern for extracting file name from URL

2016-07-05 Thread Ben Boeckel
On Tue, Jul 05, 2016 at 21:01:36 +0300, Ruslan Baratov wrote: > Well it's never too late to learn something new. Also `tar` is not > widely used on Windows so to write nice code you should convert it to > `cmake -E tar`. That the whole point of `cmake -E` feature. > I don't see the problem here,

Re: [cmake-developers] [patch] One more pattern for extracting file name from URL

2016-07-05 Thread Ben Boeckel
On Tue, Jul 05, 2016 at 19:49:46 +0300, Ruslan Baratov wrote: > Archive can be unpacked by "cmake -E tar xf" which detect type > automatically as far as I understand. At least this one used internally > by ExternalProject (see the testing I've made before). CMake is not my go-to tool for

Re: [cmake-developers] [patch] One more pattern for extracting file name from URL

2016-07-05 Thread Ben Boeckel
On Tue, Jul 05, 2016 at 18:43:25 +0300, Ruslan Baratov wrote: > By default not, goes to -prefix/src/archive.tar . Right, but if a download directory is set, this won't work. Can the project name at least be added to the name? Though I'm partial to keeping the extension still; if I need to add a

Re: [cmake-developers] [patch] One more pattern for extracting file name from URL

2016-07-05 Thread Ben Boeckel
On Tue, Jul 05, 2016 at 16:26:54 +0300, Ruslan Baratov via cmake-developers wrote: > + # Do not put warning message here. If everything works OK it will > + # only distract. If unpack will fail the standard name can be > found in logs. > + # (see

Re: [cmake-developers] [patch] One more pattern for extracting file name from URL

2016-07-01 Thread Ben Boeckel
On Fri, Jul 01, 2016 at 18:48:41 +0300, Ruslan Baratov wrote: > On 01-Jul-16 16:04, Ben Boeckel wrote: > > On Fri, Jul 01, 2016 at 08:58:16 -0400, Brad King wrote: > >> Also, the `([^/]*)\\?.*` part of the regex should be more > >> like `([^/?]*)\\?.*` to a

Re: [cmake-developers] [PATCH] Improve encoding handling on Windows

2016-07-01 Thread Ben Boeckel
On Fri, Jul 01, 2016 at 16:44:32 +0300, Dāvis Mosāns wrote: > 2. change GetEnv to return std::unique_ptr which will be > automatically deleted once out of scope and we still can check if there > wasn't such env if it's empty. Hrm. I'd rather use std::optional than relying on implicit nullptr

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Ben Boeckel
On Wed, Jun 29, 2016 at 17:36:45 +0200, Farbos a wrote: > I have a concern with generating package configs: > > 1 It seems to contain absolute path, so not really portable with git. The actual config files are generated at build time, not committed to the source control (template files with

Re: [cmake-developers] [CMake] [iOS] What is the correct way to add resources to an XCode project

2016-06-29 Thread Ben Boeckel
On Wed, Jun 29, 2016 at 16:48:10 +0200, Roman Wüger wrote: > I know because I wrote this ticket. Ah. I didn't check the Mantis side. > I thought this was "closed/want fixed" because of the implementation > for RESOURCE a few days ago. Hmm. I don't see that. Do you have a link? --Ben --

Re: [cmake-developers] Script to update liblzma from upstream.

2016-06-29 Thread Ben Boeckel
On Wed, Jun 29, 2016 at 09:06:25 -0400, Brad King wrote: > If there is a developer mailing list I typically use that. > Otherwise I use kwrobot. Ah, makes sense. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ

Re: [cmake-developers] Script to update liblzma from upstream.

2016-06-29 Thread Ben Boeckel
On Tue, Jun 28, 2016 at 23:24:22 +0200, Daniel Pfeifer wrote: > I have attached a patch that adds a script to update liblzma from > upstream (closely modeled after the other update scripts). I am not > sure how these kinds of scripts need to be run. Thanks! Looks like Brad hadn't imported the

Re: [cmake-developers] [CMake] [iOS] What is the correct way to add resources to an XCode project

2016-06-29 Thread Ben Boeckel
On Tue, Jun 28, 2016 at 23:01:56 +0200, Roman Wüger wrote: > The target property RESOURCE does only allow files but no directories. There's an open issue for this: https://gitlab.kitware.com/cmake/cmake/issues/14743 --Ben -- Powered by www.kitware.com Please keep messages on-topic and

Re: [cmake-developers] adding FindJsonCpp

2016-06-29 Thread Ben Boeckel
On Wed, Jun 29, 2016 at 11:02:30 +0200, Farbos a wrote: > I would like to add a find module: FindJsonCpp.cmake that I attached. > the library github: https://github.com/open-source-parsers/jsoncpp. > > This library allows JSON manipulation. It's used by more than one > person and I think it could

Re: [cmake-developers] daemon-mode: Infrastructure

2016-06-23 Thread Ben Boeckel
On Tue, Jun 14, 2016 at 02:00:14 +0200, Tobias Hunger wrote: > Implementing new Protocol Versions: > == > Deprecating old Protocol Versions: > One idea that came up on a previous project was the following: namespace protocol {

Re: [cmake-developers] daemon-mode meeting last Tuesday

2016-06-23 Thread Ben Boeckel
On Thu, Jun 23, 2016 at 16:46:48 -0400, Brad King wrote: > On 06/23/2016 08:27 AM, Tobias Hunger wrote: > > * Figure out whether a PDB file is actually going to be build. Currently > > the PDB file is added to the list of artifacts whenever there is a .lib > > file, which is probably

Re: [cmake-developers] daemon-mode meeting last Tuesday

2016-06-23 Thread Ben Boeckel
On Thu, Jun 23, 2016 at 16:46:48 -0400, Brad King wrote: > On 06/23/2016 08:27 AM, Tobias Hunger wrote: > > * Some names could be improved. Suggestions welcome. > > We'll cover these in more detail during review. The most important name is > the name of the feature, and IMO "daemon" is not an

Re: [cmake-developers] Using a custom DSL compiler in CMake

2016-06-22 Thread Ben Boeckel
On Tue, Jun 21, 2016 at 16:05:47 -0400, Brad King wrote: > On 06/21/2016 02:18 PM, Chris Bieneman wrote: > > Our DSL compiler can generate .d files, but hooking that up to > > CMake is a harder problem. > > With some work it may be possible to teach our Ninja generator how > to consume .d files

Re: [cmake-developers] speed up package with mingw on Windows host

2016-06-20 Thread Ben Boeckel
On Mon, Jun 20, 2016 at 23:05:11 +0200, laurent wrote: > I mean dependencies will be marked as *analysed* at global scope. > > Is cpack able to pack 2 binaries at the same time ? Concurrently, no. In a single invokation, yes (though it is still just one package). > Maybe i could suffix

Re: [cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Ben Boeckel
On Fri, Jun 17, 2016 at 15:40:45 +0200, Nils Gladitz wrote: > I have not been involved in that development. > From what I can tell this is Eike's work. Ack, sorry. Should have double checked. --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at:

[cmake-developers] FindPkgConfig and IMPORTED_TARGET in 3.6.0

2016-06-17 Thread Ben Boeckel
Hi, Nils, the IMPORTED_TARGET feature in pkg_check_modules is nice! Thanks for that. However, it is hidden behind the check that pkg_check_modules uses to see if it already ran: if (NOT DEFINED __pkg_config_checked_${_prefix} OR __pkg_config_checked_${_prefix} LESS

Re: [cmake-developers] Possibly an obscure bug

2016-06-15 Thread Ben Boeckel
On Wed, Jun 15, 2016 at 21:34:27 +0300, Binkie Pinkie wrote: > build$ make > Scanning dependencies of target list > make[2]: Circular blink/CMakeFiles/list.dir/main.cpp.o <- blink/list > dependency dropped. > [ 50%] Building CXX object blink/CMakeFiles/list.dir/main.cpp.o > In file included from

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Ben Boeckel
On Mon, Jun 13, 2016 at 16:14:51 +0200, Daniel Pfeifer wrote: > On Mon, Jun 13, 2016 at 2:09 PM, Ben Boeckel <ben.boec...@kitware.com> wrote: > > Usually NULL means "unset". See properties, > > variable values, etc. As an output, any place which doesn't c

Re: [cmake-developers] Questions about coding conventions

2016-06-13 Thread Ben Boeckel
On Mon, Jun 13, 2016 at 00:03:29 +0200, Daniel Pfeifer wrote: > Can you show an example? To be clear: We are looking for a function, > that has a code path for `str == NULL` and a *different* codepath for > `str[0] = '\0'`. As input to functions? Usually NULL means "unset". See properties,

Re: [cmake-developers] Questions about coding conventions

2016-06-12 Thread Ben Boeckel
On Fri, Jun 10, 2016 at 15:30:05 +0200, Daniel Pfeifer wrote: > Passing and returning strings: We have `const char*`, `std::string`, > and `std::string const&`. Unifying this can affect performance. > Storing `const char*` in a `std::string` creates a (potentially > unneded) copy (assuming it is

Re: [cmake-developers] RFC: LLVM community CMake documentation

2016-06-09 Thread Ben Boeckel
On Thu, Apr 28, 2016 at 14:16:40 -0700, Chris Bieneman wrote: > The only comment I think I didn’t directly update the document for was > Dan’s comment about GLOBAL properties. I kinda have mixed feelings > about GLOBAL properties. I know why we use them, but I’m not sure I > want to encourage

Re: [cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-09 Thread Ben Boeckel
On Wed, Jun 08, 2016 at 10:12:13 -0400, Brad King wrote: > Side note: This is another thing that should be cleaned up in the Ninja > generator. It should hold target-wide flags in the per-target rules.ninja > entries instead of duplicating them for every object file in build.ninja. > That would

Re: [cmake-developers] Suggest if function has lte gte operators

2016-04-08 Thread Ben Boeckel
On Fri, Apr 08, 2016 at 14:24:08 +, Harry Mallon wrote: > CMake's "if" functionality is missing greater than or equal to and > less than or equal to. This change could be tweaked and added to > provide this functionality to avoid things like "if(VERSION_STRING > VERSION_GREATER "4.8.0" OR

Re: [cmake-developers] ninja/make compilation response file

2016-04-04 Thread Ben Boeckel
On Mon, Apr 04, 2016 at 15:59:30 +, Dmitry Ivanov wrote: > We have a strange situation where we do have too many include paths, > which makes command line for obj compilation too long on windows (more > 32kb). > I've tried using set(CMAKE_NINJA_FORCE_RESPONSE_FILE 1), but > apparently after

Re: [cmake-developers] [PATCH] Fix CMAKE_Fortran_PLATFORM_ID on mingw-w64

2016-04-04 Thread Ben Boeckel
On Mon, Apr 04, 2016 at 09:07:09 +, melven.roehrig-zoell...@dlr.de wrote: > After thinking about my patch I worried it could break other compilers. > So, here is a more defensive version that shouldn't interfere with anything > else. > > Explanation: > CMAKE_Fortran_COMPILER_ID was correctly

  1   2   3   >