Re: [cmake-developers] adding FindJsonCpp

Hi, 2016-06-29 19:31 GMT+02:00 Ben Boeckel <ben.boec...@kitware.com>: > On Wed, Jun 29, 2016 at 17:36:45 +0200, Farbos a wrote: >> I have a concern with generating package configs: >> >> 1 It seems to contain absolute path, so not really portable with git.

[cmake-developers] adding FindJsonCpp

, -- Arnaud FARBOS FindJsonCpp.cmake Description: Binary data -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please

[cmake-developers] handling components in Find****

Hi, I am trying to write a Find module with components and I am not sure of how it should be written. I attached the find module, Could someone tell me if I did it well? Thanks, -- Arnaud FARBOS FindILMBase.cmake Description: Binary data -- Powered by www.kitware.com Please keep messages

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

I am not sure to understand why you removed GLEW_LIBRARY: -mark_as_advanced(GLEW_INCLUDE_DIR GLEW_LIBRARY) +mark_as_advanced(GLEW_INCLUDE_DIR) 2016-06-20 21:09 GMT+02:00 Brad King <brad.k...@kitware.com>: > On 06/20/2016 10:52 AM, Farbos a wrote: >> Here is the patch fixed. >

Re: [cmake-developers] [PATCH] add debug glew to FindGLEW

Brad, Here is the patch fixed. Thanks, 2016-06-20 16:17 GMT+02:00 Brad King <brad.k...@kitware.com>: > On 06/20/2016 07:55 AM, Farbos a wrote: >> I added the Glew debug library to the FindGLEW.cmake, here is the patch. > > Good start. Here are some comments: &g

[cmake-developers] [PATCH] add debug glew to FindGLEW

Hi, I added the Glew debug library to the FindGLEW.cmake, here is the patch. Tell me if everything looks good and if I can do a pull request. Thanks, -- Arnaud FARBOS 0001-add-debug-glew-to-FindGLEW.patch Description: Binary data -- Powered by www.kitware.com Please keep messages on-topic