Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-23 Thread Martin Ankerl
Thanks for the feedback! Here is an updated patch that uses a hash as filename, .cmd as extension, boolean argument, and some error checks. Martin On Fri, May 20, 2016 at 3:40 PM Brad King <brad.k...@kitware.com> wrote: > On 05/20/2016 03:41 AM, Martin Ankerl wrote: > > F

Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-20 Thread Martin Ankerl
sorry, that DEP_FILE problem was my fault. It's working correctly. Martin On Fri, May 20, 2016 at 9:41 AM Martin Ankerl <martin.ank...@gmail.com> wrote: > From what I have understood it seems more safe to use .bat and not .cmd, > because the behavior of the errorlevel is different.

Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-20 Thread Martin Ankerl
te: > On 05/19/2016 04:31 PM, Martin Ankerl wrote: > > I didn't think about just writing a .cmd (or .bat?) with cmake > > The ".cmd" extension is a modern version of ".bat". > > > that sounds like the simplest solution! > > Yes, assuming we never

Re: [cmake-developers] Custom commands with Ninja on Windows

2016-05-19 Thread Martin Ankerl
th cmake implementation though, how would you find a name for the filename? Martin On Thu, May 19, 2016 at 4:03 PM Brad King <brad.k...@kitware.com> wrote: > On 05/19/2016 01:43 AM, Martin Ankerl wrote: > > It seems to me that there are two possible solution: > > >

[cmake-developers] Custom commands with Ninja on Windows

2016-05-18 Thread Martin Ankerl
Hi! I've run into the same problem with many custom commands as discussed here: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/13434 Which is referenced in this bug report: https://cmake.org/Bug/view.php?id=15612#c38924 I've had a look at this problem because this is the only