Re: [cmake-developers] Generator options per-directory v. global

2016-10-06 Thread Stephen Kelly
Brad King wrote: > On 10/05/2016 06:38 PM, Stephen Kelly wrote: >> The suggestion to use the first cmMakefile for these kinds of definitions >> is a good one >> >> 1) It can be documented that the variable can only be set in the top >> level 2) It is what people already do probably >> 3) It is

Re: [cmake-developers] Generator options per-directory v. global

2016-10-06 Thread Brad King
On 10/05/2016 06:38 PM, Stephen Kelly wrote: > The suggestion to use the first cmMakefile for these kinds of definitions is > a good one > > 1) It can be documented that the variable can only be set in the top level > 2) It is what people already do probably > 3) It is more convenient than the

Re: [cmake-developers] Generator options per-directory v. global

2016-10-05 Thread Stephen Kelly
Craig Scott wrote: > I'm coming in half way to this discussion, so apologies if my comments > interspersed below are not so well related to the core topic of > discussion. Hi Craig, Thanks for your input. > Consider the following example which perhaps better shows that this > problem may not

Re: [cmake-developers] Generator options per-directory v. global

2016-10-05 Thread Craig Scott
I'm coming in half way to this discussion, so apologies if my comments interspersed below are not so well related to the core topic of discussion. On Thu, Oct 6, 2016 at 9:38 AM, Stephen Kelly wrote: > Brad King wrote: > > > The scoping doesn't > > match the generator

Re: [cmake-developers] Generator options per-directory v. global (was: CMake 3.7.0-rc1 now ready for testing!)

2016-10-05 Thread Brad King
On 10/04/2016 05:46 PM, Stephen Kelly wrote: > This causes problems because now the code has to read the value for each > directory and can't assume that the value is always the same as the value > from the top-level CMakeLists file. Many of these are honored only in the top-level directory