Re: [cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-09 Thread Brad King
On 06/09/2016 11:28 AM, Ben Boeckel wrote: > On Wed, Jun 08, 2016 at 10:12:13 -0400, Brad King wrote: >> Side note: This is another thing that should be cleaned up in the Ninja >> generator. It should hold target-wide flags in the per-target rules.ninja >> entries instead of duplicating them for

Re: [cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-09 Thread Ben Boeckel
On Wed, Jun 08, 2016 at 10:12:13 -0400, Brad King wrote: > Side note: This is another thing that should be cleaned up in the Ninja > generator. It should hold target-wide flags in the per-target rules.ninja > entries instead of duplicating them for every object file in build.ninja. > That would

Re: [cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-08 Thread Brad King
Hi Tobias, So it looks like I was completely wrong in pointing you at GetTargetFlags to get compiler flags. It is indeed for linker flags. On 06/08/2016 04:23 AM, Tobias Hunger wrote: > what use is the "flags" out-parameter in cmLocalGenerator::GetTargetFlags? It > is > only ever set for

[cmake-developers] cmLocalGenerator::GetTargetFlags

2016-06-08 Thread Tobias Hunger
Hi everybody, what use is the "flags" out-parameter in cmLocalGenerator::GetTargetFlags? It is only ever set for targets of type EXECUTABLE and is filled based on the *linker language* of the target. I really do not see any use for this information, and indeed the flag seems unused in the cmake