On 09/18/2015 02:24 PM, Brad King wrote:
> After working out the support for manifests across all generators
> as discussed elsewhere in this thread, I've added your manifest
> file to CMake's own build:
>
> Windows: Fix CMAKE_HOST_SYSTEM_VERSION on Windows >= 8 (#15674)
>
On 09/18/2015 02:58 PM, James Johnston wrote:
> While on the subject, there are some other additions to the manifest you
> might want to consider.
I think these are worth considering but we're too close to the 3.4 freeze
to make these changes now. Please look at adding these during post-3.4
> -Original Message-
> From: cmake-developers [mailto:cmake-developers-boun...@cmake.org]
> On Behalf Of Brad King
> Sent: Friday, September 18, 2015 18:24
> To: Gilles Khouzam
> Cc: cmake-developers@cmake.org
> Subject: Re: [cmake-developers] [PATCH] [CMake 0015674]:
Great. Thanks
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Friday, September 18, 2015 11:24
To: Gilles Khouzam
Cc: cmake-developers@cmake.org
Subject: Re: [PATCH] [CMake 0015674]: Windows: Correctly determine Windows
version
On
On 09/10/2015 07:24 PM, Gilles Khouzam wrote:
> This patch adds a simple version manifest Source\cmake.version.manifest
> to the CMake executables.
After working out the support for manifests across all generators
as discussed elsewhere in this thread, I've added your manifest
file to CMake's own
On 09/10/2015 07:24 PM, Gilles Khouzam wrote:
> This patch fixes the issue where on Windows 8 and above, by
> default the system version returned is always Windows 8.
>
> In order for GetVersionEx to work properly, a manifest must be
> embedded in the exe telling it to ignore the new behavior and
mailto:cmake-developers-boun...@cmake.org] On Behalf
Of Gilles Khouzam
Sent: Thursday, September 10, 2015 23:25
To: Brad King
Cc: cmake-developers@cmake.org
Subject: [cmake-developers] [PATCH] [CMake 0015674]: Windows: Correctly
determine Windows version
This patch fixes the issue where on Windows
This patch fixes the issue where on Windows 8 and above, by default the system
version returned is always Windows 8.
More info on this can be found on
http://blogs.msdn.com/b/cjacks/archive/2009/03/27/manifesting-for-compatibility-on-windows-7.aspx
In order for GetVersionEx to work properly, a