[cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Adam Strzelecki
It makes whole executable process quicker on UNIX, especially for large bundles containing many files, since using find narrows results to only files having executable flags then all further tests follow. --- Modules/BundleUtilities.cmake | 19 ++- 1 file changed, 18

Re: [cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Brad King
On 09/04/2014 11:15 AM, Rolf Eike Beer wrote: I wonder if the right solution would instead be to add some additional flags to GLOB/GLOB_RECURSE where one could e.g. specify that the file is executable, or is a directory. That would be useful functionality regardless of this application.

Re: [cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Adam Strzelecki
On 09/04/2014 11:15 AM, Rolf Eike Beer wrote: I wonder if the right solution would instead be to add some additional flags to GLOB/GLOB_RECURSE where one could e.g. specify that the file is executable, or is a directory. That would be useful functionality regardless of this application.

Re: [cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Brad King
On 09/04/2014 12:43 PM, Adam Strzelecki wrote: Generally specifying UNIX mask for present/missing bits Rather than trying to do this with file(GLOB), perhaps we should consider a file(FIND) command for this purpose. It could have more options, including pattern matching, and eventually

Re: [cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Bill Hoffman
On 9/4/2014 12:49 PM, Brad King wrote: On 09/04/2014 12:43 PM, Adam Strzelecki wrote: Generally specifying UNIX mask for present/missing bits Rather than trying to do this with file(GLOB), perhaps we should consider a file(FIND) command for this purpose. It could have more options, including

Re: [cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Adam Strzelecki
I would be concerned with the portability of the arguments to find. find DIR -perm +FLAGS is part of POSIX/SUS http://pubs.opengroup.org/onlinepubs/007904875/utilities/find.html I guess it exists on systems dated 199x. How much faster is this? With CMake.app build, about 50x. Really going

Re: [cmake-developers] [PATCH 1/6] Use find on UNIX for fast executable lookup

2014-09-04 Thread Bill Hoffman
On 9/4/2014 1:43 PM, Adam Strzelecki wrote: First of all, it looks if find exists on system, otherwise it falls back to old (slow) behavior. So find is optional dependency. My main concern is that it finds a find that does not work as you expect. Also, if it were done in C++ it would