On 11/18/2014 10:34 AM, Gregor Jasny wrote:
Changes compared to v4:
* Use new style error reporting in cmContinueCommand.cxx
* Reject any given arguments to continue()
* CMP0055: Reject any arguments to break, too.
I put both checks: the loop block check and the empty arguments
check into
Hello,
Changes compared to v4:
* Use new style error reporting in cmContinueCommand.cxx
* Reject any given arguments to continue()
* CMP0055: Reject any arguments to break, too.
I put both checks: the loop block check and the empty arguments
check into the same policy. Please drop me a note if
On 11/18/2014 10:34 AM, Gregor Jasny wrote:
Changes compared to v4:
* Use new style error reporting in cmContinueCommand.cxx
* Reject any given arguments to continue()
* CMP0055: Reject any arguments to break, too.
Thanks. I'll try this series out when I get a chance.
I put both checks:
On Tue, Nov 18, 2014 at 16:34:28 +0100, Gregor Jasny wrote:
Changes compared to v4:
* Use new style error reporting in cmContinueCommand.cxx
* Reject any given arguments to continue()
* CMP0055: Reject any arguments to break, too.
Untested, but from a (very) quick skim, I don't see anything
On 18/11/14 17:19, Ben Boeckel wrote:
On Tue, Nov 18, 2014 at 16:34:28 +0100, Gregor Jasny wrote:
Changes compared to v4:
* Use new style error reporting in cmContinueCommand.cxx
* Reject any given arguments to continue()
* CMP0055: Reject any arguments to break, too.
I wonder if we should
On Tue, Nov 18, 2014 at 18:06:30 +0100, Gregor Jasny wrote:
On 18/11/14 17:19, Ben Boeckel wrote:
I wonder if we should
fix anything about it and if so, make continue behave in an analogous
way
You want to make continue() bug compatible to break()?
There are two parts here:
1) is
Putting continue, break or return inside of a macro definition is a
practice that should itself be discouraged...
(I know, people will probably still have cases of it, but it doesn't
seem like that's what any sane person would label a good practice, let
alone a best practice...)
On Tue, Nov 18,
Am Dienstag, 18. November 2014, 12:31:15 schrieb Ben Boeckel:
On Tue, Nov 18, 2014 at 18:06:30 +0100, Gregor Jasny wrote:
On 18/11/14 17:19, Ben Boeckel wrote:
I wonder if we should
fix anything about it and if so, make continue behave in an analogous
way
You want to make
