On 07/09/2014 02:02 PM, Tim Blechmann wrote:
attached!
Applied, thanks:
OS X: Install CFBundles as complete directories
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=908433bd
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
attached!
Applied, thanks:
OS X: Install CFBundles as complete directories
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=908433bd
thanks a lot! i wonder: will this patch make it into 3.0.1?
tim
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ
On 07/10/2014 11:48 AM, Tim Blechmann wrote:
thanks a lot! i wonder: will this patch make it into 3.0.1?
Sure. I rebased the commit back on 3.0.0:
OS X: Install CFBundles as complete directories
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a3ac67cc
-Brad
--
Powered by
cfbundles are currently not installed as directory, but the binary from
Contents/MacOS is directly installed to the destination.
attached patch fixes the issue.
thanks,
tim
From b021da36ec9c72cc6410a95ce81a177a87f6f232 Mon Sep 17 00:00:00 2001
From: Tim Blechmann t...@klingt.org
Date: Wed, 9 Jul
On 07/09/2014 09:40 AM, Tim Blechmann wrote:
cfbundles are currently not installed as directory, but the binary from
Contents/MacOS is directly installed to the destination.
attached patch fixes the issue.
Thanks.
I do not understand this line:
+ std::string targetNameBase =
On Wed, Jul 09, 2014 at 11:09:01 -0400, Brad King wrote:
+ std::string targetNameBase = targetName.substr(0,
targetName.find_first_of(/));
Not that this is performance-sensitive region, but in the pursuit
removing bad patterns to avoid copy/paste issues in the future:
std::string
cfbundles are currently not installed as directory, but the binary from
Contents/MacOS is directly installed to the destination.
attached patch fixes the issue.
Thanks.
I do not understand this line:
+ std::string targetNameBase = targetName.substr(0,
On 07/09/2014 11:30 AM, Tim Blechmann wrote:
Why do we need to look for the first slash?
targetName is:
${BundleName}${BundleExtension}/Contents/MacOS/${BundleName}
Okay, thanks.
Those cases do special handling for the post-installation tweaks.
i wonder: which tweaks are they?
It's
Those cases do special handling for the post-installation tweaks.
i wonder: which tweaks are they?
It's things like running strip on the executable file.
The line
filesTo.push_back(to1);
needs to add the path to the executable file, not the directory.
The filesTo vector is
On 07/09/2014 11:52 AM, Tim Blechmann wrote:
shall i update the patch?
Yes, so that we know the updated version works for what you need.
Please also include a change to use Ben's suggestion of
targetName.find('/')
instead of find_first_of.
Thanks,
-Brad
--
Powered by www.kitware.com
shall i update the patch?
Yes, so that we know the updated version works for what you need.
Please also include a change to use Ben's suggestion of
targetName.find('/')
instead of find_first_of.
attached!
thanks a lot,
tim
From 18147876fd834a24dcdeca70078c972f84e92866 Mon Sep 17
11 matches
Mail list logo