Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-14 Thread Peter Collingbourne
On Wed, Nov 05, 2014 at 06:35:25PM -0500, Ben Boeckel wrote: > On Wed, Nov 05, 2014 at 15:03:02 -0800, Peter Collingbourne wrote: > > On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: > > > For the testing of it, since only Ninja supports it, maybe it would be > > > possible to run a pro

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Ben Boeckel
On Wed, Nov 05, 2014 at 15:03:02 -0800, Peter Collingbourne wrote: > On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: > > For the testing of it, since only Ninja supports it, maybe it would be > > possible to run a program which exits testing for isatty(STDIN_FILENO) > > or isatty(STDOU

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Peter Collingbourne
On Wed, Nov 05, 2014 at 04:49:52PM -0500, Ben Boeckel wrote: > On Wed, Nov 05, 2014 at 13:12:13 -0800, Peter Collingbourne wrote: > > I've added documentation and tests and addressed Ben's comments, and > > published > > the staging branch 'console-pool'. PTAL. > > Thanks for splitting the commit

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Ben Boeckel
On Wed, Nov 05, 2014 at 13:12:13 -0800, Peter Collingbourne wrote: > I've added documentation and tests and addressed Ben's comments, and published > the staging branch 'console-pool'. PTAL. Thanks for splitting the commits. For the testing of it, since only Ninja supports it, maybe it would be p

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-05 Thread Peter Collingbourne
On Mon, Nov 03, 2014 at 04:22:56PM -0800, Peter Collingbourne wrote: > Hi all, > > This patch exposes the Ninja console pool feature via the add_custom_command > and add_custom_target commands. Specifically, it introduces a USE_CONSOLE > flag which can be used to communicate to the generator that

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-04 Thread Peter Collingbourne
On Tue, Nov 04, 2014 at 12:53:07AM -0500, Ben Boeckel wrote: > On Mon, Nov 03, 2014 at 16:22:56 -0800, Peter Collingbourne wrote: > > This patch exposes the Ninja console pool feature via the add_custom_command > > and add_custom_target commands. Specifically, it introduces a USE_CONSOLE > > flag w

Re: [cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-03 Thread Ben Boeckel
On Mon, Nov 03, 2014 at 16:22:56 -0800, Peter Collingbourne wrote: > This patch exposes the Ninja console pool feature via the add_custom_command > and add_custom_target commands. Specifically, it introduces a USE_CONSOLE > flag which can be used to communicate to the generator that the command > w

[cmake-developers] [wip/patch] Expose Ninja console pool feature for custom commands/targets

2014-11-03 Thread Peter Collingbourne
Hi all, This patch exposes the Ninja console pool feature via the add_custom_command and add_custom_target commands. Specifically, it introduces a USE_CONSOLE flag which can be used to communicate to the generator that the command would prefer to use the console. It has no effect on generators oth