Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Sebastian Holtermann
Am 27.07.2016 um 19:31 schrieb Ben Boeckel: On Wed, Jul 27, 2016 at 17:49:40 +0200, Sebastian Holtermann wrote: Is there an error exit function in CMake? Or just exit(-1); Here's an example I found: this->Makefile->IssueMessage( cmake::INTERNAL_ERROR, "fileFound is true but FileFoun

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Ben Boeckel
On Wed, Jul 27, 2016 at 17:49:40 +0200, Sebastian Holtermann wrote: > Is there an error exit function in CMake? > Or just exit(-1); Here's an example I found: this->Makefile->IssueMessage( cmake::INTERNAL_ERROR, "fileFound is true but FileFound is empty!"); after that, it is treated as

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Sebastian Holtermann
Am 27.07.2016 um 17:49 schrieb Sebastian Holtermann: Doing so I found that Base64 allows '+' and '/' as characters which is bad for directory names obviously. For now these characters get replaced with 'A' and 'B'. '_' and '@' would be better replacements (with comments why they are used) sin

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Sebastian Holtermann
Doing so I found that Base64 allows '+' and '/' as characters which is bad for directory names obviously. For now these characters get replaced with 'A' and 'B'. '_' and '@' would be better replacements (with comments why they are used) since 'A' and 'B' are already characters in Base64. Som

Re: [cmake-developers] Autogen subdirectories patches

2016-07-27 Thread Ben Boeckel
On Tue, Jul 26, 2016 at 23:38:34 +0200, Sebastian Holtermann wrote: > Doing so I found that Base64 allows '+' and '/' as characters which is > bad for directory names obviously. > For now these characters get replaced with 'A' and 'B'. '_' and '@' would be better replacements (with comments why t

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Stephen Kelly
Sebastian Holtermann wrote: >> It might be better to just use a NULL sentinel at the end of the array. >> If not, the extra spaces here should go away. > > I have changed that to use a NULL sentinel. > std::array would be the best solution IMO but it is not allowed, is it? You could use cmArrayB

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Sebastian Holtermann
Thanks for the feedback. I have prepared an other approach which uses checksum suffixes instead of nested directory generation. This was tested on my Debian/amd64/Makefile setup. Interesting; I like it. Might be worthwhile to reuse it for the .o files in the future as well (since these can con

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Ben Boeckel
On Tue, Jul 26, 2016 at 17:31:00 +0200, Sebastian Holtermann wrote: > I have prepared an other approach which uses checksum suffixes > instead of nested directory generation. > This was tested on my Debian/amd64/Makefile setup. Interesting; I like it. Might be worthwhile to reuse it for the .o fil

Re: [cmake-developers] Autogen subdirectories patches

2016-07-26 Thread Sebastian Holtermann
Am 21.07.2016 um 17:40 schrieb Brad King: On 04/22/2016 09:37 AM, Brad King wrote: The rest of the changes are now in 'master'. Thanks for working on this! Unfortunately I've had to revert some of these changes due to regressions they cause. See issue here: https://gitlab.kitware.com/cmak

Re: [cmake-developers] Autogen subdirectories patches

2016-07-21 Thread Sebastian Holtermann
Am 21.07.2016 um 17:40 schrieb Brad King: On 04/22/2016 09:37 AM, Brad King wrote: The rest of the changes are now in 'master'. Thanks for working on this! Unfortunately I've had to revert some of these changes due to regressions they cause. See issue here: https://gitlab.kitware.com/cmak

Re: [cmake-developers] Autogen subdirectories patches

2016-07-21 Thread Brad King
On 04/22/2016 09:37 AM, Brad King wrote: > The rest of the changes are now in 'master'. Thanks for working on this! Unfortunately I've had to revert some of these changes due to regressions they cause. See issue here: https://gitlab.kitware.com/cmake/cmake/issues/16209 -Brad -- Powered by

Re: [cmake-developers] Autogen subdirectories patches

2016-04-23 Thread Sebastian Holtermann
Am 22.04.2016 um 15:37 schrieb Brad King: On 04/21/2016 03:14 AM, Sebastian Holtermann wrote: Thanks! I've applied them locally and merged the cleanup/refactoring commits to 'next' for testing first. Once those test cleanly I'll move on to the rest. It is good too see the patches made it int

Re: [cmake-developers] Autogen subdirectories patches

2016-04-22 Thread Brad King
On 04/21/2016 03:14 AM, Sebastian Holtermann wrote: >> Thanks! I've applied them locally and merged the cleanup/refactoring >> commits to 'next' for testing first. Once those test cleanly I'll move >> on to the rest. > > It is good too see the patches made it into the next branch. The rest of t

Re: [cmake-developers] Autogen subdirectories patches

2016-04-21 Thread Sebastian Holtermann
Am 19.04.2016 um 19:28 schrieb Brad King: On 04/19/2016 11:09 AM, Sebastian Holtermann wrote: https://cmake.org/Bug/view.php?id=12873 https://cmake.org/Bug/view.php?id=16068 They introduce - same name collision checks during moc/qrc/ui generation - moc/qrc generation in subdirectories to suppor

Re: [cmake-developers] Autogen subdirectories patches

2016-04-19 Thread Sebastian Holtermann
Am 19.04.2016 um 19:28 schrieb Brad King: On 04/19/2016 11:09 AM, Sebastian Holtermann wrote: https://cmake.org/Bug/view.php?id=12873 https://cmake.org/Bug/view.php?id=16068 They introduce - same name collision checks during moc/qrc/ui generation - moc/qrc generation in subdirectories to suppor

Re: [cmake-developers] Autogen subdirectories patches

2016-04-19 Thread Brad King
On 04/19/2016 11:09 AM, Sebastian Holtermann wrote: > https://cmake.org/Bug/view.php?id=12873 > https://cmake.org/Bug/view.php?id=16068 > > They introduce > - same name collision checks during moc/qrc/ui generation > - moc/qrc generation in subdirectories to support >sources with the name in d

[cmake-developers] Autogen subdirectories patches

2016-04-19 Thread Sebastian Holtermann
Hello again, I've prepared a set of patches that address https://cmake.org/Bug/view.php?id=12873 https://cmake.org/Bug/view.php?id=16068 They introduce - same name collision checks during moc/qrc/ui generation - moc/qrc generation in subdirectories to support sources with the name in different