[cmake-developers] Best practices questions

2012-10-16 Thread Petr Kmoch
Hi, I tried submitting my first patch recently (Issue 0013587) and I have a few follow-up questions regarding best practices: 1) Looking at the dashboard, I apparently forgot to quote a path somewhere in the test and it failed on spaces. What is the preferred way for me to provide a fix for the

Re: [cmake-developers] Best practices questions

2012-10-16 Thread Brad King
On 10/16/2012 10:36 AM, Petr Kmoch wrote: 1) Looking at the dashboard, I apparently forgot to quote a path somewhere in the test and it failed on spaces. What is the preferred way for me to provide a fix for the tests? A new commit normally continuing history of the patch as I submitted it?

Re: [cmake-developers] Best practices questions

2012-10-16 Thread Benjamin Eikel
Hello, Am Dienstag, 16. Oktober 2012 um 16:36:49 schrieb Petr Kmoch: 2) Is there a code style document I could read somewhere? I now understand line width is preferred at 79 columns max. and I believe I've figured out brace indenting; anything else I should follow? for writing CMake code I