Re: [cmake-developers] CMake user-provided manifest files

2015-09-18 Thread Brad King
On 09/16/2015 07:01 PM, James Johnston wrote: > That fixed it; just tested building a pile of projects with both Ninja and > VS2008 generators (with VS2008 used with Ninja). Great, thanks for testing. A revision of the commit is now in 'master': Add support for *.manifest source files with

Re: [cmake-developers] CMake user-provided manifest files

2015-09-16 Thread Brad King
On 09/14/2015 04:16 PM, Brad King wrote: > I think our path forward here is to teach the Makefile and Ninja > generators how to add user-specified manifest files to the "mt" > invocations as outlined above. I've drafted support for this in all generators, with a test: Add support for *.manifest

Re: [cmake-developers] CMake user-provided manifest files

2015-09-16 Thread James Johnston
> -Original Message- > From: Brad King [mailto:brad.k...@kitware.com] > Sent: Wednesday, September 16, 2015 20:13 > To: James Johnston; 'Gilles Khouzam' > Cc: cmake-developers@cmake.org > Subject: Re: [cmake-developers] CMake user-provided manifest files > > On 09

Re: [cmake-developers] CMake user-provided manifest files

2015-09-15 Thread James Johnston
> -Original Message- > From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] > On Behalf Of Brad King > Sent: Monday, September 14, 2015 20:16 > To: James Johnston > Cc: cmake-developers@cmake.org > Subject: Re: [cmake-developers] CMake user-provided mani

Re: [cmake-developers] CMake user-provided manifest files

2015-09-14 Thread Brad King
On 09/11/2015 03:02 PM, Brad King wrote: > On 09/11/2015 02:09 PM, Brad King wrote: >> I would be very happy to get rid of the vs_link_exe and vs_link_dll code. > > There is documentation here about what those are doing: > > https://msdn.microsoft.com/en-us/library/ms235591.aspx >

Re: [cmake-developers] CMake user-provided manifest files (was: Windows: Correctly determine Windows version)

2015-09-11 Thread Brad King
On 09/11/2015 11:45 AM, James Johnston wrote: > The second request is currently a big pain point with CMake to get working > correctly. Ideally I want to reproduce the VS way of doing things, which > is: > > a. Have link.exe generate default manifest for referencing the CRT > side-by-side

Re: [cmake-developers] CMake user-provided manifest files

2015-09-11 Thread Brad King
On 09/11/2015 02:09 PM, Brad King wrote: > I would be very happy to get rid of the vs_link_exe and vs_link_dll code. > The source is full of comments about why it is there (incremental linking). > If someone can get an alternative approach working that also supports > user-provided .manifest files