Re: [cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use
On 06/13/2016 10:16 AM, Brad King wrote: > On 06/12/2016 05:47 PM, Daniel Pfeifer wrote: >> I have set up a dashboard build where all three mechanisms are enabled: Thanks. It looks like you have a Continuous build for this. That will be nice in the future but for now it is not useful until the build is green for `master`. Please switch back to having an Experimental build instead while we get the rest of the current warnings fixed. FYI, I had to revert your attempt at fixing the stdint.h inclusion order from `next`: cmStandardLexer: #include https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=64157fa5 Revert "cmStandardLexer: #include " https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=93627769 Unfortunately the flex-generated output includes several headers before any content that comes from the input file. That means we will have to edit the generated source files to add the include of cm_kwiml.h (and perhaps cmConfigure.h). There is a comment block in the .in files that explains the modifications we already do to the generated output, so there is precedent for it. If you can get the headers added in the right place I can look at updating the instructions in the comment blocks. >> Who wants to resolve the link-what-you-use violations? > > Currently that infrastructure hasn't even reached 'master' yet. The link-what-you-use feature is now in `master`. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use
On 06/12/2016 05:47 PM, Daniel Pfeifer wrote: > I have set up a dashboard build where all three mechanisms are enabled: [snip] > I have already drastically reduced the number of clang-tidy warnings > in the last weeks. I am currently experimenting with > include-what-you-use and will push some changes in the coming days. Thanks for your work on this! > Who wants to resolve the link-what-you-use violations? Currently that infrastructure hasn't even reached 'master' yet. Once it has then we can look at these. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Dogfooding: clang-tidy, include-what-you-use, link-what-you-use
Hi, now that we have integrated include-what-you-use, clang-tidy, and just recently also a mechanism for link-what-you-use, it is time we start eating our own dog food. https://en.wikipedia.org/wiki/Eating_your_own_dog_food I have set up a dashboard build where all three mechanisms are enabled: https://open.cdash.org/viewBuildError.php?type=1=4408215 The buildscript can be seen here: https://github.com/purpleKarrot/dotfiles/blob/master/config/cmake/ci_cmake.cmake I have already drastically reduced the number of clang-tidy warnings in the last weeks. I am currently experimenting with include-what-you-use and will push some changes in the coming days. Who wants to resolve the link-what-you-use violations? cheers, Daniel -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
