Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-31 Thread Kislinskiy, Stefan
-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of CHEVRIER, Marc Sent: Freitag, 28. August 2015 10:07 To: Brad King; cmake-developers@cmake.org Subject: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens Offering generator-expressions

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-28 Thread CHEVRIER, Marc
Offering generator-expressions is a very good idea because it offers a global solution to this problem. Now regarding the name of the generator, may be TO_NATIVE_PATH is not judicious, (even if problems explained in http://www.cmake.org/Bug/view.php?id=5939 are, in my point of view, linked to

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-27 Thread Kislinskiy, Stefan
the feedback so far. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Donnerstag, 27. August 2015 15:10 To: Kislinskiy, Stefan; CHEVRIER, Marc; David Cole Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] ExternalProject: Use native paths as substitute

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-27 Thread Brad King
On 08/26/2015 03:35 AM, Kislinskiy, Stefan wrote: Would you prefer to have a switch for each *_DIR variable for all target steps, or a common switch but for each target step, like the new USE_TERMINAL switches in the master? [snip] Von: CHEVRIER, Marc [marc.chevr...@sap.com] Offering the

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-27 Thread Kislinskiy, Stefan
-developers] ExternalProject: Use native paths as substitute for directory tokens This is pretty nice from the perspective of an engineer. But I wonder if it wouldn't be kind of over-engineered in the sense that it would be a rather hidden feature for the purpose? -- I probably wouldn't

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-27 Thread James Johnston
native paths as substitute for directory tokens This is pretty nice from the perspective of an engineer. But I wonder if it wouldn't be kind of over-engineered in the sense that it would be a rather hidden feature for the purpose? -- I probably wouldn't think of searching for a generator

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-27 Thread Brad King
On 08/27/2015 10:06 AM, James Johnston wrote: I would vote naming it TO_NATIVE_PATH instead of PATH_FOR_SHELL, for consistency with the existing parameter in the file command. The file(TO_NATIVE_PATH) command is hopelessly ill-defined: http://www.cmake.org/Bug/view.php?id=5939 See also

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-26 Thread CHEVRIER, Marc
...@dkfz-heidelberg.de] Gesendet: Freitag, 21. August 2015 23:56 An: David Cole; James Johnston Cc: cmake-developers@cmake.org Betreff: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens What do you think about the new patch I attached to this mail

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-26 Thread Kislinskiy, Stefan
08:49 An: David Cole; Kislinskiy, Stefan Cc: cmake-developers@cmake.org Betreff: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens I agree with David. Offering the possibility to manage native paths in an easy way is a very good enhancement (Today, I

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-26 Thread Kislinskiy, Stefan
-developers@cmake.org Betreff: Re: AW: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens I didn’t even think about switches. I don’t think they are required. Adding the capability to handle paths in native format seems enough. Example: I want to use a specific

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-26 Thread CHEVRIER, Marc
An: David Cole; Kislinskiy, Stefan Cc: cmake-developers@cmake.org Betreff: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens I agree with David. Offering the possibility to manage native paths in an easy way is a very good enhancement (Today, I rely

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-26 Thread James Johnston
-Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Kislinskiy, Stefan Sent: Wednesday, August 26, 2015 10:03 To: CHEVRIER, Marc; David Cole Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] ExternalProject: Use native

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-25 Thread Kislinskiy, Stefan
An: David Cole; James Johnston Cc: cmake-developers@cmake.org Betreff: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens What do you think about the new patch I attached to this mail? It adds an option NATIVE_DIR_TOKENS to ExternalProjects_Add. I also

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-21 Thread Kislinskiy, Stefan
...@cmake.org] im Auftrag von David Cole via cmake-developers [cmake-developers@cmake.org] Gesendet: Donnerstag, 20. August 2015 23:20 An: James Johnston Cc: cmake-developers@cmake.org Betreff: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens It's

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-21 Thread Kislinskiy, Stefan
: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Kislinskiy, Stefan Sent: Thursday, August 20, 2015 09:02 To: David Cole Cc

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-20 Thread James Johnston
-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of James Johnston Sent: Donnerstag, 20. August 2015 15:37 To: cmake-developers@cmake.org Subject: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens -Original Message

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-20 Thread Kislinskiy, Stefan
native paths as substitute for directory tokens -Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Kislinskiy, Stefan Sent: Thursday, August 20, 2015 09:02 To: David Cole Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-20 Thread James Johnston
-Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of Kislinskiy, Stefan Sent: Thursday, August 20, 2015 09:02 To: David Cole Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] ExternalProject: Use native paths as substitute

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-20 Thread David Cole via cmake-developers
Subject: Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens Hi David, Example excerpt (it is not possible to change the working directory for the CONFIGURE_COMMAND as it is fixed to the BUILD_DIR, which might not be sufficient

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-20 Thread James Johnston
-Original Message- From: cmake-developers [mailto:cmake-developers-boun...@cmake.org] On Behalf Of David Cole via cmake-developers Sent: Thursday, August 20, 2015 21:21 To: James Johnston Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] ExternalProject: Use native

[cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-19 Thread Kislinskiy, Stefan
Hi, I would like to contribute a fix regarding directory tokens (e.g. SOURCE_DIR) in the ExternalProject module. These tokens are replaced by their matching target property value _EP_${dir}. However, the path substitutes are not converted to native path style which makes it impossible to use

Re: [cmake-developers] ExternalProject: Use native paths as substitute for directory tokens

2015-08-19 Thread David Cole via cmake-developers
But some existing replacements require forward slashes, we can't just to native path everything blindly. I think you will have to special case the bits which do need native paths. On Wednesday, August 19, 2015, Kislinskiy, Stefan s.kislins...@dkfz-heidelberg.de wrote: Hi, I would like to