Re: [cmake-developers] Feature request: file globbing in ADDITIONAL_MAKE_CLEAN_FILES

2016-09-04 Thread Steve Lorimer
Thanks Marc, I'll try that out!

On 2 September 2016 at 17:13, CHEVRIER, Marc <marc.chevr...@sap.com> wrote:

> A more generic approach for cleanup actions is to add a new property which
> enables to specify a cmake script. And, in the script, everyone is free to
> do what he wants…
>
> Example: set_directory_properties (PROPERTIES ADDITIONAL_MAKE_CLEAN_SCRIPT
> "my_clean_script.cmake")
>
>
>
> *From: *cmake-developers <cmake-developers-boun...@cmake.org> on behalf
> of Steve Lorimer <steve.lori...@gmail.com>
> *Date: *Friday 2 September 2016 at 01:32
> *To: *"cmake-developers@cmake.org" <cmake-developers@cmake.org>
> *Subject: *[cmake-developers] Feature request: file globbing in
> ADDITIONAL_MAKE_CLEAN_FILES
>
>
>
> As part of our build process we tag certain binary files with version
> information such as git branch, number of commits, build variant etc.
>
>
>
> Eg, for a binary called "app" we could install a file in the local source
> directory with the name "app.branch_foo.91.debug"
>
>
>
> The shell globbing pattern that matches is "app.*[0-9]*"
>
>
>
> I need a globbing pattern because the tag can change without the makefiles
> changing, so the tag can't be hardcoded into the makefile.
>
>
>
> If I specify a globbing pattern for ADDITIONAL_MAKE_CLEAN_FILES it
> specifies this as an actual file
>
>
>
> set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES
> app.*[0-9]*)
>
>
>
> This results in
>
>
>
> file(REMOVE_RECURSE
>
> "../../../app/app.*[0-9]*"
>
> ...
>
> )
>
>
>
> That doesn't work, because it's not a real file, it's a globbing pattern
>
>
>
> I've tried adding a nested file(GLOB ...) into the
> set_directory_properties but that doesn't work either.
>
>
>
> Is this a feature worthy of addition?
>
>
>
> - the ability to specify a globbing pattern in 
> set_directory_properties(PROPERTIES
> ADDITIONAL_MAKE_CLEAN_FILES ...)?
>
> - the ability to specify a globbing pattern in file(REMOVE_RECURSE ...)?
>
>
>
> TIA
>
> Steve
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Feature request: file globbing in ADDITIONAL_MAKE_CLEAN_FILES

2016-09-02 Thread CHEVRIER, Marc
A more generic approach for cleanup actions is to add a new property which 
enables to specify a cmake script. And, in the script, everyone is free to do 
what he wants…
Example: set_directory_properties (PROPERTIES ADDITIONAL_MAKE_CLEAN_SCRIPT 
"my_clean_script.cmake")

From: cmake-developers <cmake-developers-boun...@cmake.org> on behalf of Steve 
Lorimer <steve.lori...@gmail.com>
Date: Friday 2 September 2016 at 01:32
To: "cmake-developers@cmake.org" <cmake-developers@cmake.org>
Subject: [cmake-developers] Feature request: file globbing in 
ADDITIONAL_MAKE_CLEAN_FILES

As part of our build process we tag certain binary files with version 
information such as git branch, number of commits, build variant etc.

Eg, for a binary called "app" we could install a file in the local source 
directory with the name "app.branch_foo.91.debug"

The shell globbing pattern that matches is "app.*[0-9]*"

I need a globbing pattern because the tag can change without the makefiles 
changing, so the tag can't be hardcoded into the makefile.

If I specify a globbing pattern for ADDITIONAL_MAKE_CLEAN_FILES it specifies 
this as an actual file

set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES app.*[0-9]*)

This results in

file(REMOVE_RECURSE
"../../../app/app.*[0-9]*"
...
)

That doesn't work, because it's not a real file, it's a globbing pattern

I've tried adding a nested file(GLOB ...) into the set_directory_properties but 
that doesn't work either.

Is this a feature worthy of addition?

- the ability to specify a globbing pattern in 
set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES ...)?
- the ability to specify a globbing pattern in file(REMOVE_RECURSE ...)?

TIA
Steve
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Feature request: file globbing in ADDITIONAL_MAKE_CLEAN_FILES

2016-09-01 Thread Steve Lorimer
As part of our build process we tag certain binary files with version
information such as git branch, number of commits, build variant etc.

Eg, for a binary called "app" we could install a file in the local source
directory with the name "app.branch_foo.91.debug"

The shell globbing pattern that matches is "app.*[0-9]*"

I need a globbing pattern because the tag can change without the makefiles
changing, so the tag can't be hardcoded into the makefile.

If I specify a globbing pattern for ADDITIONAL_MAKE_CLEAN_FILES it
specifies this as an actual file

set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES
app.*[0-9]*)

This results in

file(REMOVE_RECURSE
"../../../app/app.*[0-9]*"
...
)

That doesn't work, because it's not a real file, it's a globbing pattern

I've tried adding a nested file(GLOB ...) into the set_directory_properties
but that doesn't work either.

Is this a feature worthy of addition?

- the ability to specify a globbing pattern in
set_directory_properties(PROPERTIES
ADDITIONAL_MAKE_CLEAN_FILES ...)?
- the ability to specify a globbing pattern in file(REMOVE_RECURSE ...)?

TIA
Steve
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers