Re: [cmake-developers] Github pull request for CPack NSIS generator

2012-05-28 Thread Eric Noulard
2012/5/25 Brad King brad.k...@kitware.com: On 05/25/2012 09:38 AM, Eric Noulard wrote: 2012/5/25 Brad King brad.k...@kitware.com:  https://github.com/Kitware/CMake/pull/5 I'm not a too good NSIS tester since my usual system is Linux :-) I do cross-test NSIS (cross compile win32 on Linux +

Re: [cmake-developers] Github pull request for CPack NSIS generator

2012-05-28 Thread Brad King
On 05/28/2012 11:05 AM, Eric Noulard wrote: I did create a branch (based on current) master which contains the fix, I did some basic testing but I may be you want to test it yourself before I merge it? stage/cpack-nsis-menu-links-adapted Thanks. It looks good except that the Signed-off-by

[cmake-developers] Github pull request for CPack NSIS generator

2012-05-25 Thread Brad King
Eric, Please take a look at this request: https://github.com/Kitware/CMake/pull/5 Only the first commit is relevant, the rest are merges from upstream. You can fetch the relevant part of the branch like this: $ git fetch git://github.com/Fraser999/CMake.git master $ git checkout -b

Re: [cmake-developers] Github pull request for CPack NSIS generator

2012-05-25 Thread Eric Noulard
2012/5/25 Brad King brad.k...@kitware.com: Eric, Please take a look at this request:  https://github.com/Kitware/CMake/pull/5 Only the first commit is relevant, the rest are merges from upstream. You can fetch the relevant part of the branch like this:  $ git fetch