On 11/15/2011 4:50 PM, Brad King wrote:
On 11/15/2011 3:54 PM, Alexander Neundorf wrote:
Maybe you'll prefer a more map-like implementation ?
The commit you merged to next:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3c265207
looks pretty good. I think the message would look
On Thu, Nov 17, 2011 at 10:59 AM, Brad King brad.k...@kitware.com wrote:
looks pretty good. I think the message would look better if the generated
code looked like this:
The new version of the message you committed still didn't format
nicely for me with long file paths containing spaces.
On Monday 14 November 2011, you wrote:
On 11/14/2011 4:01 PM, Alexander Neundorf wrote:
Instead of adding the code to the bottom of GenerateImportPropertyCode
please create a separate method next to it for that part.
Done, in an updated version of the
On Tue, Nov 15, 2011 at 1:19 PM, Alexander Neundorf neund...@kde.org wrote:
On Monday 14 November 2011, you wrote:
On 11/14/2011 4:01 PM, Alexander Neundorf wrote:
Instead of adding the code to the bottom of GenerateImportPropertyCode
please create a separate method next to it for that part.
On 11/15/2011 1:24 PM, David Cole wrote:
On Tue, Nov 15, 2011 at 1:19 PM, Alexander Neundorfneund...@kde.org wrote:
function(check_for_file _file _target)
if(NOT EXISTS _file)
message(FATAL_ERROR ... long error message...)
endfunction()
check_for_file(libFoo123.so Foo)
...
On Tuesday 15 November 2011, Brad King wrote:
On 11/15/2011 1:24 PM, David Cole wrote:
On Tue, Nov 15, 2011 at 1:19 PM, Alexander Neundorfneund...@kde.org
wrote:
function(check_for_file _file _target)
if(NOT EXISTS _file)
message(FATAL_ERROR ... long error message...)
On 11/15/2011 3:54 PM, Alexander Neundorf wrote:
Maybe you'll prefer a more map-like implementation ?
Yes.
I don't like the function because it pollutes the global namespace of
functions. I took great care to design imported targets so they only
affect a directory namespace. They are very
On 11/12/2011 3:53 PM, David Cole wrote:
And, in my opinion, if there are multiple possible causes of the
problem then we should enumerate them in a message to the user,
just as you've done here in this email back to me. And we should try
to put them in the order of likelihood, so when they
On Monday 14 November 2011, Brad King wrote:
On 11/12/2011 3:53 PM, David Cole wrote:
And, in my opinion, if there are multiple possible causes of the
problem then we should enumerate them in a message to the user,
just as you've done here in this email back to me. And we should try
On Saturday 12 November 2011, Alexander Neundorf wrote:
Hi,
I added a branch CheckImportedFileExistenceInConfigDotCMakeFiles cmake
stage.
This is the commit:
http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=1b12babe0cef55a0d5531a9d0d453a15598eb467
Alex
--
Powered by www.kitware.com
10 matches
Mail list logo
