Re: [cmake-developers] Making the default install component name configurable
On Tuesday 22 May 2012, Alexander Neundorf wrote: On Monday 14 May 2012, Alexander Neundorf wrote: On Monday 14 May 2012, Brad King wrote: On 5/13/2012 2:15 PM, Alexander Neundorf wrote: the CMAKE_DEFAULT_INSTALL_COMPONENT_NAME variable is still in Unspecified, so this is still the default. I'd rather the name be CMAKE_INSTALL_DEFAULT_COMPONENT_NAME to keep the CMAKE_INSTALL_ prefix for variables affecting installation (along with CMAKE_INSTALL_PREFIX). Done, updated branch pushed. I've merged it into next now. Could this failure be caused by my commit ? http://open.cdash.org/testDetails.php?test=147001711build=2299302 The default behaviour should not have changed. Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Making the default install component name configurable
On Monday 14 May 2012, Brad King wrote: On 5/13/2012 2:15 PM, Alexander Neundorf wrote: the CMAKE_DEFAULT_INSTALL_COMPONENT_NAME variable is still in Unspecified, so this is still the default. I'd rather the name be CMAKE_INSTALL_DEFAULT_COMPONENT_NAME to keep the CMAKE_INSTALL_ prefix for variables affecting installation (along with CMAKE_INSTALL_PREFIX). Or shorter CMAKE_INSTALL_DEFAULT_COMPONENT ? But that sounds more like a boolean switch... Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Making the default install component name configurable
2012/5/14 Alexander Neundorf neund...@kde.org: On Monday 14 May 2012, Brad King wrote: On 5/13/2012 2:15 PM, Alexander Neundorf wrote: the CMAKE_DEFAULT_INSTALL_COMPONENT_NAME variable is still in Unspecified, so this is still the default. I'd rather the name be CMAKE_INSTALL_DEFAULT_COMPONENT_NAME to keep the CMAKE_INSTALL_ prefix for variables affecting installation (along with CMAKE_INSTALL_PREFIX). Or shorter CMAKE_INSTALL_DEFAULT_COMPONENT ? But that sounds more like a boolean switch... Yes agreed. I'd rather go for CMAKE_INSTALL_DEFAULT_COMPONENT_NAME or may be CMAKE_INSTALL_UNSPECIFIED_COMPONENT_NAME and in any case I agree with Brad concerning the CMAKE_INSTALL_ prefix. -- Erk Le gouvernement représentatif n'est pas la démocratie -- http://www.le-message.org -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Making the default install component name configurable
On Monday 14 May 2012, Brad King wrote: On 5/13/2012 2:15 PM, Alexander Neundorf wrote: the CMAKE_DEFAULT_INSTALL_COMPONENT_NAME variable is still in Unspecified, so this is still the default. I'd rather the name be CMAKE_INSTALL_DEFAULT_COMPONENT_NAME to keep the CMAKE_INSTALL_ prefix for variables affecting installation (along with CMAKE_INSTALL_PREFIX). Done, updated branch pushed. Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
[cmake-developers] Making the default install component name configurable
Hi, the install() command has a COMPONENT argument. If this is not used, such unnamed components are always named Unspecified. In the MakeDefaultInstallComponentNameConfigurable branch on stage I added a new cmake variable CMAKE_DEFAULT_INSTALL_COMPONENT_NAME, which is now used instead. It is initialized to Unspecified, so if nobody does anything, everything stays as it was. But if needed, this variable can now be set to something project-specific or directory specific. Comments ? Alex P.S. documentation is still missing, will do this soon -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
Re: [cmake-developers] Making the default install component name configurable
On Sunday 13 May 2012, Eric Noulard wrote: 2012/5/13 Alexander Neundorf neund...@kde.org: Hi, the install() command has a COMPONENT argument. If this is not used, such unnamed components are always named Unspecified. In the MakeDefaultInstallComponentNameConfigurable branch on stage I added a new cmake variable CMAKE_DEFAULT_INSTALL_COMPONENT_NAME, which is now used instead. It is initialized to Unspecified, so if nobody does anything, everything stays as it was. But if needed, this variable can now be set to something project-specific or directory specific. Comments ? This looks like a nice feature. It will have a may-be unoticeable side-effect with CPack. That's why I CC'd you :-) Currently CPack.cmake do automatically require the default component to be installed (if specified in CPACK_COMPONENTS_ALL) . You can see that, because you have: Modules/CPack.cmake:set(CPACK_COMPONENT_UNSPECIFIED_HIDDEN TRUE) Modules/CPack.cmake:set(CPACK_COMPONENT_UNSPECIFIED_REQUIRED TRUE) As soon as the user do change the default component he/she will loose this automatic behavior and shall set(CPACK_COMPONENT_compName_REQUIRED TRUE) in order to get back this behavior. We could patch CPack.cmake in the case where CMAKE_DEFAULT_INSTALL_COMPONENT_NAME is set globally but if it is set on a per-directory basis then it would be up to the user to set CPACK_COMPONENT_compName_ variables with appropriate value. I think this should be ok. I mean, everything where the project does not change the CMAKE_DEFAULT_INSTALL_COMPONENT_NAME variable is still in Unspecified, so this is still the default. And everything else has been set explicitely by the user, so it should be ok if he has the set the respective cpack variables, I think. Alex -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
